Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Handle multi-value tagging for client spans #7943

Closed
wants to merge 6 commits into from
Closed

[WIP] Handle multi-value tagging for client spans #7943

wants to merge 6 commits into from

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Nov 12, 2024 •
edited
Loading

This PR is getting very large and convoluted. I am going to split it up and start small.

What Does This Do

The goal of this PR is to handle multi-value tagging for client spans.

Motivation

Currently, the HTTP protocol allows splitting the header into multiple lines per value; however, the Java tracer only allows users to extrace the first value of the HTTP header. This PR will now allow extracting multi-valued multi-line headers. This PR would help allow extracting multi-valued multi-line HTTP headers in conjunction with #7943.

Additional Notes

This PR is made in response to this Jira ticket.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/allow-multiline-headers
git_commit_date 1732206855 1732226983
git_commit_sha 58de7ff 7573e13
release_version 1.43.0-SNAPSHOT~58de7ff6c6 1.43.0-SNAPSHOT~7573e13ddb
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732229507 1732229507
ci_job_id 716444037 716444037
ci_pipeline_id 49679625 49679625
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~7573e13ddb, baseline=1.43.0-SNAPSHOT~58de7ff6c6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085976
Total [baseline] (10.447 s) : 0, 10446724
Agent [candidate] (1.089 s) : 0, 1089386
Total [candidate] (10.537 s) : 0, 10536698
section appsec
Agent [baseline] (1.226 s) : 0, 1226112
Total [baseline] (10.737 s) : 0, 10737383
Agent [candidate] (1.229 s) : 0, 1228930
Total [candidate] (10.715 s) : 0, 10714516
section iast
Agent [baseline] (1.214 s) : 0, 1214461
Total [baseline] (10.936 s) : 0, 10935896
Agent [candidate] (1.225 s) : 0, 1224692
Total [candidate] (10.973 s) : 0, 10973014
section profiling
Agent [baseline] (1.29 s) : 0, 1289519
Total [baseline] (10.825 s) : 0, 10825051
Agent [candidate] (1.296 s) : 0, 1296254
Total [candidate] (10.833 s) : 0, 10832762
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.226 s 140.136 ms (12.9%)
Agent iast 1.214 s 128.486 ms (11.8%)
Agent profiling 1.29 s 203.544 ms (18.7%)
Total tracing 10.447 s -
Total appsec 10.737 s 290.66 ms (2.8%)
Total iast 10.936 s 489.172 ms (4.7%)
Total profiling 10.825 s 378.327 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent appsec 1.229 s 139.543 ms (12.8%)
Agent iast 1.225 s 135.305 ms (12.4%)
Agent profiling 1.296 s 206.867 ms (19.0%)
Total tracing 10.537 s -
Total appsec 10.715 s 177.817 ms (1.7%)
Total iast 10.973 s 436.316 ms (4.1%)
Total profiling 10.833 s 296.063 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~7573e13ddb, baseline=1.43.0-SNAPSHOT~58de7ff6c6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.684 ms) : 0, 690684
BytebuddyAgent [candidate] (691.624 ms) : 0, 691624
GlobalTracer [baseline] (316.438 ms) : 0, 316438
GlobalTracer [candidate] (317.264 ms) : 0, 317264
AppSec [baseline] (54.509 ms) : 0, 54509
AppSec [candidate] (54.565 ms) : 0, 54565
Remote Config [baseline] (684.2 µs) : 0, 684
Remote Config [candidate] (687.855 µs) : 0, 688
Telemetry [baseline] (9.997 ms) : 0, 9997
Telemetry [candidate] (11.531 ms) : 0, 11531
section appsec
BytebuddyAgent [baseline] (712.264 ms) : 0, 712264
BytebuddyAgent [candidate] (713.582 ms) : 0, 713582
GlobalTracer [baseline] (314.559 ms) : 0, 314559
GlobalTracer [candidate] (316.253 ms) : 0, 316253
AppSec [baseline] (166.871 ms) : 0, 166871
AppSec [candidate] (167.297 ms) : 0, 167297
Remote Config [baseline] (647.964 µs) : 0, 648
Remote Config [candidate] (652.241 µs) : 0, 652
Telemetry [baseline] (7.895 ms) : 0, 7895
Telemetry [candidate] (7.506 ms) : 0, 7506
IAST [baseline] (20.388 ms) : 0, 20388
IAST [candidate] (19.675 ms) : 0, 19675
section iast
BytebuddyAgent [baseline] (807.846 ms) : 0, 807846
BytebuddyAgent [candidate] (815.428 ms) : 0, 815428
GlobalTracer [baseline] (305.855 ms) : 0, 305855
GlobalTracer [candidate] (307.936 ms) : 0, 307936
AppSec [baseline] (57.992 ms) : 0, 57992
AppSec [candidate] (58.112 ms) : 0, 58112
Remote Config [baseline] (620.315 µs) : 0, 620
Remote Config [candidate] (621.17 µs) : 0, 621
Telemetry [baseline] (7.461 ms) : 0, 7461
Telemetry [candidate] (7.552 ms) : 0, 7552
IAST [baseline] (21.003 ms) : 0, 21003
IAST [candidate] (21.188 ms) : 0, 21188
section profiling
BytebuddyAgent [baseline] (686.633 ms) : 0, 686633
BytebuddyAgent [candidate] (691.352 ms) : 0, 691352
GlobalTracer [baseline] (402.657 ms) : 0, 402657
GlobalTracer [candidate] (403.99 ms) : 0, 403990
AppSec [baseline] (55.489 ms) : 0, 55489
AppSec [candidate] (55.415 ms) : 0, 55415
Remote Config [baseline] (672.763 µs) : 0, 673
Remote Config [candidate] (682.668 µs) : 0, 683
Telemetry [baseline] (11.444 ms) : 0, 11444
Telemetry [candidate] (11.288 ms) : 0, 11288
ProfilingAgent [baseline] (93.585 ms) : 0, 93585
ProfilingAgent [candidate] (94.166 ms) : 0, 94166
Profiling [baseline] (93.61 ms) : 0, 93610
Profiling [candidate] (94.191 ms) : 0, 94191
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~7573e13ddb, baseline=1.43.0-SNAPSHOT~58de7ff6c6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093572
Total [baseline] (8.677 s) : 0, 8676574
Agent [candidate] (1.089 s) : 0, 1088835
Total [candidate] (8.645 s) : 0, 8645149
section iast
Agent [baseline] (1.227 s) : 0, 1227140
Total [baseline] (9.264 s) : 0, 9264349
Agent [candidate] (1.224 s) : 0, 1223988
Total [candidate] (9.183 s) : 0, 9182968
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.216 s) : 0, 1216406
Total [baseline] (9.206 s) : 0, 9206444
Agent [candidate] (1.215 s) : 0, 1214722
Total [candidate] (9.142 s) : 0, 9141601
section iast_TELEMETRY_OFF
Agent [baseline] (1.221 s) : 0, 1221349
Total [baseline] (9.226 s) : 0, 9225597
Agent [candidate] (1.215 s) : 0, 1214818
Total [candidate] (9.188 s) : 0, 9188352
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.094 s -
Agent iast 1.227 s 133.568 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.216 s 122.834 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.221 s 127.777 ms (11.7%)
Total tracing 8.677 s -
Total iast 9.264 s 587.775 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.206 s 529.871 ms (6.1%)
Total iast_TELEMETRY_OFF 9.226 s 549.023 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent iast 1.224 s 135.153 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.215 s 125.887 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.215 s 125.983 ms (11.6%)
Total tracing 8.645 s -
Total iast 9.183 s 537.819 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.142 s 496.452 ms (5.7%)
Total iast_TELEMETRY_OFF 9.188 s 543.202 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~7573e13ddb, baseline=1.43.0-SNAPSHOT~58de7ff6c6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.806 ms) : 0, 696806
BytebuddyAgent [candidate] (693.027 ms) : 0, 693027
GlobalTracer [baseline] (318.172 ms) : 0, 318172
GlobalTracer [candidate] (317.485 ms) : 0, 317485
AppSec [baseline] (54.748 ms) : 0, 54748
AppSec [candidate] (54.582 ms) : 0, 54582
Remote Config [baseline] (703.794 µs) : 0, 704
Remote Config [candidate] (693.359 µs) : 0, 693
Telemetry [baseline] (9.313 ms) : 0, 9313
Telemetry [candidate] (9.297 ms) : 0, 9297
section iast
BytebuddyAgent [baseline] (815.592 ms) : 0, 815592
BytebuddyAgent [candidate] (814.838 ms) : 0, 814838
GlobalTracer [baseline] (309.329 ms) : 0, 309329
GlobalTracer [candidate] (307.489 ms) : 0, 307489
AppSec [baseline] (57.911 ms) : 0, 57911
AppSec [candidate] (56.833 ms) : 0, 56833
IAST [baseline] (22.129 ms) : 0, 22129
IAST [candidate] (22.746 ms) : 0, 22746
Remote Config [baseline] (663.759 µs) : 0, 664
Remote Config [candidate] (624.847 µs) : 0, 625
Telemetry [baseline] (7.7 ms) : 0, 7700
Telemetry [candidate] (7.597 ms) : 0, 7597
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (808.673 ms) : 0, 808673
BytebuddyAgent [candidate] (807.993 ms) : 0, 807993
GlobalTracer [baseline] (306.11 ms) : 0, 306110
GlobalTracer [candidate] (305.973 ms) : 0, 305973
AppSec [baseline] (57.865 ms) : 0, 57865
AppSec [candidate] (56.539 ms) : 0, 56539
IAST [baseline] (21.811 ms) : 0, 21811
IAST [candidate] (22.436 ms) : 0, 22436
Remote Config [baseline] (631.418 µs) : 0, 631
Remote Config [candidate] (622.023 µs) : 0, 622
Telemetry [baseline] (7.579 ms) : 0, 7579
Telemetry [candidate] (7.42 ms) : 0, 7420
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (811.654 ms) : 0, 811654
BytebuddyAgent [candidate] (805.338 ms) : 0, 805338
GlobalTracer [baseline] (307.717 ms) : 0, 307717
GlobalTracer [candidate] (307.704 ms) : 0, 307704
AppSec [baseline] (59.033 ms) : 0, 59033
AppSec [candidate] (59.292 ms) : 0, 59292
IAST [baseline] (20.903 ms) : 0, 20903
IAST [candidate] (20.573 ms) : 0, 20573
Remote Config [baseline] (631.919 µs) : 0, 632
Remote Config [candidate] (628.753 µs) : 0, 629
Telemetry [baseline] (7.587 ms) : 0, 7587
Telemetry [candidate] (7.542 ms) : 0, 7542
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-21T22:21:57 2024-11-21T22:28:52
git_branch master sarahchen6/allow-multiline-headers
git_commit_date 1732206855 1732226983
git_commit_sha 58de7ff 7573e13
release_version 1.43.0-SNAPSHOT~58de7ff6c6 1.43.0-SNAPSHOT~7573e13ddb
start_time 2024-11-21T22:21:43 2024-11-21T22:28:39
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732228484 1732228484
ci_job_id 716444038 716444038
ci_pipeline_id 49679625 49679625
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~7573e13ddb, baseline=1.43.0-SNAPSHOT~58de7ff6c6
    dateFormat X
    axisFormat %s
section baseline
no_agent (361.297 µs) : 342, 381
.   : milestone, 361,
iast (485.705 µs) : 464, 507
.   : milestone, 486,
iast_FULL (645.172 µs) : 624, 667
.   : milestone, 645,
iast_GLOBAL (507.309 µs) : 486, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (484.52 µs) : 463, 506
.   : milestone, 485,
iast_INACTIVE (441.147 µs) : 420, 462
.   : milestone, 441,
iast_TELEMETRY_OFF (477.021 µs) : 456, 498
.   : milestone, 477,
tracing (441.907 µs) : 421, 463
.   : milestone, 442,
section candidate
no_agent (371.935 µs) : 351, 392
.   : milestone, 372,
iast (485.106 µs) : 464, 507
.   : milestone, 485,
iast_FULL (644.574 µs) : 623, 666
.   : milestone, 645,
iast_GLOBAL (516.792 µs) : 495, 539
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (490.624 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (445.086 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (470.384 µs) : 449, 492
.   : milestone, 470,
tracing (444.377 µs) : 423, 466
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.297 µs [341.595 µs, 380.998 µs] -
iast 485.705 µs [464.415 µs, 506.996 µs] 124.409 µs (34.4%)
iast_FULL 645.172 µs [623.72 µs, 666.625 µs] 283.876 µs (78.6%)
iast_GLOBAL 507.309 µs [485.944 µs, 528.674 µs] 146.013 µs (40.4%)
iast_HARDCODED_SECRET_DISABLED 484.52 µs [463.176 µs, 505.863 µs] 123.223 µs (34.1%)
iast_INACTIVE 441.147 µs [420.459 µs, 461.835 µs] 79.85 µs (22.1%)
iast_TELEMETRY_OFF 477.021 µs [455.801 µs, 498.241 µs] 115.724 µs (32.0%)
tracing 441.907 µs [421.111 µs, 462.703 µs] 80.611 µs (22.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.935 µs [351.45 µs, 392.421 µs] -
iast 485.106 µs [463.573 µs, 506.639 µs] 113.171 µs (30.4%)
iast_FULL 644.574 µs [623.153 µs, 665.995 µs] 272.639 µs (73.3%)
iast_GLOBAL 516.792 µs [494.807 µs, 538.776 µs] 144.856 µs (38.9%)
iast_HARDCODED_SECRET_DISABLED 490.624 µs [468.884 µs, 512.363 µs] 118.688 µs (31.9%)
iast_INACTIVE 445.086 µs [424.195 µs, 465.976 µs] 73.15 µs (19.7%)
iast_TELEMETRY_OFF 470.384 µs [449.101 µs, 491.667 µs] 98.449 µs (26.5%)
tracing 444.377 µs [423.0 µs, 465.753 µs] 72.441 µs (19.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~7573e13ddb, baseline=1.43.0-SNAPSHOT~58de7ff6c6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1323, 1363
.   : milestone, 1343,
appsec (1.739 ms) : 1714, 1764
.   : milestone, 1739,
appsec_no_iast (1.748 ms) : 1724, 1772
.   : milestone, 1748,
iast (1.464 ms) : 1442, 1486
.   : milestone, 1464,
profiling (1.498 ms) : 1473, 1522
.   : milestone, 1498,
tracing (1.472 ms) : 1448, 1497
.   : milestone, 1472,
section candidate
no_agent (1.337 ms) : 1317, 1358
.   : milestone, 1337,
appsec (1.744 ms) : 1720, 1769
.   : milestone, 1744,
appsec_no_iast (1.751 ms) : 1726, 1776
.   : milestone, 1751,
iast (1.484 ms) : 1462, 1507
.   : milestone, 1484,
profiling (1.535 ms) : 1512, 1559
.   : milestone, 1535,
tracing (1.483 ms) : 1458, 1508
.   : milestone, 1483,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.323 ms, 1.363 ms] -
appsec 1.739 ms [1.714 ms, 1.764 ms] 395.93 µs (29.5%)
appsec_no_iast 1.748 ms [1.724 ms, 1.772 ms] 405.202 µs (30.2%)
iast 1.464 ms [1.442 ms, 1.486 ms] 121.318 µs (9.0%)
profiling 1.498 ms [1.473 ms, 1.522 ms] 154.512 µs (11.5%)
tracing 1.472 ms [1.448 ms, 1.497 ms] 129.299 µs (9.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.317 ms, 1.358 ms] -
appsec 1.744 ms [1.72 ms, 1.769 ms] 406.998 µs (30.4%)
appsec_no_iast 1.751 ms [1.726 ms, 1.776 ms] 413.106 µs (30.9%)
iast 1.484 ms [1.462 ms, 1.507 ms] 146.848 µs (11.0%)
profiling 1.535 ms [1.512 ms, 1.559 ms] 197.922 µs (14.8%)
tracing 1.483 ms [1.458 ms, 1.508 ms] 145.828 µs (10.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/allow-multiline-headers
git_commit_date 1732206855 1732226983
git_commit_sha 58de7ff 7573e13
release_version 1.43.0-SNAPSHOT~58de7ff6c6 1.43.0-SNAPSHOT~7573e13ddb
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732229183 1732229183
ci_job_id 716444039 716444039
ci_pipeline_id 49679625 49679625
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 7 metrics, 0 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:dacapo:tomcat:appsec worse
[+0.993ms; +1.085ms] or [+42.461%; +46.405%]		 3.376ms 2.338ms
scenario:dacapo:tomcat:iast worse
[+1.329ms; +1.446ms] or [+63.678%; +69.264%]		 3.475ms 2.087ms
scenario:dacapo:tomcat:iast_GLOBAL worse
[+1.277ms; +1.393ms] or [+59.921%; +65.392%]		 3.465ms 2.130ms
scenario:dacapo:tomcat:profiling worse
[+1.438ms; +1.534ms] or [+73.029%; +77.944%]		 3.454ms 1.968ms
scenario:dacapo:tomcat:tracing worse
[+1.353ms; +1.444ms] or [+70.338%; +75.038%]		 3.322ms 1.924ms
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~7573e13ddb, baseline=1.43.0-SNAPSHOT~58de7ff6c6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.034 s) : 15034000, 15034000
.   : milestone, 15034000,
appsec (15.008 s) : 15008000, 15008000
.   : milestone, 15008000,
iast (18.89 s) : 18890000, 18890000
.   : milestone, 18890000,
iast_GLOBAL (17.576 s) : 17576000, 17576000
.   : milestone, 17576000,
profiling (14.747 s) : 14747000, 14747000
.   : milestone, 14747000,
tracing (14.899 s) : 14899000, 14899000
.   : milestone, 14899000,
section candidate
no_agent (14.932 s) : 14932000, 14932000
.   : milestone, 14932000,
appsec (14.965 s) : 14965000, 14965000
.   : milestone, 14965000,
iast (18.639 s) : 18639000, 18639000
.   : milestone, 18639000,
iast_GLOBAL (18.317 s) : 18317000, 18317000
.   : milestone, 18317000,
profiling (14.816 s) : 14816000, 14816000
.   : milestone, 14816000,
tracing (14.926 s) : 14926000, 14926000
.   : milestone, 14926000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.034 s [15.034 s, 15.034 s] -
appsec 15.008 s [15.008 s, 15.008 s] -26.0 ms (-0.2%)
iast 18.89 s [18.89 s, 18.89 s] 3.856 s (25.6%)
iast_GLOBAL 17.576 s [17.576 s, 17.576 s] 2.542 s (16.9%)
profiling 14.747 s [14.747 s, 14.747 s] -287.0 ms (-1.9%)
tracing 14.899 s [14.899 s, 14.899 s] -135.0 ms (-0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.932 s [14.932 s, 14.932 s] -
appsec 14.965 s [14.965 s, 14.965 s] 33.0 ms (0.2%)
iast 18.639 s [18.639 s, 18.639 s] 3.707 s (24.8%)
iast_GLOBAL 18.317 s [18.317 s, 18.317 s] 3.385 s (22.7%)
profiling 14.816 s [14.816 s, 14.816 s] -116.0 ms (-0.8%)
tracing 14.926 s [14.926 s, 14.926 s] -6.0 ms (-0.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~7573e13ddb, baseline=1.43.0-SNAPSHOT~58de7ff6c6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.338 ms) : 2296, 2379
.   : milestone, 2338,
iast (2.087 ms) : 2034, 2140
.   : milestone, 2087,
iast_GLOBAL (2.13 ms) : 2078, 2183
.   : milestone, 2130,
profiling (1.968 ms) : 1926, 2011
.   : milestone, 1968,
tracing (1.924 ms) : 1884, 1964
.   : milestone, 1924,
section candidate
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (3.376 ms) : 3332, 3421
.   : milestone, 3376,
iast (3.475 ms) : 3420, 3530
.   : milestone, 3475,
iast_GLOBAL (3.465 ms) : 3409, 3521
.   : milestone, 3465,
profiling (3.454 ms) : 3407, 3501
.   : milestone, 3454,
tracing (3.322 ms) : 3278, 3366
.   : milestone, 3322,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.338 ms [2.296 ms, 2.379 ms] 868.425 µs (59.1%)
iast 2.087 ms [2.034 ms, 2.14 ms] 618.131 µs (42.1%)
iast_GLOBAL 2.13 ms [2.078 ms, 2.183 ms] 661.04 µs (45.0%)
profiling 1.968 ms [1.926 ms, 2.011 ms] 499.178 µs (34.0%)
tracing 1.924 ms [1.884 ms, 1.964 ms] 454.512 µs (30.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 3.376 ms [3.332 ms, 3.421 ms] 1.907 ms (129.8%)
iast 3.475 ms [3.42 ms, 3.53 ms] 2.006 ms (136.5%)
iast_GLOBAL 3.465 ms [3.409 ms, 3.521 ms] 1.996 ms (135.8%)
profiling 3.454 ms [3.407 ms, 3.501 ms] 1.985 ms (135.1%)
tracing 3.322 ms [3.278 ms, 3.366 ms] 1.853 ms (126.1%)

@sarahchen6 sarahchen6 force-pushed the sarahchen6/allow-multiline-headers branch 4 times, most recently from f54d547 to a8ade65 Compare November 18, 2024 21:21
@sarahchen6 sarahchen6 force-pushed the sarahchen6/allow-multiline-headers branch from a8ade65 to 570368e Compare November 19, 2024 23:08
@sarahchen6 sarahchen6 mentioned this pull request Nov 20, 2024
Closed
5 tasks
@sarahchen6 sarahchen6 changed the title Allow extracting multivalued multiline headers [WIP] Handle multi-value tagging for client spans Nov 20, 2024
@sarahchen6 sarahchen6 mentioned this pull request Nov 21, 2024
Closed
5 tasks
@sarahchen6
Copy link
Contributor Author

moved to #7996

@sarahchen6 sarahchen6 closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sarahchen6