-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valkey instrumentation support #8228
Conversation
...on/valkey-java/src/main/java/datadog/trace/instrumentation/valkey/ValkeyInstrumentation.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution. The PR looks good. The muzzle directive, as commented, should be changed in order to let the CI run without issues. After this change will be done, I'll be able to approuve it for merging
You are welcome; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having improved our codebase. If you did not manage to merge because of internal tests not reported I'll take care on Monday
@amarziali appreciate your help in reviewing the PR. |
Hi @amarziali |
Hi @AhmadMasry yes you are right. Indeed the PR has been shipped with 1.46.0. It was missing from release note because the milestone was missing on this PR and our automation did not include in the RL. They are now updated including this PR too. Thanks for having notified us about that issue and thanks again for your contribution |
What Does This Do
Support instrumentation for Valkey key value store.
Motivation
Valkey is an opensource fork from Redis under the Linux foundation, and cloud providers, like AWS, are providing hosted service for Valkey in AWS Elasticache offering.
Note: Most of the work is based on jedis-4.0 integration with refactoring to use valkey-java instead of jedis, and the embedded-redis library was updated to support newer versions and platforms to test against. Unfortunately, I did not find an embedded valkey provider to test against.