Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure IAST smoke tests wait for the product to be started #8312

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Ensure IAST smoke tests wait for the product to be started #8312

merged 1 commit into from
Jan 30, 2025

Conversation

manuel-alvarez-alvarez
Copy link
Member

What Does This Do

Ensures all IAST related smoke tests wait for the product to be fully initialized before triggering any request.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: enhancement comp: testing Testing tag: no release notes Changes to exclude from release notes comp: asm iast Application Security Management (IAST) labels Jan 30, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner January 30, 2025 15:25
@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-flaky-vertx
git_commit_date 1738237225 1738250556
git_commit_sha a6b67c3 731bf94
release_version 1.46.0-SNAPSHOT~a6b67c32c5 1.46.0-SNAPSHOT~731bf94017
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738253157 1738253157
ci_job_id 787563650 787563650
ci_pipeline_id 54460426 54460426
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tegmsldx-project-304-concurrent-0-6jgokvdh 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tegmsldx-project-304-concurrent-0-6jgokvdh 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~731bf94017, baseline=1.46.0-SNAPSHOT~a6b67c32c5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1034412
Total [baseline] (10.379 s) : 0, 10379246
Agent [candidate] (1.039 s) : 0, 1038894
Total [candidate] (10.486 s) : 0, 10486058
section appsec
Agent [baseline] (1.18 s) : 0, 1179718
Total [baseline] (10.758 s) : 0, 10757800
Agent [candidate] (1.181 s) : 0, 1181406
Total [candidate] (10.745 s) : 0, 10744649
section iast
Agent [baseline] (1.175 s) : 0, 1175288
Total [baseline] (10.982 s) : 0, 10981553
Agent [candidate] (1.166 s) : 0, 1166220
Total [candidate] (10.917 s) : 0, 10917207
section profiling
Agent [baseline] (1.259 s) : 0, 1259238
Total [baseline] (10.795 s) : 0, 10794533
Agent [candidate] (1.259 s) : 0, 1259036
Total [candidate] (10.963 s) : 0, 10962704
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.034 s -
Agent appsec 1.18 s 145.306 ms (14.0%)
Agent iast 1.175 s 140.876 ms (13.6%)
Agent profiling 1.259 s 224.825 ms (21.7%)
Total tracing 10.379 s -
Total appsec 10.758 s 378.554 ms (3.6%)
Total iast 10.982 s 602.307 ms (5.8%)
Total profiling 10.795 s 415.287 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent appsec 1.181 s 142.512 ms (13.7%)
Agent iast 1.166 s 127.326 ms (12.3%)
Agent profiling 1.259 s 220.142 ms (21.2%)
Total tracing 10.486 s -
Total appsec 10.745 s 258.592 ms (2.5%)
Total iast 10.917 s 431.15 ms (4.1%)
Total profiling 10.963 s 476.646 ms (4.5%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~731bf94017, baseline=1.46.0-SNAPSHOT~a6b67c32c5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.032 ms) : 0, 714032
BytebuddyAgent [candidate] (715.183 ms) : 0, 715183
GlobalTracer [baseline] (238.877 ms) : 0, 238877
GlobalTracer [candidate] (239.79 ms) : 0, 239790
AppSec [baseline] (54.946 ms) : 0, 54946
AppSec [candidate] (55.629 ms) : 0, 55629
Remote Config [baseline] (707.876 µs) : 0, 708
Remote Config [candidate] (713.25 µs) : 0, 713
Telemetry [baseline] (10.645 ms) : 0, 10645
Telemetry [candidate] (12.341 ms) : 0, 12341
section appsec
BytebuddyAgent [baseline] (731.557 ms) : 0, 731557
BytebuddyAgent [candidate] (732.629 ms) : 0, 732629
GlobalTracer [baseline] (237.11 ms) : 0, 237110
GlobalTracer [candidate] (237.576 ms) : 0, 237576
AppSec [baseline] (175.634 ms) : 0, 175634
AppSec [candidate] (176.082 ms) : 0, 176082
Remote Config [baseline] (649.494 µs) : 0, 649
Remote Config [candidate] (645.872 µs) : 0, 646
Telemetry [baseline] (8.668 ms) : 0, 8668
Telemetry [candidate] (8.299 ms) : 0, 8299
IAST [baseline] (21.682 ms) : 0, 21682
IAST [candidate] (21.699 ms) : 0, 21699
section iast
BytebuddyAgent [baseline] (838.34 ms) : 0, 838340
BytebuddyAgent [candidate] (832.33 ms) : 0, 832330
GlobalTracer [baseline] (231.989 ms) : 0, 231989
GlobalTracer [candidate] (230.266 ms) : 0, 230266
AppSec [baseline] (55.782 ms) : 0, 55782
AppSec [candidate] (54.353 ms) : 0, 54353
Remote Config [baseline] (624.956 µs) : 0, 625
Remote Config [candidate] (600.267 µs) : 0, 600
Telemetry [baseline] (8.836 ms) : 0, 8836
Telemetry [candidate] (8.655 ms) : 0, 8655
IAST [baseline] (24.313 ms) : 0, 24313
IAST [candidate] (24.706 ms) : 0, 24706
section profiling
ProfilingAgent [baseline] (95.506 ms) : 0, 95506
ProfilingAgent [candidate] (95.177 ms) : 0, 95177
BytebuddyAgent [baseline] (706.033 ms) : 0, 706033
BytebuddyAgent [candidate] (706.294 ms) : 0, 706294
GlobalTracer [baseline] (350.626 ms) : 0, 350626
GlobalTracer [candidate] (351.364 ms) : 0, 351364
AppSec [baseline] (55.231 ms) : 0, 55231
AppSec [candidate] (54.247 ms) : 0, 54247
Remote Config [baseline] (698.854 µs) : 0, 699
Remote Config [candidate] (708.753 µs) : 0, 709
Telemetry [baseline] (8.842 ms) : 0, 8842
Telemetry [candidate] (8.928 ms) : 0, 8928
Profiling [baseline] (95.53 ms) : 0, 95530
Profiling [candidate] (95.202 ms) : 0, 95202
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~731bf94017, baseline=1.46.0-SNAPSHOT~a6b67c32c5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048951
Total [baseline] (8.655 s) : 0, 8654787
Agent [candidate] (1.04 s) : 0, 1039856
Total [candidate] (8.617 s) : 0, 8616562
section iast
Agent [baseline] (1.174 s) : 0, 1173992
Total [baseline] (9.211 s) : 0, 9211457
Agent [candidate] (1.17 s) : 0, 1170458
Total [candidate] (9.252 s) : 0, 9251803
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.168 s) : 0, 1167874
Total [baseline] (9.175 s) : 0, 9175278
Agent [candidate] (1.177 s) : 0, 1177150
Total [candidate] (9.189 s) : 0, 9189178
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1175827
Total [baseline] (9.248 s) : 0, 9248392
Agent [candidate] (1.167 s) : 0, 1167420
Total [candidate] (9.23 s) : 0, 9230178
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.174 s 125.041 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.168 s 118.923 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.176 s 126.876 ms (12.1%)
Total tracing 8.655 s -
Total iast 9.211 s 556.67 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.175 s 520.491 ms (6.0%)
Total iast_TELEMETRY_OFF 9.248 s 593.605 ms (6.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.04 s -
Agent iast 1.17 s 130.602 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 137.294 ms (13.2%)
Agent iast_TELEMETRY_OFF 1.167 s 127.564 ms (12.3%)
Total tracing 8.617 s -
Total iast 9.252 s 635.24 ms (7.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.189 s 572.616 ms (6.6%)
Total iast_TELEMETRY_OFF 9.23 s 613.615 ms (7.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~731bf94017, baseline=1.46.0-SNAPSHOT~a6b67c32c5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.399 ms) : 0, 723399
BytebuddyAgent [candidate] (716.806 ms) : 0, 716806
GlobalTracer [baseline] (242.073 ms) : 0, 242073
GlobalTracer [candidate] (240.628 ms) : 0, 240628
AppSec [baseline] (55.741 ms) : 0, 55741
AppSec [candidate] (56.305 ms) : 0, 56305
Remote Config [baseline] (739.08 µs) : 0, 739
Remote Config [candidate] (713.875 µs) : 0, 714
Telemetry [baseline] (11.624 ms) : 0, 11624
Telemetry [candidate] (10.097 ms) : 0, 10097
section iast
BytebuddyAgent [baseline] (838.124 ms) : 0, 838124
BytebuddyAgent [candidate] (835.243 ms) : 0, 835243
GlobalTracer [baseline] (231.523 ms) : 0, 231523
GlobalTracer [candidate] (231.082 ms) : 0, 231082
AppSec [baseline] (52.434 ms) : 0, 52434
AppSec [candidate] (52.931 ms) : 0, 52931
Remote Config [baseline] (611.61 µs) : 0, 612
Remote Config [candidate] (605.145 µs) : 0, 605
Telemetry [baseline] (8.749 ms) : 0, 8749
Telemetry [candidate] (8.775 ms) : 0, 8775
IAST [baseline] (26.472 ms) : 0, 26472
IAST [candidate] (26.438 ms) : 0, 26438
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (833.186 ms) : 0, 833186
BytebuddyAgent [candidate] (840.324 ms) : 0, 840324
GlobalTracer [baseline] (230.276 ms) : 0, 230276
GlobalTracer [candidate] (232.115 ms) : 0, 232115
AppSec [baseline] (53.863 ms) : 0, 53863
AppSec [candidate] (53.809 ms) : 0, 53809
Remote Config [baseline] (606.286 µs) : 0, 606
Remote Config [candidate] (619.642 µs) : 0, 620
Telemetry [baseline] (8.798 ms) : 0, 8798
Telemetry [candidate] (8.779 ms) : 0, 8779
IAST [baseline] (25.854 ms) : 0, 25854
IAST [candidate] (25.913 ms) : 0, 25913
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.68 ms) : 0, 838680
BytebuddyAgent [candidate] (832.522 ms) : 0, 832522
GlobalTracer [baseline] (232.762 ms) : 0, 232762
GlobalTracer [candidate] (231.138 ms) : 0, 231138
AppSec [baseline] (51.967 ms) : 0, 51967
AppSec [candidate] (53.119 ms) : 0, 53119
Remote Config [baseline] (615.851 µs) : 0, 616
Remote Config [candidate] (617.883 µs) : 0, 618
Telemetry [baseline] (8.66 ms) : 0, 8660
Telemetry [candidate] (8.652 ms) : 0, 8652
IAST [baseline] (27.804 ms) : 0, 27804
IAST [candidate] (26.088 ms) : 0, 26088
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-30T15:35:55 2025-01-30T15:42:57
git_branch master malvarez/iast-flaky-vertx
git_commit_date 1738237225 1738250556
git_commit_sha a6b67c3 731bf94
release_version 1.46.0-SNAPSHOT~a6b67c32c5 1.46.0-SNAPSHOT~731bf94017
start_time 2025-01-30T15:35:41 2025-01-30T15:42:43
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738252134 1738252134
ci_job_id 787563653 787563653
ci_pipeline_id 54460426 54460426
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tegmsldx-project-304-concurrent-1-82z5tcvq 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tegmsldx-project-304-concurrent-1-82z5tcvq 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~731bf94017, baseline=1.46.0-SNAPSHOT~a6b67c32c5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.374 ms) : 1355, 1393
.   : milestone, 1374,
appsec (1.752 ms) : 1729, 1775
.   : milestone, 1752,
appsec_no_iast (1.753 ms) : 1730, 1777
.   : milestone, 1753,
iast (1.5 ms) : 1476, 1525
.   : milestone, 1500,
profiling (1.493 ms) : 1469, 1517
.   : milestone, 1493,
tracing (1.501 ms) : 1477, 1526
.   : milestone, 1501,
section candidate
no_agent (1.348 ms) : 1328, 1367
.   : milestone, 1348,
appsec (1.735 ms) : 1712, 1759
.   : milestone, 1735,
appsec_no_iast (1.746 ms) : 1724, 1769
.   : milestone, 1746,
iast (1.501 ms) : 1476, 1526
.   : milestone, 1501,
profiling (1.542 ms) : 1516, 1567
.   : milestone, 1542,
tracing (1.486 ms) : 1461, 1511
.   : milestone, 1486,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.374 ms [1.355 ms, 1.393 ms] -
appsec 1.752 ms [1.729 ms, 1.775 ms] 378.022 µs (27.5%)
appsec_no_iast 1.753 ms [1.73 ms, 1.777 ms] 379.438 µs (27.6%)
iast 1.5 ms [1.476 ms, 1.525 ms] 126.262 µs (9.2%)
profiling 1.493 ms [1.469 ms, 1.517 ms] 118.983 µs (8.7%)
tracing 1.501 ms [1.477 ms, 1.526 ms] 127.478 µs (9.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.328 ms, 1.367 ms] -
appsec 1.735 ms [1.712 ms, 1.759 ms] 387.238 µs (28.7%)
appsec_no_iast 1.746 ms [1.724 ms, 1.769 ms] 398.312 µs (29.6%)
iast 1.501 ms [1.476 ms, 1.526 ms] 152.93 µs (11.3%)
profiling 1.542 ms [1.516 ms, 1.567 ms] 193.788 µs (14.4%)
tracing 1.486 ms [1.461 ms, 1.511 ms] 138.185 µs (10.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~731bf94017, baseline=1.46.0-SNAPSHOT~a6b67c32c5
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.816 µs) : 357, 396
.   : milestone, 377,
iast (504.319 µs) : 481, 528
.   : milestone, 504,
iast_FULL (743.782 µs) : 721, 767
.   : milestone, 744,
iast_GLOBAL (548.613 µs) : 527, 570
.   : milestone, 549,
iast_HARDCODED_SECRET_DISABLED (510.886 µs) : 488, 534
.   : milestone, 511,
iast_INACTIVE (453.478 µs) : 432, 475
.   : milestone, 453,
iast_TELEMETRY_OFF (494.568 µs) : 471, 518
.   : milestone, 495,
tracing (449.186 µs) : 428, 470
.   : milestone, 449,
section candidate
no_agent (377.455 µs) : 356, 399
.   : milestone, 377,
iast (503.834 µs) : 481, 527
.   : milestone, 504,
iast_FULL (739.62 µs) : 717, 762
.   : milestone, 740,
iast_GLOBAL (556.58 µs) : 534, 579
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (505.261 µs) : 482, 528
.   : milestone, 505,
iast_INACTIVE (457.25 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (491.172 µs) : 468, 514
.   : milestone, 491,
tracing (448.221 µs) : 428, 469
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.816 µs [357.298 µs, 396.334 µs] -
iast 504.319 µs [480.806 µs, 527.832 µs] 127.504 µs (33.8%)
iast_FULL 743.782 µs [720.684 µs, 766.879 µs] 366.966 µs (97.4%)
iast_GLOBAL 548.613 µs [527.007 µs, 570.218 µs] 171.797 µs (45.6%)
iast_HARDCODED_SECRET_DISABLED 510.886 µs [488.014 µs, 533.758 µs] 134.07 µs (35.6%)
iast_INACTIVE 453.478 µs [431.865 µs, 475.09 µs] 76.662 µs (20.3%)
iast_TELEMETRY_OFF 494.568 µs [471.164 µs, 517.972 µs] 117.753 µs (31.2%)
tracing 449.186 µs [428.153 µs, 470.219 µs] 72.37 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.455 µs [356.323 µs, 398.588 µs] -
iast 503.834 µs [480.814 µs, 526.854 µs] 126.378 µs (33.5%)
iast_FULL 739.62 µs [716.76 µs, 762.479 µs] 362.164 µs (95.9%)
iast_GLOBAL 556.58 µs [534.032 µs, 579.128 µs] 179.125 µs (47.5%)
iast_HARDCODED_SECRET_DISABLED 505.261 µs [482.204 µs, 528.319 µs] 127.806 µs (33.9%)
iast_INACTIVE 457.25 µs [436.022 µs, 478.478 µs] 79.795 µs (21.1%)
iast_TELEMETRY_OFF 491.172 µs [468.036 µs, 514.309 µs] 113.717 µs (30.1%)
tracing 448.221 µs [427.573 µs, 468.869 µs] 70.765 µs (18.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-flaky-vertx
git_commit_date 1738237225 1738250556
git_commit_sha a6b67c3 731bf94
release_version 1.46.0-SNAPSHOT~a6b67c32c5 1.46.0-SNAPSHOT~731bf94017
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1738252713 1738252713
ci_job_id 787563655 787563655
ci_pipeline_id 54460426 54460426
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tegmsldx-project-304-concurrent-2-noazdvbs 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tegmsldx-project-304-concurrent-2-noazdvbs 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~731bf94017, baseline=1.46.0-SNAPSHOT~a6b67c32c5
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.033 s) : 15033000, 15033000
.   : milestone, 15033000,
appsec (15.275 s) : 15275000, 15275000
.   : milestone, 15275000,
iast (19.245 s) : 19245000, 19245000
.   : milestone, 19245000,
iast_GLOBAL (18.038 s) : 18038000, 18038000
.   : milestone, 18038000,
profiling (15.644 s) : 15644000, 15644000
.   : milestone, 15644000,
tracing (14.921 s) : 14921000, 14921000
.   : milestone, 14921000,
section candidate
no_agent (14.717 s) : 14717000, 14717000
.   : milestone, 14717000,
appsec (15.114 s) : 15114000, 15114000
.   : milestone, 15114000,
iast (18.365 s) : 18365000, 18365000
.   : milestone, 18365000,
iast_GLOBAL (17.697 s) : 17697000, 17697000
.   : milestone, 17697000,
profiling (15.666 s) : 15666000, 15666000
.   : milestone, 15666000,
tracing (15.133 s) : 15133000, 15133000
.   : milestone, 15133000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.033 s [15.033 s, 15.033 s] -
appsec 15.275 s [15.275 s, 15.275 s] 242.0 ms (1.6%)
iast 19.245 s [19.245 s, 19.245 s] 4.212 s (28.0%)
iast_GLOBAL 18.038 s [18.038 s, 18.038 s] 3.005 s (20.0%)
profiling 15.644 s [15.644 s, 15.644 s] 611.0 ms (4.1%)
tracing 14.921 s [14.921 s, 14.921 s] -112.0 ms (-0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.717 s [14.717 s, 14.717 s] -
appsec 15.114 s [15.114 s, 15.114 s] 397.0 ms (2.7%)
iast 18.365 s [18.365 s, 18.365 s] 3.648 s (24.8%)
iast_GLOBAL 17.697 s [17.697 s, 17.697 s] 2.98 s (20.2%)
profiling 15.666 s [15.666 s, 15.666 s] 949.0 ms (6.4%)
tracing 15.133 s [15.133 s, 15.133 s] 416.0 ms (2.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~731bf94017, baseline=1.46.0-SNAPSHOT~a6b67c32c5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.35 ms) : 2307, 2393
.   : milestone, 2350,
iast (2.116 ms) : 2061, 2170
.   : milestone, 2116,
iast_GLOBAL (2.15 ms) : 2095, 2205
.   : milestone, 2150,
profiling (1.975 ms) : 1930, 2019
.   : milestone, 1975,
tracing (1.948 ms) : 1906, 1991
.   : milestone, 1948,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.356 ms) : 2313, 2399
.   : milestone, 2356,
iast (2.106 ms) : 2052, 2161
.   : milestone, 2106,
iast_GLOBAL (2.147 ms) : 2092, 2202
.   : milestone, 2147,
profiling (2.011 ms) : 1964, 2057
.   : milestone, 2011,
tracing (1.932 ms) : 1890, 1974
.   : milestone, 1932,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.35 ms [2.307 ms, 2.393 ms] 880.806 µs (60.0%)
iast 2.116 ms [2.061 ms, 2.17 ms] 646.527 µs (44.0%)
iast_GLOBAL 2.15 ms [2.095 ms, 2.205 ms] 680.675 µs (46.3%)
profiling 1.975 ms [1.93 ms, 2.019 ms] 505.587 µs (34.4%)
tracing 1.948 ms [1.906 ms, 1.991 ms] 479.114 µs (32.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 2.356 ms [2.313 ms, 2.399 ms] 884.101 µs (60.1%)
iast 2.106 ms [2.052 ms, 2.161 ms] 635.057 µs (43.2%)
iast_GLOBAL 2.147 ms [2.092 ms, 2.202 ms] 675.374 µs (45.9%)
profiling 2.011 ms [1.964 ms, 2.057 ms] 539.497 µs (36.7%)
tracing 1.932 ms [1.89 ms, 1.974 ms] 460.666 µs (31.3%)

PerfectSlayer
PerfectSlayer approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Jan 30, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit e455ca7 into master Jan 30, 2025
201 of 202 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-flaky-vertx branch January 30, 2025 17:33
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) comp: testing Testing tag: no release notes Changes to exclude from release notes type: enhancement
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manuel-alvarez-alvarez @PerfectSlayer