Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of BaggagePropagator and BaggageContext #8330

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Implementation of BaggagePropagator and BaggageContext #8330

wants to merge 16 commits into from

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Feb 3, 2025 •
edited
Loading

What Does This Do

Implement Baggage support and decoupling Baggage propagation from tracecontext propagation by using the Context API. Introduces two new Configs: TRACE_BAGGAGE_MAX_ITEMS and TRACE_BAGGAGE_MAX_BYTES, baggage specific encoding and decoding, and unit testing for functionality of both injection and extraction.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mhlidd mhlidd added the tag: do not merge Do not merge changes label Feb 3, 2025
@mhlidd mhlidd changed the title initial implementation and unit tests for inject/extract [WIP] initial implementation and unit tests for inject/extract Feb 3, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/otel_baggage_extract/inject
git_commit_date 1739311245 1739313407
git_commit_sha 3e097b6 6977fa9
release_version 1.47.0-SNAPSHOT~3e097b61ef 1.47.0-SNAPSHOT~6977fa9893
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739315874 1739315874
ci_job_id 804111234 804111234
ci_pipeline_id 55607727 55607727
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-3yifkw8s-project-304-concurrent-0-h4uuoivy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-3yifkw8s-project-304-concurrent-0-h4uuoivy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~6977fa9893, baseline=1.47.0-SNAPSHOT~3e097b61ef

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1040117
Total [baseline] (10.439 s) : 0, 10439322
Agent [candidate] (1.045 s) : 0, 1044869
Total [candidate] (10.419 s) : 0, 10418658
section appsec
Agent [baseline] (1.19 s) : 0, 1189872
Total [baseline] (10.774 s) : 0, 10774393
Agent [candidate] (1.187 s) : 0, 1186688
Total [candidate] (10.767 s) : 0, 10767479
section iast
Agent [baseline] (1.172 s) : 0, 1171511
Total [baseline] (11.107 s) : 0, 11106673
Agent [candidate] (1.174 s) : 0, 1173533
Total [candidate] (10.996 s) : 0, 10995790
section profiling
Agent [baseline] (1.265 s) : 0, 1265240
Total [baseline] (10.857 s) : 0, 10857222
Agent [candidate] (1.263 s) : 0, 1262927
Total [candidate] (10.902 s) : 0, 10902017
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.04 s -
Agent appsec 1.19 s 149.755 ms (14.4%)
Agent iast 1.172 s 131.394 ms (12.6%)
Agent profiling 1.265 s 225.123 ms (21.6%)
Total tracing 10.439 s -
Total appsec 10.774 s 335.071 ms (3.2%)
Total iast 11.107 s 667.35 ms (6.4%)
Total profiling 10.857 s 417.9 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.187 s 141.819 ms (13.6%)
Agent iast 1.174 s 128.664 ms (12.3%)
Agent profiling 1.263 s 218.058 ms (20.9%)
Total tracing 10.419 s -
Total appsec 10.767 s 348.821 ms (3.3%)
Total iast 10.996 s 577.132 ms (5.5%)
Total profiling 10.902 s 483.359 ms (4.6%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~6977fa9893, baseline=1.47.0-SNAPSHOT~3e097b61ef

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.518 ms) : 0, 714518
BytebuddyAgent [candidate] (716.066 ms) : 0, 716066
GlobalTracer [baseline] (242.675 ms) : 0, 242675
GlobalTracer [candidate] (243.727 ms) : 0, 243727
AppSec [baseline] (54.876 ms) : 0, 54876
AppSec [candidate] (54.911 ms) : 0, 54911
Remote Config [baseline] (727.357 µs) : 0, 727
Remote Config [candidate] (717.784 µs) : 0, 718
Telemetry [baseline] (12.136 ms) : 0, 12136
Telemetry [candidate] (14.292 ms) : 0, 14292
section appsec
BytebuddyAgent [baseline] (736.501 ms) : 0, 736501
BytebuddyAgent [candidate] (734.933 ms) : 0, 734933
GlobalTracer [baseline] (241.819 ms) : 0, 241819
GlobalTracer [candidate] (240.51 ms) : 0, 240510
IAST [baseline] (21.932 ms) : 0, 21932
IAST [candidate] (21.801 ms) : 0, 21801
AppSec [baseline] (176.326 ms) : 0, 176326
AppSec [candidate] (176.216 ms) : 0, 176216
Remote Config [baseline] (676.269 µs) : 0, 676
Remote Config [candidate] (653.359 µs) : 0, 653
Telemetry [baseline] (8.297 ms) : 0, 8297
Telemetry [candidate] (8.224 ms) : 0, 8224
section iast
BytebuddyAgent [baseline] (833.921 ms) : 0, 833921
BytebuddyAgent [candidate] (834.906 ms) : 0, 834906
GlobalTracer [baseline] (233.499 ms) : 0, 233499
GlobalTracer [candidate] (234.269 ms) : 0, 234269
IAST [baseline] (22.955 ms) : 0, 22955
IAST [candidate] (22.876 ms) : 0, 22876
AppSec [baseline] (56.753 ms) : 0, 56753
AppSec [candidate] (57.033 ms) : 0, 57033
Remote Config [baseline] (641.572 µs) : 0, 642
Remote Config [candidate] (620.599 µs) : 0, 621
Telemetry [baseline] (8.657 ms) : 0, 8657
Telemetry [candidate] (8.652 ms) : 0, 8652
section profiling
BytebuddyAgent [baseline] (707.414 ms) : 0, 707414
BytebuddyAgent [candidate] (706.196 ms) : 0, 706196
GlobalTracer [baseline] (353.523 ms) : 0, 353523
GlobalTracer [candidate] (354.285 ms) : 0, 354285
AppSec [baseline] (55.704 ms) : 0, 55704
AppSec [candidate] (54.512 ms) : 0, 54512
Remote Config [baseline] (709.203 µs) : 0, 709
Remote Config [candidate] (707.87 µs) : 0, 708
Telemetry [baseline] (9.039 ms) : 0, 9039
Telemetry [candidate] (9.23 ms) : 0, 9230
ProfilingAgent [baseline] (96.689 ms) : 0, 96689
ProfilingAgent [candidate] (95.723 ms) : 0, 95723
Profiling [baseline] (96.713 ms) : 0, 96713
Profiling [candidate] (95.747 ms) : 0, 95747
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~6977fa9893, baseline=1.47.0-SNAPSHOT~3e097b61ef

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043407
Total [baseline] (8.648 s) : 0, 8648027
Agent [candidate] (1.052 s) : 0, 1052073
Total [candidate] (8.691 s) : 0, 8690554
section iast
Agent [baseline] (1.18 s) : 0, 1180435
Total [baseline] (9.211 s) : 0, 9210847
Agent [candidate] (1.175 s) : 0, 1174888
Total [candidate] (9.226 s) : 0, 9226040
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1186288
Total [baseline] (9.206 s) : 0, 9206217
Agent [candidate] (1.184 s) : 0, 1183969
Total [candidate] (9.178 s) : 0, 9178003
section iast_TELEMETRY_OFF
Agent [baseline] (1.172 s) : 0, 1172288
Total [baseline] (9.262 s) : 0, 9261725
Agent [candidate] (1.178 s) : 0, 1177686
Total [candidate] (9.217 s) : 0, 9217265
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent iast 1.18 s 137.028 ms (13.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.186 s 142.881 ms (13.7%)
Agent iast_TELEMETRY_OFF 1.172 s 128.881 ms (12.4%)
Total tracing 8.648 s -
Total iast 9.211 s 562.82 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.206 s 558.19 ms (6.5%)
Total iast_TELEMETRY_OFF 9.262 s 613.698 ms (7.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.175 s 122.815 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 131.896 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.178 s 125.612 ms (11.9%)
Total tracing 8.691 s -
Total iast 9.226 s 535.486 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.178 s 487.449 ms (5.6%)
Total iast_TELEMETRY_OFF 9.217 s 526.711 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~6977fa9893, baseline=1.47.0-SNAPSHOT~3e097b61ef

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.962 ms) : 0, 717962
BytebuddyAgent [candidate] (721.809 ms) : 0, 721809
GlobalTracer [baseline] (243.095 ms) : 0, 243095
GlobalTracer [candidate] (245.43 ms) : 0, 245430
AppSec [baseline] (55.047 ms) : 0, 55047
AppSec [candidate] (55.223 ms) : 0, 55223
Remote Config [baseline] (721.271 µs) : 0, 721
Remote Config [candidate] (724.899 µs) : 0, 725
Telemetry [baseline] (11.396 ms) : 0, 11396
Telemetry [candidate] (13.671 ms) : 0, 13671
section iast
BytebuddyAgent [baseline] (840.505 ms) : 0, 840505
BytebuddyAgent [candidate] (835.721 ms) : 0, 835721
GlobalTracer [baseline] (234.63 ms) : 0, 234630
GlobalTracer [candidate] (234.384 ms) : 0, 234384
IAST [baseline] (23.002 ms) : 0, 23002
IAST [candidate] (22.914 ms) : 0, 22914
AppSec [baseline] (57.552 ms) : 0, 57552
AppSec [candidate] (57.254 ms) : 0, 57254
Remote Config [baseline] (628.331 µs) : 0, 628
Remote Config [candidate] (614.633 µs) : 0, 615
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.725 ms) : 0, 8725
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (847.07 ms) : 0, 847070
BytebuddyAgent [candidate] (842.507 ms) : 0, 842507
GlobalTracer [baseline] (234.769 ms) : 0, 234769
GlobalTracer [candidate] (236.125 ms) : 0, 236125
IAST [baseline] (23.011 ms) : 0, 23011
IAST [candidate] (23.305 ms) : 0, 23305
AppSec [baseline] (56.704 ms) : 0, 56704
AppSec [candidate] (57.355 ms) : 0, 57355
Remote Config [baseline] (607.957 µs) : 0, 608
Remote Config [candidate] (628.986 µs) : 0, 629
Telemetry [baseline] (8.628 ms) : 0, 8628
Telemetry [candidate] (8.714 ms) : 0, 8714
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.667 ms) : 0, 832667
BytebuddyAgent [candidate] (838.024 ms) : 0, 838024
GlobalTracer [baseline] (235.116 ms) : 0, 235116
GlobalTracer [candidate] (236.021 ms) : 0, 236021
IAST [baseline] (25.008 ms) : 0, 25008
IAST [candidate] (27.02 ms) : 0, 27020
AppSec [baseline] (55.063 ms) : 0, 55063
AppSec [candidate] (52.045 ms) : 0, 52045
Remote Config [baseline] (617.749 µs) : 0, 618
Remote Config [candidate] (609.679 µs) : 0, 610
Telemetry [baseline] (8.632 ms) : 0, 8632
Telemetry [candidate] (8.603 ms) : 0, 8603
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-11T22:47:50 2025-02-11T22:54:57
git_branch master mhlidd/otel_baggage_extract/inject
git_commit_date 1739311245 1739313407
git_commit_sha 3e097b6 6977fa9
release_version 1.47.0-SNAPSHOT~3e097b61ef 1.47.0-SNAPSHOT~6977fa9893
start_time 2025-02-11T22:47:36 2025-02-11T22:54:43
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739314858 1739314858
ci_job_id 804111235 804111235
ci_pipeline_id 55607727 55607727
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-3yifkw8s-project-304-concurrent-1-byruab1r 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-3yifkw8s-project-304-concurrent-1-byruab1r 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6977fa9893, baseline=1.47.0-SNAPSHOT~3e097b61ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (384.935 µs) : 365, 405
.   : milestone, 385,
iast (514.288 µs) : 492, 536
.   : milestone, 514,
iast_FULL (753.792 µs) : 732, 776
.   : milestone, 754,
iast_GLOBAL (571.599 µs) : 548, 595
.   : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (510.918 µs) : 489, 532
.   : milestone, 511,
iast_INACTIVE (464.365 µs) : 443, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (505.412 µs) : 483, 528
.   : milestone, 505,
tracing (461.675 µs) : 439, 484
.   : milestone, 462,
section candidate
no_agent (390.553 µs) : 370, 411
.   : milestone, 391,
iast (515.989 µs) : 494, 538
.   : milestone, 516,
iast_FULL (750.258 µs) : 728, 772
.   : milestone, 750,
iast_GLOBAL (565.577 µs) : 543, 588
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (516.308 µs) : 494, 538
.   : milestone, 516,
iast_INACTIVE (464.385 µs) : 443, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (510.019 µs) : 487, 533
.   : milestone, 510,
tracing (466.587 µs) : 446, 487
.   : milestone, 467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.935 µs [365.005 µs, 404.864 µs] -
iast 514.288 µs [492.399 µs, 536.177 µs] 129.353 µs (33.6%)
iast_FULL 753.792 µs [731.839 µs, 775.745 µs] 368.858 µs (95.8%)
iast_GLOBAL 571.599 µs [547.895 µs, 595.304 µs] 186.665 µs (48.5%)
iast_HARDCODED_SECRET_DISABLED 510.918 µs [489.398 µs, 532.437 µs] 125.983 µs (32.7%)
iast_INACTIVE 464.365 µs [443.22 µs, 485.511 µs] 79.431 µs (20.6%)
iast_TELEMETRY_OFF 505.412 µs [482.799 µs, 528.025 µs] 120.478 µs (31.3%)
tracing 461.675 µs [439.391 µs, 483.958 µs] 76.74 µs (19.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 390.553 µs [370.489 µs, 410.617 µs] -
iast 515.989 µs [494.153 µs, 537.826 µs] 125.436 µs (32.1%)
iast_FULL 750.258 µs [728.343 µs, 772.173 µs] 359.705 µs (92.1%)
iast_GLOBAL 565.577 µs [543.364 µs, 587.791 µs] 175.024 µs (44.8%)
iast_HARDCODED_SECRET_DISABLED 516.308 µs [494.465 µs, 538.15 µs] 125.755 µs (32.2%)
iast_INACTIVE 464.385 µs [443.197 µs, 485.574 µs] 73.832 µs (18.9%)
iast_TELEMETRY_OFF 510.019 µs [486.691 µs, 533.348 µs] 119.466 µs (30.6%)
tracing 466.587 µs [445.785 µs, 487.389 µs] 76.034 µs (19.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6977fa9893, baseline=1.47.0-SNAPSHOT~3e097b61ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1340, 1378
.   : milestone, 1359,
appsec (1.752 ms) : 1728, 1776
.   : milestone, 1752,
appsec_no_iast (1.761 ms) : 1736, 1786
.   : milestone, 1761,
iast (1.532 ms) : 1509, 1556
.   : milestone, 1532,
profiling (1.513 ms) : 1489, 1536
.   : milestone, 1513,
tracing (1.508 ms) : 1484, 1533
.   : milestone, 1508,
section candidate
no_agent (1.362 ms) : 1342, 1382
.   : milestone, 1362,
appsec (1.749 ms) : 1724, 1773
.   : milestone, 1749,
appsec_no_iast (1.743 ms) : 1718, 1768
.   : milestone, 1743,
iast (1.5 ms) : 1475, 1525
.   : milestone, 1500,
profiling (1.558 ms) : 1535, 1582
.   : milestone, 1558,
tracing (1.478 ms) : 1453, 1503
.   : milestone, 1478,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.34 ms, 1.378 ms] -
appsec 1.752 ms [1.728 ms, 1.776 ms] 392.938 µs (28.9%)
appsec_no_iast 1.761 ms [1.736 ms, 1.786 ms] 402.523 µs (29.6%)
iast 1.532 ms [1.509 ms, 1.556 ms] 173.362 µs (12.8%)
profiling 1.513 ms [1.489 ms, 1.536 ms] 153.746 µs (11.3%)
tracing 1.508 ms [1.484 ms, 1.533 ms] 149.304 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.342 ms, 1.382 ms] -
appsec 1.749 ms [1.724 ms, 1.773 ms] 386.643 µs (28.4%)
appsec_no_iast 1.743 ms [1.718 ms, 1.768 ms] 381.171 µs (28.0%)
iast 1.5 ms [1.475 ms, 1.525 ms] 138.195 µs (10.1%)
profiling 1.558 ms [1.535 ms, 1.582 ms] 196.481 µs (14.4%)
tracing 1.478 ms [1.453 ms, 1.503 ms] 115.797 µs (8.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/otel_baggage_extract/inject
git_commit_date 1739311245 1739313407
git_commit_sha 3e097b6 6977fa9
release_version 1.47.0-SNAPSHOT~3e097b61ef 1.47.0-SNAPSHOT~6977fa9893
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1739315450 1739315450
ci_job_id 804111236 804111236
ci_pipeline_id 55607727 55607727
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-3yifkw8s-project-304-concurrent-2-rwq4i8pt 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-3yifkw8s-project-304-concurrent-2-rwq4i8pt 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6977fa9893, baseline=1.47.0-SNAPSHOT~3e097b61ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.877 s) : 14877000, 14877000
.   : milestone, 14877000,
appsec (14.96 s) : 14960000, 14960000
.   : milestone, 14960000,
iast (18.771 s) : 18771000, 18771000
.   : milestone, 18771000,
iast_GLOBAL (18.065 s) : 18065000, 18065000
.   : milestone, 18065000,
profiling (15.02 s) : 15020000, 15020000
.   : milestone, 15020000,
tracing (14.98 s) : 14980000, 14980000
.   : milestone, 14980000,
section candidate
no_agent (14.881 s) : 14881000, 14881000
.   : milestone, 14881000,
appsec (14.959 s) : 14959000, 14959000
.   : milestone, 14959000,
iast (18.582 s) : 18582000, 18582000
.   : milestone, 18582000,
iast_GLOBAL (18.002 s) : 18002000, 18002000
.   : milestone, 18002000,
profiling (14.986 s) : 14986000, 14986000
.   : milestone, 14986000,
tracing (14.802 s) : 14802000, 14802000
.   : milestone, 14802000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.877 s [14.877 s, 14.877 s] -
appsec 14.96 s [14.96 s, 14.96 s] 83.0 ms (0.6%)
iast 18.771 s [18.771 s, 18.771 s] 3.894 s (26.2%)
iast_GLOBAL 18.065 s [18.065 s, 18.065 s] 3.188 s (21.4%)
profiling 15.02 s [15.02 s, 15.02 s] 143.0 ms (1.0%)
tracing 14.98 s [14.98 s, 14.98 s] 103.0 ms (0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.881 s [14.881 s, 14.881 s] -
appsec 14.959 s [14.959 s, 14.959 s] 78.0 ms (0.5%)
iast 18.582 s [18.582 s, 18.582 s] 3.701 s (24.9%)
iast_GLOBAL 18.002 s [18.002 s, 18.002 s] 3.121 s (21.0%)
profiling 14.986 s [14.986 s, 14.986 s] 105.0 ms (0.7%)
tracing 14.802 s [14.802 s, 14.802 s] -79.0 ms (-0.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6977fa9893, baseline=1.47.0-SNAPSHOT~3e097b61ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.369 ms) : 2326, 2412
.   : milestone, 2369,
iast (2.117 ms) : 2062, 2172
.   : milestone, 2117,
iast_GLOBAL (2.165 ms) : 2110, 2221
.   : milestone, 2165,
profiling (1.967 ms) : 1923, 2011
.   : milestone, 1967,
tracing (1.948 ms) : 1906, 1990
.   : milestone, 1948,
section candidate
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.365 ms) : 2322, 2408
.   : milestone, 2365,
iast (2.112 ms) : 2057, 2167
.   : milestone, 2112,
iast_GLOBAL (2.165 ms) : 2110, 2220
.   : milestone, 2165,
profiling (1.972 ms) : 1928, 2016
.   : milestone, 1972,
tracing (1.945 ms) : 1903, 1987
.   : milestone, 1945,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.464 ms, 1.487 ms] -
appsec 2.369 ms [2.326 ms, 2.412 ms] 893.272 µs (60.5%)
iast 2.117 ms [2.062 ms, 2.172 ms] 641.128 µs (43.4%)
iast_GLOBAL 2.165 ms [2.11 ms, 2.221 ms] 689.478 µs (46.7%)
profiling 1.967 ms [1.923 ms, 2.011 ms] 491.236 µs (33.3%)
tracing 1.948 ms [1.906 ms, 1.99 ms] 471.874 µs (32.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.365 ms [2.322 ms, 2.408 ms] 891.989 µs (60.5%)
iast 2.112 ms [2.057 ms, 2.167 ms] 639.116 µs (43.4%)
iast_GLOBAL 2.165 ms [2.11 ms, 2.22 ms] 691.892 µs (47.0%)
profiling 1.972 ms [1.928 ms, 2.016 ms] 499.062 µs (33.9%)
tracing 1.945 ms [1.903 ms, 1.987 ms] 471.705 µs (32.0%)

@lucaspimentel lucaspimentel mentioned this pull request Feb 7, 2025
Closed
@mhlidd mhlidd force-pushed the mhlidd/otel_baggage_extract/inject branch from c9b2cc5 to bdb7932 Compare February 9, 2025 03:10
@mhlidd mhlidd added comp: core Tracer core and removed tag: do not merge Do not merge changes labels Feb 11, 2025
@mhlidd mhlidd changed the title [WIP] initial implementation and unit tests for inject/extract Implementation of BaggagePropagator and BaggageContext Feb 11, 2025
@mhlidd mhlidd marked this pull request as ready for review February 11, 2025 23:36
@mhlidd mhlidd requested a review from a team as a code owner February 11, 2025 23:36
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mhlidd mhlidd requested a review from mcculls February 11, 2025 23:36
@mhlidd mhlidd requested review from PerfectSlayer and removed request for manuel-alvarez-alvarez February 11, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls Awaiting requested review from mcculls

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
comp: core Tracer core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhlidd @PerfectSlayer