-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add draft inferred proxy spans as http request parent #8336
Draft
jordan-wong
wants to merge
2
commits into
master
Choose a base branch
from
inferred-span-tags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 3 performance improvements and 8 performance regressions! Performance is the same for 42 metrics, 10 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~d0aa92ba14, baseline=1.47.0-SNAPSHOT~312af335ab
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049129
Total [baseline] (10.618 s) : 0, 10618182
Agent [candidate] (1.055 s) : 0, 1055370
Total [candidate] (10.462 s) : 0, 10462363
section appsec
Agent [baseline] (1.185 s) : 0, 1184903
Total [baseline] (10.78 s) : 0, 10780298
Agent [candidate] (1.198 s) : 0, 1198105
Total [candidate] (10.817 s) : 0, 10816587
section iast
Agent [baseline] (1.177 s) : 0, 1177132
Total [baseline] (11.025 s) : 0, 11025210
Agent [candidate] (1.184 s) : 0, 1184355
Total [candidate] (11.03 s) : 0, 11030295
section profiling
Agent [baseline] (1.264 s) : 0, 1263654
Total [baseline] (10.878 s) : 0, 10877737
Agent [candidate] (1.256 s) : 0, 1256282
Total [candidate] (10.902 s) : 0, 10902455
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~d0aa92ba14, baseline=1.47.0-SNAPSHOT~312af335ab
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.451 ms) : 0, 718451
BytebuddyAgent [candidate] (713.176 ms) : 0, 713176
GlobalTracer [baseline] (244.567 ms) : 0, 244567
GlobalTracer [candidate] (255.27 ms) : 0, 255270
AppSec [baseline] (55.64 ms) : 0, 55640
AppSec [candidate] (55.483 ms) : 0, 55483
Remote Config [baseline] (730.383 µs) : 0, 730
Remote Config [candidate] (741.623 µs) : 0, 742
Telemetry [baseline] (14.529 ms) : 0, 14529
Telemetry [candidate] (15.674 ms) : 0, 15674
section appsec
BytebuddyAgent [baseline] (732.434 ms) : 0, 732434
BytebuddyAgent [candidate] (737.214 ms) : 0, 737214
GlobalTracer [baseline] (240.768 ms) : 0, 240768
GlobalTracer [candidate] (254.977 ms) : 0, 254977
AppSec [baseline] (176.761 ms) : 0, 176761
AppSec [candidate] (171.815 ms) : 0, 171815
Remote Config [baseline] (655.07 µs) : 0, 655
Remote Config [candidate] (665.447 µs) : 0, 665
Telemetry [baseline] (8.274 ms) : 0, 8274
Telemetry [candidate] (8.596 ms) : 0, 8596
IAST [baseline] (21.586 ms) : 0, 21586
IAST [candidate] (19.453 ms) : 0, 19453
section iast
BytebuddyAgent [baseline] (838.288 ms) : 0, 838288
BytebuddyAgent [candidate] (833.505 ms) : 0, 833505
GlobalTracer [baseline] (234.694 ms) : 0, 234694
GlobalTracer [candidate] (246.721 ms) : 0, 246721
AppSec [baseline] (53.81 ms) : 0, 53810
AppSec [candidate] (58.192 ms) : 0, 58192
Remote Config [baseline] (613.795 µs) : 0, 614
Remote Config [candidate] (654.189 µs) : 0, 654
Telemetry [baseline] (8.719 ms) : 0, 8719
Telemetry [candidate] (8.748 ms) : 0, 8748
IAST [baseline] (25.65 ms) : 0, 25650
IAST [candidate] (21.46 ms) : 0, 21460
section profiling
ProfilingAgent [baseline] (95.715 ms) : 0, 95715
ProfilingAgent [candidate] (95.445 ms) : 0, 95445
BytebuddyAgent [baseline] (707.043 ms) : 0, 707043
BytebuddyAgent [candidate] (704.569 ms) : 0, 704569
GlobalTracer [baseline] (353.638 ms) : 0, 353638
GlobalTracer [candidate] (350.182 ms) : 0, 350182
AppSec [baseline] (55.29 ms) : 0, 55290
AppSec [candidate] (54.43 ms) : 0, 54430
Remote Config [baseline] (694.907 µs) : 0, 695
Remote Config [candidate] (725.837 µs) : 0, 726
Telemetry [baseline] (8.995 ms) : 0, 8995
Telemetry [candidate] (8.906 ms) : 0, 8906
Profiling [baseline] (95.739 ms) : 0, 95739
Profiling [candidate] (95.469 ms) : 0, 95469
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~d0aa92ba14, baseline=1.47.0-SNAPSHOT~312af335ab
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043752
Total [baseline] (8.676 s) : 0, 8676048
Agent [candidate] (1.059 s) : 0, 1059319
Total [candidate] (8.677 s) : 0, 8677167
section iast
Agent [baseline] (1.18 s) : 0, 1180281
Total [baseline] (9.257 s) : 0, 9256766
Agent [candidate] (1.194 s) : 0, 1193831
Total [candidate] (9.25 s) : 0, 9249726
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1179120
Total [baseline] (9.26 s) : 0, 9259981
Agent [candidate] (1.191 s) : 0, 1191097
Total [candidate] (9.237 s) : 0, 9237476
section iast_TELEMETRY_OFF
Agent [baseline] (1.182 s) : 0, 1182302
Total [baseline] (9.265 s) : 0, 9265477
Agent [candidate] (1.184 s) : 0, 1184456
Total [candidate] (9.286 s) : 0, 9285990
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~d0aa92ba14, baseline=1.47.0-SNAPSHOT~312af335ab
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.351 ms) : 0, 717351
BytebuddyAgent [candidate] (718.451 ms) : 0, 718451
GlobalTracer [baseline] (243.926 ms) : 0, 243926
GlobalTracer [candidate] (255.785 ms) : 0, 255785
AppSec [baseline] (55.076 ms) : 0, 55076
AppSec [candidate] (57.022 ms) : 0, 57022
Remote Config [baseline] (720.27 µs) : 0, 720
Remote Config [candidate] (751.007 µs) : 0, 751
Telemetry [baseline] (11.528 ms) : 0, 11528
Telemetry [candidate] (12.234 ms) : 0, 12234
section iast
BytebuddyAgent [baseline] (840.198 ms) : 0, 840198
BytebuddyAgent [candidate] (840.522 ms) : 0, 840522
GlobalTracer [baseline] (235.238 ms) : 0, 235238
GlobalTracer [candidate] (248.539 ms) : 0, 248539
AppSec [baseline] (57.231 ms) : 0, 57231
AppSec [candidate] (58.467 ms) : 0, 58467
IAST [baseline] (22.865 ms) : 0, 22865
IAST [candidate] (21.708 ms) : 0, 21708
Remote Config [baseline] (627.322 µs) : 0, 627
Remote Config [candidate] (654.721 µs) : 0, 655
Telemetry [baseline] (8.803 ms) : 0, 8803
Telemetry [candidate] (8.782 ms) : 0, 8782
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.326 ms) : 0, 839326
BytebuddyAgent [candidate] (838.015 ms) : 0, 838015
GlobalTracer [baseline] (235.185 ms) : 0, 235185
GlobalTracer [candidate] (248.17 ms) : 0, 248170
AppSec [baseline] (53.111 ms) : 0, 53111
AppSec [candidate] (58.435 ms) : 0, 58435
IAST [baseline] (26.575 ms) : 0, 26575
IAST [candidate] (21.833 ms) : 0, 21833
Remote Config [baseline] (685.786 µs) : 0, 686
Remote Config [candidate] (683.391 µs) : 0, 683
Telemetry [baseline] (8.765 ms) : 0, 8765
Telemetry [candidate] (8.851 ms) : 0, 8851
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (841.996 ms) : 0, 841996
BytebuddyAgent [candidate] (832.322 ms) : 0, 832322
GlobalTracer [baseline] (236.013 ms) : 0, 236013
GlobalTracer [candidate] (248.2 ms) : 0, 248200
AppSec [baseline] (54.877 ms) : 0, 54877
AppSec [candidate] (58.268 ms) : 0, 58268
IAST [baseline] (24.714 ms) : 0, 24714
IAST [candidate] (21.206 ms) : 0, 21206
Remote Config [baseline] (625.801 µs) : 0, 626
Remote Config [candidate] (659.68 µs) : 0, 660
Telemetry [baseline] (8.706 ms) : 0, 8706
Telemetry [candidate] (8.723 ms) : 0, 8723
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~d0aa92ba14, baseline=1.47.0-SNAPSHOT~312af335ab
dateFormat X
axisFormat %s
section baseline
no_agent (1.359 ms) : 1340, 1378
. : milestone, 1359,
appsec (1.758 ms) : 1735, 1781
. : milestone, 1758,
appsec_no_iast (1.76 ms) : 1736, 1784
. : milestone, 1760,
iast (1.514 ms) : 1489, 1538
. : milestone, 1514,
profiling (1.533 ms) : 1507, 1558
. : milestone, 1533,
tracing (1.461 ms) : 1436, 1486
. : milestone, 1461,
section candidate
no_agent (1.348 ms) : 1328, 1368
. : milestone, 1348,
appsec (1.75 ms) : 1726, 1774
. : milestone, 1750,
appsec_no_iast (1.779 ms) : 1756, 1802
. : milestone, 1779,
iast (1.517 ms) : 1493, 1542
. : milestone, 1517,
profiling (1.576 ms) : 1551, 1600
. : milestone, 1576,
tracing (1.489 ms) : 1464, 1514
. : milestone, 1489,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~d0aa92ba14, baseline=1.47.0-SNAPSHOT~312af335ab
dateFormat X
axisFormat %s
section baseline
no_agent (373.702 µs) : 353, 394
. : milestone, 374,
iast (505.974 µs) : 484, 528
. : milestone, 506,
iast_FULL (741.181 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (551.41 µs) : 530, 573
. : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (511.208 µs) : 489, 533
. : milestone, 511,
iast_INACTIVE (457.717 µs) : 437, 479
. : milestone, 458,
iast_TELEMETRY_OFF (501.313 µs) : 479, 524
. : milestone, 501,
tracing (457.112 µs) : 436, 478
. : milestone, 457,
section candidate
no_agent (384.359 µs) : 364, 405
. : milestone, 384,
iast (495.364 µs) : 474, 517
. : milestone, 495,
iast_FULL (758.348 µs) : 737, 780
. : milestone, 758,
iast_GLOBAL (513.55 µs) : 491, 536
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (498.775 µs) : 477, 521
. : milestone, 499,
iast_INACTIVE (473.39 µs) : 452, 495
. : milestone, 473,
iast_TELEMETRY_OFF (488.559 µs) : 466, 511
. : milestone, 489,
tracing (470.815 µs) : 449, 492
. : milestone, 471,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 7 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~d0aa92ba14, baseline=1.47.0-SNAPSHOT~312af335ab
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.352 ms) : 2309, 2396
. : milestone, 2352,
iast (2.094 ms) : 2039, 2149
. : milestone, 2094,
iast_GLOBAL (2.146 ms) : 2090, 2201
. : milestone, 2146,
profiling (1.966 ms) : 1922, 2010
. : milestone, 1966,
tracing (1.951 ms) : 1909, 1994
. : milestone, 1951,
section candidate
no_agent (1.465 ms) : 1454, 1477
. : milestone, 1465,
appsec (2.583 ms) : 2539, 2627
. : milestone, 2583,
iast (2.654 ms) : 2598, 2710
. : milestone, 2654,
iast_GLOBAL (2.652 ms) : 2595, 2708
. : milestone, 2652,
profiling (2.632 ms) : 2586, 2678
. : milestone, 2632,
tracing (2.5 ms) : 2457, 2544
. : milestone, 2500,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~d0aa92ba14, baseline=1.47.0-SNAPSHOT~312af335ab
dateFormat X
axisFormat %s
section baseline
no_agent (15.232 s) : 15232000, 15232000
. : milestone, 15232000,
appsec (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
iast (18.865 s) : 18865000, 18865000
. : milestone, 18865000,
iast_GLOBAL (18.049 s) : 18049000, 18049000
. : milestone, 18049000,
profiling (15.206 s) : 15206000, 15206000
. : milestone, 15206000,
tracing (15.084 s) : 15084000, 15084000
. : milestone, 15084000,
section candidate
no_agent (15.212 s) : 15212000, 15212000
. : milestone, 15212000,
appsec (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
iast (18.467 s) : 18467000, 18467000
. : milestone, 18467000,
iast_GLOBAL (17.727 s) : 17727000, 17727000
. : milestone, 17727000,
profiling (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
tracing (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]