Fix CodeOrigin for `@Trace` annotation #8344

jpbempel · 2025-02-06T09:53:15Z

What Does This Do

add a param for captureCodeOrigin method to indicate if we need to
instrument for the CodeOriginProbe. the instrumentation for the
@trace annotation insert a call to start and activate the span.
so we just need to call captureCodeOrigin after the activation so we
benefit from tracer instrumentation without generating a call to
CodeOrigin probe.
That way are in sync with the tracer instrumentation.
add smoke test

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3449

pr-commenter · 2025-02-06T10:11:44Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1738863485	1738863856
end_time	2025-02-06T17:39:22	2025-02-06T17:45:32
git_branch	master	jpbempel/fix-code-origin-trace-annot
git_commit_sha	`8a74e85`	`8871f09`
start_time	2025-02-06T17:38:06	2025-02-06T17:44:17

See matching parameters

	Baseline	Candidate
ci_job_id	797664174	797664174
ci_pipeline_id	55151914	55151914
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1738861697	1738861697

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-66.365µs; +26.710µs] or [-23.146%; +9.316%]	unstable [-87.696µs; +34.870µs] or [-26.583%; +10.570%]	unstable [-102.063µs; +41.744µs] or [-29.428%; +12.036%]	unstable [-1116.418µs; +359.753µs] or [-118.705%; +38.251%]	same
scenario:basic	same	same	unstable [-32.496µs; +5.373µs] or [-10.134%; +1.675%]	unstable [-261.683µs; +103.005µs] or [-44.254%; +17.419%]	unstable [-83.479op/s; +218.432op/s] or [-3.256%; +8.519%]
scenario:loop	same	same	same	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (329.9 µs) : 251, 409
.   : milestone, 330,
basic (307.212 µs) : 290, 324
.   : milestone, 307,
loop (10.154 ms) : 10102, 10206
.   : milestone, 10154,
section candidate
noprobe (303.487 µs) : 279, 328
.   : milestone, 303,
basic (295.629 µs) : 287, 304
.   : milestone, 296,
loop (10.147 ms) : 10114, 10181
.   : milestone, 10147,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	329.9 µs [251.025 µs, 408.776 µs]
basic	307.212 µs [289.966 µs, 324.459 µs]
loop	10.154 ms [10.102 ms, 10.206 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	303.487 µs [278.918 µs, 328.056 µs]
basic	295.629 µs [287.013 µs, 304.246 µs]
loop	10.147 ms [10.114 ms, 10.181 ms]

pr-commenter · 2025-02-06T10:31:41Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-code-origin-trace-annot
git_commit_date	1738853998	1738862789
git_commit_sha	`8a74e85`	`f1458bf`
release_version	1.47.0-SNAPSHOT~8a74e85918	1.47.0-SNAPSHOT~f1458bf562

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738865249	1738865249
ci_job_id	797712350	797712350
ci_pipeline_id	55154968	55154968
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner--mzpkcy-project-304-concurrent-0-zlmp4tgx 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner--mzpkcy-project-304-concurrent-0-zlmp4tgx 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~f1458bf562, baseline=1.47.0-SNAPSHOT~8a74e85918

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050104
Total [baseline] (10.505 s) : 0, 10504999
Agent [candidate] (1.053 s) : 0, 1053322
Total [candidate] (10.47 s) : 0, 10469989
section appsec
Agent [baseline] (1.196 s) : 0, 1196334
Total [baseline] (10.778 s) : 0, 10778119
Agent [candidate] (1.183 s) : 0, 1183002
Total [candidate] (10.757 s) : 0, 10757285
section iast
Agent [baseline] (1.173 s) : 0, 1172585
Total [baseline] (10.976 s) : 0, 10976291
Agent [candidate] (1.176 s) : 0, 1176141
Total [candidate] (10.993 s) : 0, 10993330
section profiling
Agent [baseline] (1.261 s) : 0, 1261377
Total [baseline] (10.827 s) : 0, 10827383
Agent [candidate] (1.262 s) : 0, 1261528
Total [candidate] (10.94 s) : 0, 10940320

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	appsec	1.196 s	146.23 ms (13.9%)
Agent	iast	1.173 s	122.481 ms (11.7%)
Agent	profiling	1.261 s	211.273 ms (20.1%)
Total	tracing	10.505 s	-
Total	appsec	10.778 s	273.12 ms (2.6%)
Total	iast	10.976 s	471.293 ms (4.5%)
Total	profiling	10.827 s	322.384 ms (3.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	appsec	1.183 s	129.68 ms (12.3%)
Agent	iast	1.176 s	122.82 ms (11.7%)
Agent	profiling	1.262 s	208.207 ms (19.8%)
Total	tracing	10.47 s	-
Total	appsec	10.757 s	287.296 ms (2.7%)
Total	iast	10.993 s	523.341 ms (5.0%)
Total	profiling	10.94 s	470.331 ms (4.5%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~f1458bf562, baseline=1.47.0-SNAPSHOT~8a74e85918

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.194 ms) : 0, 721194
BytebuddyAgent [candidate] (721.469 ms) : 0, 721469
GlobalTracer [baseline] (244.363 ms) : 0, 244363
GlobalTracer [candidate] (245.012 ms) : 0, 245012
AppSec [baseline] (55.531 ms) : 0, 55531
AppSec [candidate] (55.568 ms) : 0, 55568
Remote Config [baseline] (721.202 µs) : 0, 721
Remote Config [candidate] (715.722 µs) : 0, 716
Telemetry [baseline] (12.974 ms) : 0, 12974
Telemetry [candidate] (15.135 ms) : 0, 15135
section appsec
BytebuddyAgent [baseline] (740.839 ms) : 0, 740839
BytebuddyAgent [candidate] (732.263 ms) : 0, 732263
GlobalTracer [baseline] (242.381 ms) : 0, 242381
GlobalTracer [candidate] (240.39 ms) : 0, 240390
AppSec [baseline] (177.684 ms) : 0, 177684
AppSec [candidate] (175.379 ms) : 0, 175379
Remote Config [baseline] (682.257 µs) : 0, 682
Remote Config [candidate] (651.433 µs) : 0, 651
Telemetry [baseline] (8.404 ms) : 0, 8404
Telemetry [candidate] (8.27 ms) : 0, 8270
IAST [baseline] (21.972 ms) : 0, 21972
IAST [candidate] (21.79 ms) : 0, 21790
section iast
BytebuddyAgent [baseline] (835.025 ms) : 0, 835025
BytebuddyAgent [candidate] (836.633 ms) : 0, 836633
GlobalTracer [baseline] (233.492 ms) : 0, 233492
GlobalTracer [candidate] (234.65 ms) : 0, 234650
AppSec [baseline] (56.846 ms) : 0, 56846
AppSec [candidate] (57.443 ms) : 0, 57443
Remote Config [baseline] (613.312 µs) : 0, 613
Remote Config [candidate] (620.144 µs) : 0, 620
Telemetry [baseline] (8.61 ms) : 0, 8610
Telemetry [candidate] (8.795 ms) : 0, 8795
IAST [baseline] (22.713 ms) : 0, 22713
IAST [candidate] (22.713 ms) : 0, 22713
section profiling
BytebuddyAgent [baseline] (705.935 ms) : 0, 705935
BytebuddyAgent [candidate] (706.02 ms) : 0, 706020
GlobalTracer [baseline] (352.676 ms) : 0, 352676
GlobalTracer [candidate] (353.228 ms) : 0, 353228
AppSec [baseline] (55.281 ms) : 0, 55281
AppSec [candidate] (54.535 ms) : 0, 54535
Remote Config [baseline] (686.037 µs) : 0, 686
Remote Config [candidate] (699.054 µs) : 0, 699
Telemetry [baseline] (8.869 ms) : 0, 8869
Telemetry [candidate] (8.836 ms) : 0, 8836
ProfilingAgent [baseline] (95.664 ms) : 0, 95664
ProfilingAgent [candidate] (95.827 ms) : 0, 95827
Profiling [baseline] (95.689 ms) : 0, 95689
Profiling [candidate] (95.851 ms) : 0, 95851

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~f1458bf562, baseline=1.47.0-SNAPSHOT~8a74e85918

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043917
Total [baseline] (8.636 s) : 0, 8635634
Agent [candidate] (1.048 s) : 0, 1048328
Total [candidate] (8.685 s) : 0, 8684612
section iast
Agent [baseline] (1.18 s) : 0, 1179638
Total [baseline] (9.233 s) : 0, 9233253
Agent [candidate] (1.186 s) : 0, 1186280
Total [candidate] (9.235 s) : 0, 9234999
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1179758
Total [baseline] (9.215 s) : 0, 9215496
Agent [candidate] (1.173 s) : 0, 1172990
Total [candidate] (9.239 s) : 0, 9238982
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1170577
Total [baseline] (9.217 s) : 0, 9216845
Agent [candidate] (1.173 s) : 0, 1172625
Total [candidate] (9.212 s) : 0, 9211805

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	iast	1.18 s	135.721 ms (13.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.18 s	135.842 ms (13.0%)
Agent	iast_TELEMETRY_OFF	1.171 s	126.66 ms (12.1%)
Total	tracing	8.636 s	-
Total	iast	9.233 s	597.619 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.215 s	579.862 ms (6.7%)
Total	iast_TELEMETRY_OFF	9.217 s	581.211 ms (6.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.186 s	137.952 ms (13.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.173 s	124.663 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.173 s	124.298 ms (11.9%)
Total	tracing	8.685 s	-
Total	iast	9.235 s	550.387 ms (6.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.239 s	554.37 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.212 s	527.193 ms (6.1%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~f1458bf562, baseline=1.47.0-SNAPSHOT~8a74e85918

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.768 ms) : 0, 716768
BytebuddyAgent [candidate] (718.746 ms) : 0, 718746
GlobalTracer [baseline] (243.296 ms) : 0, 243296
GlobalTracer [candidate] (245.399 ms) : 0, 245399
AppSec [baseline] (55.116 ms) : 0, 55116
AppSec [candidate] (55.436 ms) : 0, 55436
Remote Config [baseline] (719.033 µs) : 0, 719
Remote Config [candidate] (714.262 µs) : 0, 714
Telemetry [baseline] (12.876 ms) : 0, 12876
Telemetry [candidate] (12.799 ms) : 0, 12799
section iast
BytebuddyAgent [baseline] (839.89 ms) : 0, 839890
BytebuddyAgent [candidate] (846.894 ms) : 0, 846894
GlobalTracer [baseline] (234.99 ms) : 0, 234990
GlobalTracer [candidate] (234.893 ms) : 0, 234893
IAST [baseline] (23.003 ms) : 0, 23003
IAST [candidate] (22.919 ms) : 0, 22919
AppSec [baseline] (57.179 ms) : 0, 57179
AppSec [candidate] (56.807 ms) : 0, 56807
Remote Config [baseline] (608.327 µs) : 0, 608
Remote Config [candidate] (605.007 µs) : 0, 605
Telemetry [baseline] (8.731 ms) : 0, 8731
Telemetry [candidate] (8.64 ms) : 0, 8640
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.902 ms) : 0, 839902
BytebuddyAgent [candidate] (834.592 ms) : 0, 834592
GlobalTracer [baseline] (234.897 ms) : 0, 234897
GlobalTracer [candidate] (233.974 ms) : 0, 233974
IAST [baseline] (22.997 ms) : 0, 22997
IAST [candidate] (22.951 ms) : 0, 22951
AppSec [baseline] (57.197 ms) : 0, 57197
AppSec [candidate] (56.899 ms) : 0, 56899
Remote Config [baseline] (618.503 µs) : 0, 619
Remote Config [candidate] (615.889 µs) : 0, 616
Telemetry [baseline] (8.795 ms) : 0, 8795
Telemetry [candidate] (8.695 ms) : 0, 8695
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.56 ms) : 0, 834560
BytebuddyAgent [candidate] (835.358 ms) : 0, 835358
GlobalTracer [baseline] (232.772 ms) : 0, 232772
GlobalTracer [candidate] (234.573 ms) : 0, 234573
IAST [baseline] (26.946 ms) : 0, 26946
IAST [candidate] (28.415 ms) : 0, 28415
AppSec [baseline] (51.806 ms) : 0, 51806
AppSec [candidate] (49.865 ms) : 0, 49865
Remote Config [baseline] (607.05 µs) : 0, 607
Remote Config [candidate] (606.582 µs) : 0, 607
Telemetry [baseline] (8.595 ms) : 0, 8595
Telemetry [candidate] (8.508 ms) : 0, 8508

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-06T17:36:52	2025-02-06T17:43:55
git_branch	master	jpbempel/fix-code-origin-trace-annot
git_commit_date	1738853998	1738862789
git_commit_sha	`8a74e85`	`f1458bf`
release_version	1.47.0-SNAPSHOT~8a74e85918	1.47.0-SNAPSHOT~f1458bf562
start_time	2025-02-06T17:36:38	2025-02-06T17:43:42

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738864191	1738864191
ci_job_id	797712351	797712351
ci_pipeline_id	55154968	55154968
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-1byzsnlc-project-304-concurrent-0-oecjx2og 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-1byzsnlc-project-304-concurrent-0-oecjx2og 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~f1458bf562, baseline=1.47.0-SNAPSHOT~8a74e85918
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.633 µs) : 358, 399
.   : milestone, 379,
iast (505.379 µs) : 484, 527
.   : milestone, 505,
iast_FULL (740.063 µs) : 718, 762
.   : milestone, 740,
iast_GLOBAL (559.96 µs) : 537, 582
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (502.825 µs) : 481, 524
.   : milestone, 503,
iast_INACTIVE (454.32 µs) : 432, 477
.   : milestone, 454,
iast_TELEMETRY_OFF (498.315 µs) : 475, 522
.   : milestone, 498,
tracing (451.422 µs) : 430, 472
.   : milestone, 451,
section candidate
no_agent (379.221 µs) : 360, 399
.   : milestone, 379,
iast (503.02 µs) : 481, 525
.   : milestone, 503,
iast_FULL (735.444 µs) : 713, 758
.   : milestone, 735,
iast_GLOBAL (542.326 µs) : 521, 564
.   : milestone, 542,
iast_HARDCODED_SECRET_DISABLED (505.455 µs) : 483, 527
.   : milestone, 505,
iast_INACTIVE (457.396 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (488.53 µs) : 467, 510
.   : milestone, 489,
tracing (456.181 µs) : 435, 477
.   : milestone, 456,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.633 µs [358.48 µs, 398.786 µs]	-
iast	505.379 µs [483.782 µs, 526.977 µs]	126.746 µs (33.5%)
iast_FULL	740.063 µs [718.23 µs, 761.895 µs]	361.43 µs (95.5%)
iast_GLOBAL	559.96 µs [537.439 µs, 582.48 µs]	181.326 µs (47.9%)
iast_HARDCODED_SECRET_DISABLED	502.825 µs [481.367 µs, 524.283 µs]	124.192 µs (32.8%)
iast_INACTIVE	454.32 µs [431.969 µs, 476.671 µs]	75.687 µs (20.0%)
iast_TELEMETRY_OFF	498.315 µs [474.971 µs, 521.659 µs]	119.682 µs (31.6%)
tracing	451.422 µs [430.499 µs, 472.344 µs]	72.788 µs (19.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.221 µs [359.656 µs, 398.787 µs]	-
iast	503.02 µs [481.271 µs, 524.768 µs]	123.798 µs (32.6%)
iast_FULL	735.444 µs [713.352 µs, 757.537 µs]	356.223 µs (93.9%)
iast_GLOBAL	542.326 µs [521.01 µs, 563.641 µs]	163.104 µs (43.0%)
iast_HARDCODED_SECRET_DISABLED	505.455 µs [483.499 µs, 527.41 µs]	126.233 µs (33.3%)
iast_INACTIVE	457.396 µs [436.349 µs, 478.442 µs]	78.174 µs (20.6%)
iast_TELEMETRY_OFF	488.53 µs [466.803 µs, 510.256 µs]	109.308 µs (28.8%)
tracing	456.181 µs [434.986 µs, 477.377 µs]	76.96 µs (20.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~f1458bf562, baseline=1.47.0-SNAPSHOT~8a74e85918
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.373 ms) : 1354, 1393
.   : milestone, 1373,
appsec (1.734 ms) : 1711, 1757
.   : milestone, 1734,
appsec_no_iast (1.746 ms) : 1721, 1772
.   : milestone, 1746,
iast (1.489 ms) : 1465, 1514
.   : milestone, 1489,
profiling (1.504 ms) : 1480, 1527
.   : milestone, 1504,
tracing (1.492 ms) : 1468, 1516
.   : milestone, 1492,
section candidate
no_agent (1.336 ms) : 1316, 1355
.   : milestone, 1336,
appsec (1.753 ms) : 1730, 1776
.   : milestone, 1753,
appsec_no_iast (1.719 ms) : 1695, 1744
.   : milestone, 1719,
iast (1.504 ms) : 1479, 1528
.   : milestone, 1504,
profiling (1.486 ms) : 1462, 1509
.   : milestone, 1486,
tracing (1.488 ms) : 1463, 1514
.   : milestone, 1488,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.373 ms [1.354 ms, 1.393 ms]	-
appsec	1.734 ms [1.711 ms, 1.757 ms]	360.693 µs (26.3%)
appsec_no_iast	1.746 ms [1.721 ms, 1.772 ms]	373.148 µs (27.2%)
iast	1.489 ms [1.465 ms, 1.514 ms]	115.916 µs (8.4%)
profiling	1.504 ms [1.48 ms, 1.527 ms]	130.385 µs (9.5%)
tracing	1.492 ms [1.468 ms, 1.516 ms]	118.604 µs (8.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.336 ms [1.316 ms, 1.355 ms]	-
appsec	1.753 ms [1.73 ms, 1.776 ms]	417.61 µs (31.3%)
appsec_no_iast	1.719 ms [1.695 ms, 1.744 ms]	383.485 µs (28.7%)
iast	1.504 ms [1.479 ms, 1.528 ms]	167.893 µs (12.6%)
profiling	1.486 ms [1.462 ms, 1.509 ms]	149.943 µs (11.2%)
tracing	1.488 ms [1.463 ms, 1.514 ms]	152.682 µs (11.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-code-origin-trace-annot
git_commit_date	1738853998	1738862789
git_commit_sha	`8a74e85`	`f1458bf`
release_version	1.47.0-SNAPSHOT~8a74e85918	1.47.0-SNAPSHOT~f1458bf562

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1738864844	1738864844
ci_job_id	797712352	797712352
ci_pipeline_id	55154968	55154968
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-ffzxfqsk-project-304-concurrent-0-57ohimt0 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-ffzxfqsk-project-304-concurrent-0-57ohimt0 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~f1458bf562, baseline=1.47.0-SNAPSHOT~8a74e85918
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.37 ms) : 2327, 2414
.   : milestone, 2370,
iast (2.12 ms) : 2064, 2175
.   : milestone, 2120,
iast_GLOBAL (2.153 ms) : 2098, 2208
.   : milestone, 2153,
profiling (1.985 ms) : 1941, 2029
.   : milestone, 1985,
tracing (1.945 ms) : 1903, 1987
.   : milestone, 1945,
section candidate
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.363 ms) : 2319, 2406
.   : milestone, 2363,
iast (2.12 ms) : 2065, 2175
.   : milestone, 2120,
iast_GLOBAL (2.157 ms) : 2101, 2212
.   : milestone, 2157,
profiling (1.992 ms) : 1947, 2037
.   : milestone, 1992,
tracing (1.945 ms) : 1903, 1987
.   : milestone, 1945,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	2.37 ms [2.327 ms, 2.414 ms]	897.712 µs (61.0%)
iast	2.12 ms [2.064 ms, 2.175 ms]	646.989 µs (43.9%)
iast_GLOBAL	2.153 ms [2.098 ms, 2.208 ms]	680.034 µs (46.2%)
profiling	1.985 ms [1.941 ms, 2.029 ms]	512.459 µs (34.8%)
tracing	1.945 ms [1.903 ms, 1.987 ms]	471.898 µs (32.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.467 ms, 1.49 ms]	-
appsec	2.363 ms [2.319 ms, 2.406 ms]	884.353 µs (59.8%)
iast	2.12 ms [2.065 ms, 2.175 ms]	641.758 µs (43.4%)
iast_GLOBAL	2.157 ms [2.101 ms, 2.212 ms]	678.622 µs (45.9%)
profiling	1.992 ms [1.947 ms, 2.037 ms]	513.871 µs (34.8%)
tracing	1.945 ms [1.903 ms, 1.987 ms]	466.379 µs (31.6%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~f1458bf562, baseline=1.47.0-SNAPSHOT~8a74e85918
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.589 s) : 15589000, 15589000
.   : milestone, 15589000,
appsec (15.111 s) : 15111000, 15111000
.   : milestone, 15111000,
iast (18.301 s) : 18301000, 18301000
.   : milestone, 18301000,
iast_GLOBAL (17.837 s) : 17837000, 17837000
.   : milestone, 17837000,
profiling (15.042 s) : 15042000, 15042000
.   : milestone, 15042000,
tracing (14.897 s) : 14897000, 14897000
.   : milestone, 14897000,
section candidate
no_agent (14.744 s) : 14744000, 14744000
.   : milestone, 14744000,
appsec (15.33 s) : 15330000, 15330000
.   : milestone, 15330000,
iast (18.905 s) : 18905000, 18905000
.   : milestone, 18905000,
iast_GLOBAL (18.083 s) : 18083000, 18083000
.   : milestone, 18083000,
profiling (14.972 s) : 14972000, 14972000
.   : milestone, 14972000,
tracing (14.966 s) : 14966000, 14966000
.   : milestone, 14966000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.589 s [15.589 s, 15.589 s]	-
appsec	15.111 s [15.111 s, 15.111 s]	-478.0 ms (-3.1%)
iast	18.301 s [18.301 s, 18.301 s]	2.712 s (17.4%)
iast_GLOBAL	17.837 s [17.837 s, 17.837 s]	2.248 s (14.4%)
profiling	15.042 s [15.042 s, 15.042 s]	-547.0 ms (-3.5%)
tracing	14.897 s [14.897 s, 14.897 s]	-692.0 ms (-4.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.744 s [14.744 s, 14.744 s]	-
appsec	15.33 s [15.33 s, 15.33 s]	586.0 ms (4.0%)
iast	18.905 s [18.905 s, 18.905 s]	4.161 s (28.2%)
iast_GLOBAL	18.083 s [18.083 s, 18.083 s]	3.339 s (22.6%)
profiling	14.972 s [14.972 s, 14.972 s]	228.0 ms (1.5%)
tracing	14.966 s [14.966 s, 14.966 s]	222.0 ms (1.5%)

@trace

add a param for captureCodeOrigin method to indicate if we need to instrument for the CodeOriginProbe. the instrumentation for the @trace annotation insert a call to start and activate the span. so we just need to call captureCodeOrigin after the activation so we benefit from tracer instrumentation without generating a call to CodeOriginProbe. That way are in sync with the tracer instrumentation. add smoke test

jpbempel added comp: debugger Dynamic Instrumentation type: bug labels Feb 6, 2025

jpbempel force-pushed the jpbempel/fix-code-origin-trace-annot branch 3 times, most recently from 683c682 to 8871f09 Compare February 6, 2025 17:08

jpbempel marked this pull request as ready for review February 6, 2025 17:09

jpbempel requested review from a team as code owners February 6, 2025 17:09

jpbempel requested review from ojung and removed request for a team February 6, 2025 17:09

jpbempel force-pushed the jpbempel/fix-code-origin-trace-annot branch from 8871f09 to f1458bf Compare February 6, 2025 17:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CodeOrigin for `@Trace` annotation #8344

Fix CodeOrigin for `@Trace` annotation #8344

jpbempel commented Feb 6, 2025 •

edited

Loading

pr-commenter bot commented Feb 6, 2025 •

edited

Loading

pr-commenter bot commented Feb 6, 2025 •

edited

Loading

Fix CodeOrigin for @Trace annotation #8344

Are you sure you want to change the base?

Fix CodeOrigin for @Trace annotation #8344

Conversation

jpbempel commented Feb 6, 2025 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Feb 6, 2025 • edited Loading

Debugger benchmarks

Parameters

Summary

pr-commenter bot commented Feb 6, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Fix CodeOrigin for `@Trace` annotation #8344

Fix CodeOrigin for `@Trace` annotation #8344

jpbempel commented Feb 6, 2025 •

edited

Loading

pr-commenter bot commented Feb 6, 2025 •

edited

Loading

pr-commenter bot commented Feb 6, 2025 •

edited

Loading