Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix org.json iast instrumentation test for latest dependency #8347

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix org.json iast instrumentation test for latest dependency #8347

wants to merge 5 commits into from

Conversation

jandro996
Copy link
Member

@jandro996 jandro996 commented Feb 6, 2025 •
edited
Loading

What Does This Do

  • Rework tests to be more accurate and avoid problems with new versions
  • Remove redundant instrumentation as get methods always call opt methods
  • Be more accurate with instrumented constructors as they call each other internally
  • Improve java.io.InputStream propagation

Motivation

Fix latest dependency test for org.json (20250107)

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-56455

@jandro996 jandro996 added type: bug comp: asm iast Application Security Management (IAST) labels Feb 6, 2025
@jandro996 jandro996 force-pushed the alejandro.gonzalez/APPSEC-56455 branch from aceb1ba to 9b82465 Compare February 6, 2025 11:27
@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/APPSEC-56455
git_commit_date 1739180494 1739182658
git_commit_sha 40f8224 4984a98
release_version 1.47.0-SNAPSHOT~40f82243ba 1.47.0-SNAPSHOT~4984a98bc1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739185137 1739185137
ci_job_id 800560162 800560162
ci_pipeline_id 55373471 55373471
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tb7vycf1-project-304-concurrent-0-v4z147mq 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tb7vycf1-project-304-concurrent-0-v4z147mq 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~4984a98bc1, baseline=1.47.0-SNAPSHOT~40f82243ba

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047900
Total [baseline] (10.469 s) : 0, 10469339
Agent [candidate] (1.047 s) : 0, 1046583
Total [candidate] (10.48 s) : 0, 10479762
section appsec
Agent [baseline] (1.189 s) : 0, 1189480
Total [baseline] (10.764 s) : 0, 10763925
Agent [candidate] (1.189 s) : 0, 1189269
Total [candidate] (10.777 s) : 0, 10776573
section iast
Agent [baseline] (1.174 s) : 0, 1173699
Total [baseline] (10.972 s) : 0, 10971759
Agent [candidate] (1.181 s) : 0, 1181370
Total [candidate] (10.983 s) : 0, 10983222
section profiling
Agent [baseline] (1.265 s) : 0, 1265045
Total [baseline] (10.895 s) : 0, 10895200
Agent [candidate] (1.263 s) : 0, 1262734
Total [candidate] (10.929 s) : 0, 10928864
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.189 s 141.58 ms (13.5%)
Agent iast 1.174 s 125.798 ms (12.0%)
Agent profiling 1.265 s 217.145 ms (20.7%)
Total tracing 10.469 s -
Total appsec 10.764 s 294.586 ms (2.8%)
Total iast 10.972 s 502.42 ms (4.8%)
Total profiling 10.895 s 425.861 ms (4.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.189 s 142.687 ms (13.6%)
Agent iast 1.181 s 134.788 ms (12.9%)
Agent profiling 1.263 s 216.151 ms (20.7%)
Total tracing 10.48 s -
Total appsec 10.777 s 296.811 ms (2.8%)
Total iast 10.983 s 503.46 ms (4.8%)
Total profiling 10.929 s 449.103 ms (4.3%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~4984a98bc1, baseline=1.47.0-SNAPSHOT~40f82243ba

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.022 ms) : 0, 720022
BytebuddyAgent [candidate] (717.47 ms) : 0, 717470
GlobalTracer [baseline] (244.256 ms) : 0, 244256
GlobalTracer [candidate] (243.733 ms) : 0, 243733
AppSec [baseline] (55.35 ms) : 0, 55350
AppSec [candidate] (54.998 ms) : 0, 54998
Remote Config [baseline] (724.092 µs) : 0, 724
Remote Config [candidate] (710.175 µs) : 0, 710
Telemetry [baseline] (12.251 ms) : 0, 12251
Telemetry [candidate] (14.516 ms) : 0, 14516
section appsec
BytebuddyAgent [baseline] (736.514 ms) : 0, 736514
BytebuddyAgent [candidate] (737.473 ms) : 0, 737473
GlobalTracer [baseline] (240.822 ms) : 0, 240822
GlobalTracer [candidate] (240.546 ms) : 0, 240546
AppSec [baseline] (176.714 ms) : 0, 176714
AppSec [candidate] (176.236 ms) : 0, 176236
Remote Config [baseline] (664.667 µs) : 0, 665
Remote Config [candidate] (660.605 µs) : 0, 661
Telemetry [baseline] (8.647 ms) : 0, 8647
Telemetry [candidate] (8.24 ms) : 0, 8240
IAST [baseline] (21.775 ms) : 0, 21775
IAST [candidate] (21.749 ms) : 0, 21749
section iast
BytebuddyAgent [baseline] (835.777 ms) : 0, 835777
BytebuddyAgent [candidate] (841.727 ms) : 0, 841727
GlobalTracer [baseline] (233.376 ms) : 0, 233376
GlobalTracer [candidate] (234.726 ms) : 0, 234726
AppSec [baseline] (56.998 ms) : 0, 56998
AppSec [candidate] (57.21 ms) : 0, 57210
Remote Config [baseline] (618.681 µs) : 0, 619
Remote Config [candidate] (613.58 µs) : 0, 614
Telemetry [baseline] (8.699 ms) : 0, 8699
Telemetry [candidate] (8.755 ms) : 0, 8755
IAST [baseline] (23.006 ms) : 0, 23006
IAST [candidate] (22.892 ms) : 0, 22892
section profiling
BytebuddyAgent [baseline] (707.195 ms) : 0, 707195
BytebuddyAgent [candidate] (707.737 ms) : 0, 707737
GlobalTracer [baseline] (353.503 ms) : 0, 353503
GlobalTracer [candidate] (352.849 ms) : 0, 352849
AppSec [baseline] (55.176 ms) : 0, 55176
AppSec [candidate] (54.689 ms) : 0, 54689
Remote Config [baseline] (720.759 µs) : 0, 721
Remote Config [candidate] (702.918 µs) : 0, 703
Telemetry [baseline] (9.722 ms) : 0, 9722
Telemetry [candidate] (8.877 ms) : 0, 8877
ProfilingAgent [baseline] (96.562 ms) : 0, 96562
ProfilingAgent [candidate] (95.609 ms) : 0, 95609
Profiling [baseline] (96.586 ms) : 0, 96586
Profiling [candidate] (95.634 ms) : 0, 95634
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~4984a98bc1, baseline=1.47.0-SNAPSHOT~40f82243ba

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047168
Total [baseline] (8.652 s) : 0, 8652416
Agent [candidate] (1.046 s) : 0, 1046274
Total [candidate] (8.646 s) : 0, 8645883
section iast
Agent [baseline] (1.181 s) : 0, 1180760
Total [baseline] (9.205 s) : 0, 9205366
Agent [candidate] (1.181 s) : 0, 1180933
Total [candidate] (9.249 s) : 0, 9249219
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175784
Total [baseline] (9.265 s) : 0, 9264983
Agent [candidate] (1.198 s) : 0, 1198331
Total [candidate] (9.276 s) : 0, 9275596
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1177375
Total [baseline] (9.229 s) : 0, 9229046
Agent [candidate] (1.186 s) : 0, 1185564
Total [candidate] (9.254 s) : 0, 9254057
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.181 s 133.592 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 128.616 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.177 s 130.207 ms (12.4%)
Total tracing 8.652 s -
Total iast 9.205 s 552.949 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.265 s 612.567 ms (7.1%)
Total iast_TELEMETRY_OFF 9.229 s 576.63 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.181 s 134.659 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 152.057 ms (14.5%)
Agent iast_TELEMETRY_OFF 1.186 s 139.29 ms (13.3%)
Total tracing 8.646 s -
Total iast 9.249 s 603.337 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.276 s 629.713 ms (7.3%)
Total iast_TELEMETRY_OFF 9.254 s 608.174 ms (7.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~4984a98bc1, baseline=1.47.0-SNAPSHOT~40f82243ba

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.541 ms) : 0, 718541
BytebuddyAgent [candidate] (718.038 ms) : 0, 718038
GlobalTracer [baseline] (243.312 ms) : 0, 243312
GlobalTracer [candidate] (243.537 ms) : 0, 243537
AppSec [baseline] (54.933 ms) : 0, 54933
AppSec [candidate] (55.267 ms) : 0, 55267
Remote Config [baseline] (714.091 µs) : 0, 714
Remote Config [candidate] (719.059 µs) : 0, 719
Telemetry [baseline] (14.46 ms) : 0, 14460
Telemetry [candidate] (13.543 ms) : 0, 13543
section iast
BytebuddyAgent [baseline] (841.768 ms) : 0, 841768
BytebuddyAgent [candidate] (841.417 ms) : 0, 841417
GlobalTracer [baseline] (234.226 ms) : 0, 234226
GlobalTracer [candidate] (234.556 ms) : 0, 234556
IAST [baseline] (22.975 ms) : 0, 22975
IAST [candidate] (22.922 ms) : 0, 22922
AppSec [baseline] (56.97 ms) : 0, 56970
AppSec [candidate] (57.305 ms) : 0, 57305
Remote Config [baseline] (620.543 µs) : 0, 621
Remote Config [candidate] (611.694 µs) : 0, 612
Telemetry [baseline] (8.783 ms) : 0, 8783
Telemetry [candidate] (8.833 ms) : 0, 8833
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.154 ms) : 0, 837154
BytebuddyAgent [candidate] (854.96 ms) : 0, 854960
GlobalTracer [baseline] (233.494 ms) : 0, 233494
GlobalTracer [candidate] (236.997 ms) : 0, 236997
IAST [baseline] (23.008 ms) : 0, 23008
IAST [candidate] (23.636 ms) : 0, 23636
AppSec [baseline] (57.365 ms) : 0, 57365
AppSec [candidate] (57.617 ms) : 0, 57617
Remote Config [baseline] (625.783 µs) : 0, 626
Remote Config [candidate] (623.015 µs) : 0, 623
Telemetry [baseline] (8.855 ms) : 0, 8855
Telemetry [candidate] (8.83 ms) : 0, 8830
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.348 ms) : 0, 838348
BytebuddyAgent [candidate] (844.847 ms) : 0, 844847
GlobalTracer [baseline] (234.633 ms) : 0, 234633
GlobalTracer [candidate] (236.264 ms) : 0, 236264
IAST [baseline] (27.416 ms) : 0, 27416
IAST [candidate] (27.348 ms) : 0, 27348
AppSec [baseline] (52.378 ms) : 0, 52378
AppSec [candidate] (52.312 ms) : 0, 52312
Remote Config [baseline] (628.262 µs) : 0, 628
Remote Config [candidate] (623.403 µs) : 0, 623
Telemetry [baseline] (8.678 ms) : 0, 8678
Telemetry [candidate] (8.75 ms) : 0, 8750
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-10T10:28:55 2025-02-10T10:36:04
git_branch master alejandro.gonzalez/APPSEC-56455
git_commit_date 1739180494 1739182658
git_commit_sha 40f8224 4984a98
release_version 1.47.0-SNAPSHOT~40f82243ba 1.47.0-SNAPSHOT~4984a98bc1
start_time 2025-02-10T10:28:41 2025-02-10T10:35:50
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739184125 1739184125
ci_job_id 800560164 800560164
ci_pipeline_id 55373471 55373471
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tb7vycf1-project-304-concurrent-1-3svvjx3a 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tb7vycf1-project-304-concurrent-1-3svvjx3a 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~4984a98bc1, baseline=1.47.0-SNAPSHOT~40f82243ba
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.363 ms) : 1343, 1382
.   : milestone, 1363,
appsec (1.793 ms) : 1770, 1816
.   : milestone, 1793,
appsec_no_iast (1.784 ms) : 1762, 1807
.   : milestone, 1784,
iast (1.531 ms) : 1506, 1556
.   : milestone, 1531,
profiling (1.547 ms) : 1522, 1572
.   : milestone, 1547,
tracing (1.495 ms) : 1470, 1521
.   : milestone, 1495,
section candidate
no_agent (1.367 ms) : 1346, 1388
.   : milestone, 1367,
appsec (1.754 ms) : 1730, 1778
.   : milestone, 1754,
appsec_no_iast (1.779 ms) : 1755, 1803
.   : milestone, 1779,
iast (1.527 ms) : 1502, 1551
.   : milestone, 1527,
profiling (1.521 ms) : 1497, 1544
.   : milestone, 1521,
tracing (1.507 ms) : 1483, 1531
.   : milestone, 1507,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.343 ms, 1.382 ms] -
appsec 1.793 ms [1.77 ms, 1.816 ms] 430.062 µs (31.6%)
appsec_no_iast 1.784 ms [1.762 ms, 1.807 ms] 421.913 µs (31.0%)
iast 1.531 ms [1.506 ms, 1.556 ms] 168.366 µs (12.4%)
profiling 1.547 ms [1.522 ms, 1.572 ms] 184.611 µs (13.5%)
tracing 1.495 ms [1.47 ms, 1.521 ms] 132.735 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.367 ms [1.346 ms, 1.388 ms] -
appsec 1.754 ms [1.73 ms, 1.778 ms] 386.81 µs (28.3%)
appsec_no_iast 1.779 ms [1.755 ms, 1.803 ms] 411.865 µs (30.1%)
iast 1.527 ms [1.502 ms, 1.551 ms] 159.691 µs (11.7%)
profiling 1.521 ms [1.497 ms, 1.544 ms] 153.827 µs (11.3%)
tracing 1.507 ms [1.483 ms, 1.531 ms] 140.146 µs (10.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~4984a98bc1, baseline=1.47.0-SNAPSHOT~40f82243ba
    dateFormat X
    axisFormat %s
section baseline
no_agent (388.161 µs) : 368, 408
.   : milestone, 388,
iast (522.471 µs) : 500, 545
.   : milestone, 522,
iast_FULL (750.902 µs) : 729, 773
.   : milestone, 751,
iast_GLOBAL (560.347 µs) : 538, 582
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (521.082 µs) : 500, 543
.   : milestone, 521,
iast_INACTIVE (465.844 µs) : 445, 487
.   : milestone, 466,
iast_TELEMETRY_OFF (504.103 µs) : 481, 527
.   : milestone, 504,
tracing (468.154 µs) : 447, 490
.   : milestone, 468,
section candidate
no_agent (392.084 µs) : 372, 412
.   : milestone, 392,
iast (517.306 µs) : 495, 539
.   : milestone, 517,
iast_FULL (749.483 µs) : 728, 771
.   : milestone, 749,
iast_GLOBAL (558.297 µs) : 536, 581
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (519.394 µs) : 498, 541
.   : milestone, 519,
iast_INACTIVE (473.82 µs) : 452, 495
.   : milestone, 474,
iast_TELEMETRY_OFF (508.613 µs) : 486, 531
.   : milestone, 509,
tracing (467.389 µs) : 446, 489
.   : milestone, 467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 388.161 µs [368.101 µs, 408.222 µs] -
iast 522.471 µs [500.151 µs, 544.792 µs] 134.31 µs (34.6%)
iast_FULL 750.902 µs [729.041 µs, 772.764 µs] 362.741 µs (93.5%)
iast_GLOBAL 560.347 µs [538.291 µs, 582.403 µs] 172.186 µs (44.4%)
iast_HARDCODED_SECRET_DISABLED 521.082 µs [499.527 µs, 542.637 µs] 132.921 µs (34.2%)
iast_INACTIVE 465.844 µs [444.789 µs, 486.899 µs] 77.683 µs (20.0%)
iast_TELEMETRY_OFF 504.103 µs [481.316 µs, 526.89 µs] 115.941 µs (29.9%)
tracing 468.154 µs [446.716 µs, 489.592 µs] 79.993 µs (20.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 392.084 µs [371.749 µs, 412.42 µs] -
iast 517.306 µs [495.234 µs, 539.379 µs] 125.222 µs (31.9%)
iast_FULL 749.483 µs [727.559 µs, 771.408 µs] 357.399 µs (91.2%)
iast_GLOBAL 558.297 µs [535.628 µs, 580.966 µs] 166.213 µs (42.4%)
iast_HARDCODED_SECRET_DISABLED 519.394 µs [497.557 µs, 541.232 µs] 127.31 µs (32.5%)
iast_INACTIVE 473.82 µs [452.172 µs, 495.468 µs] 81.736 µs (20.8%)
iast_TELEMETRY_OFF 508.613 µs [485.818 µs, 531.407 µs] 116.528 µs (29.7%)
tracing 467.389 µs [445.664 µs, 489.114 µs] 75.304 µs (19.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/APPSEC-56455
git_commit_date 1739180494 1739182658
git_commit_sha 40f8224 4984a98
release_version 1.47.0-SNAPSHOT~40f82243ba 1.47.0-SNAPSHOT~4984a98bc1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1739184682 1739184682
ci_job_id 800560167 800560167
ci_pipeline_id 55373471 55373471
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tb7vycf1-project-304-concurrent-2-q1vqy2q2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tb7vycf1-project-304-concurrent-2-q1vqy2q2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~4984a98bc1, baseline=1.47.0-SNAPSHOT~40f82243ba
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.946 s) : 14946000, 14946000
.   : milestone, 14946000,
appsec (14.697 s) : 14697000, 14697000
.   : milestone, 14697000,
iast (18.702 s) : 18702000, 18702000
.   : milestone, 18702000,
iast_GLOBAL (18.097 s) : 18097000, 18097000
.   : milestone, 18097000,
profiling (15.073 s) : 15073000, 15073000
.   : milestone, 15073000,
tracing (14.873 s) : 14873000, 14873000
.   : milestone, 14873000,
section candidate
no_agent (15.46 s) : 15460000, 15460000
.   : milestone, 15460000,
appsec (15.087 s) : 15087000, 15087000
.   : milestone, 15087000,
iast (18.953 s) : 18953000, 18953000
.   : milestone, 18953000,
iast_GLOBAL (18.512 s) : 18512000, 18512000
.   : milestone, 18512000,
profiling (15.444 s) : 15444000, 15444000
.   : milestone, 15444000,
tracing (14.819 s) : 14819000, 14819000
.   : milestone, 14819000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.946 s [14.946 s, 14.946 s] -
appsec 14.697 s [14.697 s, 14.697 s] -249.0 ms (-1.7%)
iast 18.702 s [18.702 s, 18.702 s] 3.756 s (25.1%)
iast_GLOBAL 18.097 s [18.097 s, 18.097 s] 3.151 s (21.1%)
profiling 15.073 s [15.073 s, 15.073 s] 127.0 ms (0.8%)
tracing 14.873 s [14.873 s, 14.873 s] -73.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.46 s [15.46 s, 15.46 s] -
appsec 15.087 s [15.087 s, 15.087 s] -373.0 ms (-2.4%)
iast 18.953 s [18.953 s, 18.953 s] 3.493 s (22.6%)
iast_GLOBAL 18.512 s [18.512 s, 18.512 s] 3.052 s (19.7%)
profiling 15.444 s [15.444 s, 15.444 s] -16.0 ms (-0.1%)
tracing 14.819 s [14.819 s, 14.819 s] -641.0 ms (-4.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~4984a98bc1, baseline=1.47.0-SNAPSHOT~40f82243ba
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.364 ms) : 2320, 2407
.   : milestone, 2364,
iast (2.101 ms) : 2046, 2155
.   : milestone, 2101,
iast_GLOBAL (2.147 ms) : 2092, 2202
.   : milestone, 2147,
profiling (1.972 ms) : 1928, 2017
.   : milestone, 1972,
tracing (1.945 ms) : 1903, 1987
.   : milestone, 1945,
section candidate
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.356 ms) : 2313, 2399
.   : milestone, 2356,
iast (2.107 ms) : 2052, 2162
.   : milestone, 2107,
iast_GLOBAL (2.146 ms) : 2091, 2202
.   : milestone, 2146,
profiling (1.956 ms) : 1913, 2000
.   : milestone, 1956,
tracing (1.943 ms) : 1901, 1986
.   : milestone, 1943,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.364 ms [2.32 ms, 2.407 ms] 896.439 µs (61.1%)
iast 2.101 ms [2.046 ms, 2.155 ms] 633.532 µs (43.2%)
iast_GLOBAL 2.147 ms [2.092 ms, 2.202 ms] 680.206 µs (46.4%)
profiling 1.972 ms [1.928 ms, 2.017 ms] 505.1 µs (34.4%)
tracing 1.945 ms [1.903 ms, 1.987 ms] 477.906 µs (32.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.454 ms, 1.477 ms] -
appsec 2.356 ms [2.313 ms, 2.399 ms] 890.402 µs (60.7%)
iast 2.107 ms [2.052 ms, 2.162 ms] 641.006 µs (43.7%)
iast_GLOBAL 2.146 ms [2.091 ms, 2.202 ms] 680.646 µs (46.4%)
profiling 1.956 ms [1.913 ms, 2.0 ms] 490.583 µs (33.5%)
tracing 1.943 ms [1.901 ms, 1.986 ms] 477.598 µs (32.6%)

@jandro996 jandro996 marked this pull request as ready for review February 10, 2025 12:22
@jandro996 jandro996 requested review from a team as code owners February 10, 2025 12:22
sezen-datadog
sezen-datadog reviewed Feb 10, 2025
View reviewed changes
...json/src/main/java/datadog/trace/instrumentation/json/JSONObject20241224Instrumentation.java
public class JSONObject20241224Instrumentation extends InstrumenterModule.Iast
implements Instrumenter.ForSingleType, Instrumenter.HasMethodAdvice {
public JSONObject20241224Instrumentation() {
super("org-json");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if this is a problem, can they be named identically? perhaps it's beneficial to name it differently?

manuel-alvarez-alvarez
manuel-alvarez-alvarez approved these changes Feb 11, 2025
View reviewed changes
...json/src/main/java/datadog/trace/instrumentation/json/JSONObject20241224Instrumentation.java
return "after_20241224";
}

@Override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a muzzle reference rather than a class loader matcher?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezen-datadog sezen-datadog sezen-datadog left review comments

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jandro996 @manuel-alvarez-alvarez @sezen-datadog