-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove debug log on log probe critical path #8355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useless log
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~83ed347b29, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043445
Total [baseline] (10.44 s) : 0, 10439553
Agent [candidate] (1.045 s) : 0, 1044732
Total [candidate] (10.43 s) : 0, 10430369
section appsec
Agent [baseline] (1.186 s) : 0, 1185893
Total [baseline] (10.747 s) : 0, 10747260
Agent [candidate] (1.187 s) : 0, 1186530
Total [candidate] (10.722 s) : 0, 10722053
section iast
Agent [baseline] (1.171 s) : 0, 1171440
Total [baseline] (10.952 s) : 0, 10952009
Agent [candidate] (1.17 s) : 0, 1170268
Total [candidate] (10.889 s) : 0, 10889230
section profiling
Agent [baseline] (1.261 s) : 0, 1261427
Total [baseline] (10.918 s) : 0, 10918471
Agent [candidate] (1.269 s) : 0, 1268689
Total [candidate] (10.882 s) : 0, 10882229
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~83ed347b29, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.682 ms) : 0, 716682
BytebuddyAgent [candidate] (716.667 ms) : 0, 716667
GlobalTracer [baseline] (243.063 ms) : 0, 243063
GlobalTracer [candidate] (242.994 ms) : 0, 242994
AppSec [baseline] (54.889 ms) : 0, 54889
AppSec [candidate] (55.049 ms) : 0, 55049
Remote Config [baseline] (714.927 µs) : 0, 715
Remote Config [candidate] (720.168 µs) : 0, 720
Telemetry [baseline] (12.934 ms) : 0, 12934
Telemetry [candidate] (14.132 ms) : 0, 14132
section appsec
BytebuddyAgent [baseline] (734.638 ms) : 0, 734638
BytebuddyAgent [candidate] (734.289 ms) : 0, 734289
GlobalTracer [baseline] (240.339 ms) : 0, 240339
GlobalTracer [candidate] (240.654 ms) : 0, 240654
IAST [baseline] (21.75 ms) : 0, 21750
IAST [candidate] (21.841 ms) : 0, 21841
AppSec [baseline] (175.821 ms) : 0, 175821
AppSec [candidate] (176.108 ms) : 0, 176108
Remote Config [baseline] (665.645 µs) : 0, 666
Remote Config [candidate] (662.721 µs) : 0, 663
Telemetry [baseline] (8.322 ms) : 0, 8322
Telemetry [candidate] (8.641 ms) : 0, 8641
section iast
BytebuddyAgent [baseline] (833.558 ms) : 0, 833558
BytebuddyAgent [candidate] (833.526 ms) : 0, 833526
GlobalTracer [baseline] (233.606 ms) : 0, 233606
GlobalTracer [candidate] (232.73 ms) : 0, 232730
IAST [baseline] (22.763 ms) : 0, 22763
IAST [candidate] (22.725 ms) : 0, 22725
AppSec [baseline] (57.005 ms) : 0, 57005
AppSec [candidate] (56.782 ms) : 0, 56782
Remote Config [baseline] (615.252 µs) : 0, 615
Remote Config [candidate] (612.49 µs) : 0, 612
Telemetry [baseline] (8.651 ms) : 0, 8651
Telemetry [candidate] (8.627 ms) : 0, 8627
section profiling
BytebuddyAgent [baseline] (707.203 ms) : 0, 707203
BytebuddyAgent [candidate] (710.094 ms) : 0, 710094
GlobalTracer [baseline] (351.693 ms) : 0, 351693
GlobalTracer [candidate] (355.31 ms) : 0, 355310
AppSec [baseline] (55.472 ms) : 0, 55472
AppSec [candidate] (54.662 ms) : 0, 54662
Remote Config [baseline] (705.681 µs) : 0, 706
Remote Config [candidate] (709.224 µs) : 0, 709
Telemetry [baseline] (8.944 ms) : 0, 8944
Telemetry [candidate] (8.99 ms) : 0, 8990
ProfilingAgent [baseline] (95.145 ms) : 0, 95145
ProfilingAgent [candidate] (96.325 ms) : 0, 96325
Profiling [baseline] (95.172 ms) : 0, 95172
Profiling [candidate] (96.353 ms) : 0, 96353
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~83ed347b29, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043632
Total [baseline] (8.634 s) : 0, 8633955
Agent [candidate] (1.042 s) : 0, 1041930
Total [candidate] (8.619 s) : 0, 8619255
section iast
Agent [baseline] (1.17 s) : 0, 1169570
Total [baseline] (9.191 s) : 0, 9191043
Agent [candidate] (1.167 s) : 0, 1167324
Total [candidate] (9.174 s) : 0, 9174291
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171814
Total [baseline] (9.171 s) : 0, 9171243
Agent [candidate] (1.174 s) : 0, 1173693
Total [candidate] (9.188 s) : 0, 9187886
section iast_TELEMETRY_OFF
Agent [baseline] (1.162 s) : 0, 1162235
Total [baseline] (9.237 s) : 0, 9237101
Agent [candidate] (1.173 s) : 0, 1172990
Total [candidate] (9.229 s) : 0, 9229189
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~83ed347b29, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.189 ms) : 0, 718189
BytebuddyAgent [candidate] (714.788 ms) : 0, 714788
GlobalTracer [baseline] (243.072 ms) : 0, 243072
GlobalTracer [candidate] (243.581 ms) : 0, 243581
AppSec [baseline] (55.014 ms) : 0, 55014
AppSec [candidate] (54.802 ms) : 0, 54802
Remote Config [baseline] (723.519 µs) : 0, 724
Remote Config [candidate] (714.908 µs) : 0, 715
Telemetry [baseline] (11.383 ms) : 0, 11383
Telemetry [candidate] (12.82 ms) : 0, 12820
section iast
BytebuddyAgent [baseline] (833.275 ms) : 0, 833275
BytebuddyAgent [candidate] (830.959 ms) : 0, 830959
GlobalTracer [baseline] (232.731 ms) : 0, 232731
GlobalTracer [candidate] (232.77 ms) : 0, 232770
IAST [baseline] (22.547 ms) : 0, 22547
IAST [candidate] (22.534 ms) : 0, 22534
AppSec [baseline] (56.592 ms) : 0, 56592
AppSec [candidate] (56.585 ms) : 0, 56585
Remote Config [baseline] (607.655 µs) : 0, 608
Remote Config [candidate] (613.987 µs) : 0, 614
Telemetry [baseline] (8.609 ms) : 0, 8609
Telemetry [candidate] (8.611 ms) : 0, 8611
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.089 ms) : 0, 834089
BytebuddyAgent [candidate] (835.137 ms) : 0, 835137
GlobalTracer [baseline] (233.295 ms) : 0, 233295
GlobalTracer [candidate] (233.83 ms) : 0, 233830
IAST [baseline] (22.929 ms) : 0, 22929
IAST [candidate] (22.954 ms) : 0, 22954
AppSec [baseline] (57.033 ms) : 0, 57033
AppSec [candidate] (57.17 ms) : 0, 57170
Remote Config [baseline] (626.432 µs) : 0, 626
Remote Config [candidate] (620.61 µs) : 0, 621
Telemetry [baseline] (8.605 ms) : 0, 8605
Telemetry [candidate] (8.655 ms) : 0, 8655
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.046 ms) : 0, 827046
BytebuddyAgent [candidate] (835.109 ms) : 0, 835109
GlobalTracer [baseline] (231.829 ms) : 0, 231829
GlobalTracer [candidate] (234.117 ms) : 0, 234117
IAST [baseline] (24.704 ms) : 0, 24704
IAST [candidate] (26.413 ms) : 0, 26413
AppSec [baseline] (54.297 ms) : 0, 54297
AppSec [candidate] (52.749 ms) : 0, 52749
Remote Config [baseline] (609.322 µs) : 0, 609
Remote Config [candidate] (602.808 µs) : 0, 603
Telemetry [baseline] (8.546 ms) : 0, 8546
Telemetry [candidate] (8.596 ms) : 0, 8596
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~83ed347b29, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section baseline
no_agent (1.351 ms) : 1332, 1371
. : milestone, 1351,
appsec (1.766 ms) : 1743, 1789
. : milestone, 1766,
appsec_no_iast (1.759 ms) : 1736, 1782
. : milestone, 1759,
iast (1.523 ms) : 1499, 1546
. : milestone, 1523,
profiling (1.509 ms) : 1486, 1532
. : milestone, 1509,
tracing (1.488 ms) : 1464, 1513
. : milestone, 1488,
section candidate
no_agent (1.352 ms) : 1333, 1372
. : milestone, 1352,
appsec (1.749 ms) : 1726, 1772
. : milestone, 1749,
appsec_no_iast (1.763 ms) : 1739, 1787
. : milestone, 1763,
iast (1.513 ms) : 1489, 1538
. : milestone, 1513,
profiling (1.496 ms) : 1473, 1520
. : milestone, 1496,
tracing (1.487 ms) : 1463, 1511
. : milestone, 1487,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~83ed347b29, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section baseline
no_agent (378.298 µs) : 358, 398
. : milestone, 378,
iast (504.107 µs) : 483, 525
. : milestone, 504,
iast_FULL (734.462 µs) : 712, 756
. : milestone, 734,
iast_GLOBAL (557.922 µs) : 536, 580
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (501.34 µs) : 480, 523
. : milestone, 501,
iast_INACTIVE (456.534 µs) : 435, 478
. : milestone, 457,
iast_TELEMETRY_OFF (491.354 µs) : 469, 514
. : milestone, 491,
tracing (449.461 µs) : 429, 470
. : milestone, 449,
section candidate
no_agent (375.185 µs) : 355, 395
. : milestone, 375,
iast (505.269 µs) : 483, 527
. : milestone, 505,
iast_FULL (741.087 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (545.225 µs) : 524, 567
. : milestone, 545,
iast_HARDCODED_SECRET_DISABLED (512.566 µs) : 491, 535
. : milestone, 513,
iast_INACTIVE (460.256 µs) : 439, 481
. : milestone, 460,
iast_TELEMETRY_OFF (493.976 µs) : 471, 517
. : milestone, 494,
tracing (448.391 µs) : 428, 469
. : milestone, 448,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~83ed347b29, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section baseline
no_agent (14.857 s) : 14857000, 14857000
. : milestone, 14857000,
appsec (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
iast (18.63 s) : 18630000, 18630000
. : milestone, 18630000,
iast_GLOBAL (17.757 s) : 17757000, 17757000
. : milestone, 17757000,
profiling (15.196 s) : 15196000, 15196000
. : milestone, 15196000,
tracing (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
section candidate
no_agent (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
appsec (15.155 s) : 15155000, 15155000
. : milestone, 15155000,
iast (18.954 s) : 18954000, 18954000
. : milestone, 18954000,
iast_GLOBAL (18.339 s) : 18339000, 18339000
. : milestone, 18339000,
profiling (15.124 s) : 15124000, 15124000
. : milestone, 15124000,
tracing (15.156 s) : 15156000, 15156000
. : milestone, 15156000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~83ed347b29, baseline=1.47.0-SNAPSHOT~8a74e85918
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.369 ms) : 2326, 2413
. : milestone, 2369,
iast (2.117 ms) : 2062, 2173
. : milestone, 2117,
iast_GLOBAL (2.154 ms) : 2099, 2210
. : milestone, 2154,
profiling (1.974 ms) : 1930, 2018
. : milestone, 1974,
tracing (1.947 ms) : 1904, 1989
. : milestone, 1947,
section candidate
no_agent (1.473 ms) : 1462, 1484
. : milestone, 1473,
appsec (2.358 ms) : 2314, 2402
. : milestone, 2358,
iast (2.114 ms) : 2059, 2168
. : milestone, 2114,
iast_GLOBAL (2.158 ms) : 2102, 2213
. : milestone, 2158,
profiling (1.991 ms) : 1946, 2036
. : milestone, 1991,
tracing (1.941 ms) : 1899, 1983
. : milestone, 1941,
|
ojung
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: debugger
Dynamic Instrumentation
tag: no release notes
Changes to exclude from release notes
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useless log
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]