Separate V1/V2 custom events to validate metrics sent via telemetry#8640
Closed
manuel-alvarez-alvarez wants to merge 1 commit intomasterfrom
Closed
Separate V1/V2 custom events to validate metrics sent via telemetry#8640manuel-alvarez-alvarez wants to merge 1 commit intomasterfrom
manuel-alvarez-alvarez wants to merge 1 commit intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~4af7297173, baseline=1.51.1-SNAPSHOT~37a4462bcf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044809
Total [baseline] (10.705 s) : 0, 10705271
Agent [candidate] (1.042 s) : 0, 1042276
Total [candidate] (10.691 s) : 0, 10691015
section appsec
Agent [baseline] (1.232 s) : 0, 1231844
Total [baseline] (10.835 s) : 0, 10834925
Agent [candidate] (1.218 s) : 0, 1217884
Total [candidate] (10.756 s) : 0, 10755759
section iast
Agent [baseline] (1.173 s) : 0, 1173321
Total [baseline] (10.83 s) : 0, 10829805
Agent [candidate] (1.178 s) : 0, 1177633
Total [candidate] (10.945 s) : 0, 10944585
section profiling
Agent [baseline] (1.197 s) : 0, 1197111
Total [baseline] (10.913 s) : 0, 10912832
Agent [candidate] (1.192 s) : 0, 1191799
Total [candidate] (10.879 s) : 0, 10878889
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~4af7297173, baseline=1.51.1-SNAPSHOT~37a4462bcf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.421 ms) : 0, 1421
BytebuddyAgent [baseline] (730.88 ms) : 0, 730880
BytebuddyAgent [candidate] (728.998 ms) : 0, 728998
GlobalTracer [baseline] (241.803 ms) : 0, 241803
GlobalTracer [candidate] (241.297 ms) : 0, 241297
AppSec [baseline] (30.505 ms) : 0, 30505
AppSec [candidate] (30.397 ms) : 0, 30397
Debugger [baseline] (5.962 ms) : 0, 5962
Debugger [candidate] (5.957 ms) : 0, 5957
Remote Config [baseline] (654.421 µs) : 0, 654
Remote Config [candidate] (648.579 µs) : 0, 649
Telemetry [baseline] (12.566 ms) : 0, 12566
Telemetry [candidate] (12.617 ms) : 0, 12617
section appsec
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.419 ms) : 0, 1419
BytebuddyAgent [baseline] (761.549 ms) : 0, 761549
BytebuddyAgent [candidate] (751.38 ms) : 0, 751380
GlobalTracer [baseline] (237.2 ms) : 0, 237200
GlobalTracer [candidate] (235.123 ms) : 0, 235123
IAST [baseline] (23.994 ms) : 0, 23994
IAST [candidate] (23.663 ms) : 0, 23663
AppSec [baseline] (169.276 ms) : 0, 169276
AppSec [candidate] (168.984 ms) : 0, 168984
Debugger [baseline] (7.952 ms) : 0, 7952
Debugger [candidate] (7.176 ms) : 0, 7176
Remote Config [baseline] (625.022 µs) : 0, 625
Remote Config [candidate] (623.282 µs) : 0, 623
Telemetry [baseline] (8.273 ms) : 0, 8273
Telemetry [candidate] (8.216 ms) : 0, 8216
section iast
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (846.923 ms) : 0, 846923
BytebuddyAgent [candidate] (849.777 ms) : 0, 849777
GlobalTracer [baseline] (231.402 ms) : 0, 231402
GlobalTracer [candidate] (232.485 ms) : 0, 232485
IAST [baseline] (28.317 ms) : 0, 28317
IAST [candidate] (29.306 ms) : 0, 29306
AppSec [baseline] (28.808 ms) : 0, 28808
AppSec [candidate] (27.572 ms) : 0, 27572
Debugger [baseline] (6.648 ms) : 0, 6648
Debugger [candidate] (7.376 ms) : 0, 7376
Remote Config [baseline] (603.136 µs) : 0, 603
Remote Config [candidate] (578.949 µs) : 0, 579
Telemetry [baseline] (8.185 ms) : 0, 8185
Telemetry [candidate] (8.112 ms) : 0, 8112
section profiling
crashtracking [baseline] (1.405 ms) : 0, 1405
crashtracking [candidate] (1.395 ms) : 0, 1395
BytebuddyAgent [baseline] (763.244 ms) : 0, 763244
BytebuddyAgent [candidate] (758.991 ms) : 0, 758991
GlobalTracer [baseline] (220.64 ms) : 0, 220640
GlobalTracer [candidate] (220.204 ms) : 0, 220204
AppSec [baseline] (30.289 ms) : 0, 30289
AppSec [candidate] (30.111 ms) : 0, 30111
Debugger [baseline] (6.197 ms) : 0, 6197
Debugger [candidate] (6.213 ms) : 0, 6213
Remote Config [baseline] (702.217 µs) : 0, 702
Remote Config [candidate] (680.653 µs) : 0, 681
Telemetry [baseline] (15.321 ms) : 0, 15321
Telemetry [candidate] (16.067 ms) : 0, 16067
ProfilingAgent [baseline] (110.544 ms) : 0, 110544
ProfilingAgent [candidate] (109.758 ms) : 0, 109758
Profiling [baseline] (110.569 ms) : 0, 110569
Profiling [candidate] (109.781 ms) : 0, 109781
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~4af7297173, baseline=1.51.1-SNAPSHOT~37a4462bcf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052001
Total [baseline] (8.665 s) : 0, 8664737
Agent [candidate] (1.053 s) : 0, 1052788
Total [candidate] (8.585 s) : 0, 8584821
section iast
Agent [baseline] (1.183 s) : 0, 1183462
Total [baseline] (9.328 s) : 0, 9328052
Agent [candidate] (1.19 s) : 0, 1189970
Total [candidate] (9.338 s) : 0, 9338310
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~4af7297173, baseline=1.51.1-SNAPSHOT~37a4462bcf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (736.106 ms) : 0, 736106
BytebuddyAgent [candidate] (736.493 ms) : 0, 736493
GlobalTracer [baseline] (244.244 ms) : 0, 244244
GlobalTracer [candidate] (243.497 ms) : 0, 243497
AppSec [baseline] (31.075 ms) : 0, 31075
AppSec [candidate] (30.758 ms) : 0, 30758
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (6.01 ms) : 0, 6010
Remote Config [baseline] (656.995 µs) : 0, 657
Remote Config [candidate] (653.355 µs) : 0, 653
Telemetry [baseline] (11.317 ms) : 0, 11317
Telemetry [candidate] (12.851 ms) : 0, 12851
section iast
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (854.098 ms) : 0, 854098
BytebuddyAgent [candidate] (860.569 ms) : 0, 860569
GlobalTracer [baseline] (233.015 ms) : 0, 233015
GlobalTracer [candidate] (233.132 ms) : 0, 233132
IAST [baseline] (28.635 ms) : 0, 28635
IAST [candidate] (31.131 ms) : 0, 31131
AppSec [baseline] (30.368 ms) : 0, 30368
AppSec [candidate] (27.836 ms) : 0, 27836
Debugger [baseline] (5.852 ms) : 0, 5852
Debugger [candidate] (5.839 ms) : 0, 5839
Remote Config [baseline] (599.687 µs) : 0, 600
Remote Config [candidate] (600.557 µs) : 0, 601
Telemetry [baseline] (8.304 ms) : 0, 8304
Telemetry [candidate] (8.333 ms) : 0, 8333
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~4af7297173, baseline=1.51.1-SNAPSHOT~37a4462bcf
dateFormat X
axisFormat %s
section baseline
no_agent (37.571 ms) : 37263, 37879
. : milestone, 37571,
appsec (46.606 ms) : 46174, 47038
. : milestone, 46606,
code_origins (46.553 ms) : 46138, 46968
. : milestone, 46553,
iast (43.961 ms) : 43583, 44339
. : milestone, 43961,
profiling (46.997 ms) : 46562, 47431
. : milestone, 46997,
tracing (44.237 ms) : 43852, 44623
. : milestone, 44237,
section candidate
no_agent (38.411 ms) : 38094, 38727
. : milestone, 38411,
appsec (46.061 ms) : 45670, 46453
. : milestone, 46061,
code_origins (43.803 ms) : 43434, 44172
. : milestone, 43803,
iast (45.566 ms) : 45175, 45958
. : milestone, 45566,
profiling (45.801 ms) : 45382, 46220
. : milestone, 45801,
tracing (43.186 ms) : 42831, 43541
. : milestone, 43186,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~4af7297173, baseline=1.51.1-SNAPSHOT~37a4462bcf
dateFormat X
axisFormat %s
section baseline
no_agent (4.41 ms) : 4350, 4470
. : milestone, 4410,
iast (9.493 ms) : 9339, 9646
. : milestone, 9493,
iast_FULL (14.541 ms) : 14251, 14831
. : milestone, 14541,
iast_GLOBAL (10.035 ms) : 9849, 10221
. : milestone, 10035,
profiling (8.422 ms) : 8286, 8557
. : milestone, 8422,
tracing (7.578 ms) : 7471, 7685
. : milestone, 7578,
section candidate
no_agent (4.275 ms) : 4221, 4328
. : milestone, 4275,
iast (9.488 ms) : 9325, 9652
. : milestone, 9488,
iast_FULL (14.49 ms) : 14206, 14774
. : milestone, 14490,
iast_GLOBAL (10.519 ms) : 10326, 10713
. : milestone, 10519,
profiling (8.673 ms) : 8534, 8812
. : milestone, 8673,
tracing (7.976 ms) : 7852, 8101
. : milestone, 7976,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~4af7297173, baseline=1.51.1-SNAPSHOT~37a4462bcf
dateFormat X
axisFormat %s
section baseline
no_agent (15.059 s) : 15059000, 15059000
. : milestone, 15059000,
appsec (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
iast (18.479 s) : 18479000, 18479000
. : milestone, 18479000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
. : milestone, 18054000,
profiling (15.305 s) : 15305000, 15305000
. : milestone, 15305000,
tracing (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
section candidate
no_agent (15.283 s) : 15283000, 15283000
. : milestone, 15283000,
appsec (14.826 s) : 14826000, 14826000
. : milestone, 14826000,
iast (18.869 s) : 18869000, 18869000
. : milestone, 18869000,
iast_GLOBAL (18.167 s) : 18167000, 18167000
. : milestone, 18167000,
profiling (15.786 s) : 15786000, 15786000
. : milestone, 15786000,
tracing (14.8 s) : 14800000, 14800000
. : milestone, 14800000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~4af7297173, baseline=1.51.1-SNAPSHOT~37a4462bcf
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.642 ms) : 3427, 3858
. : milestone, 3642,
iast (2.196 ms) : 2134, 2259
. : milestone, 2196,
iast_GLOBAL (2.235 ms) : 2172, 2298
. : milestone, 2235,
profiling (2.056 ms) : 2005, 2108
. : milestone, 2056,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.628 ms) : 3412, 3844
. : milestone, 3628,
iast (2.199 ms) : 2137, 2262
. : milestone, 2199,
iast_GLOBAL (2.247 ms) : 2183, 2310
. : milestone, 2247,
profiling (2.079 ms) : 2027, 2132
. : milestone, 2079,
tracing (2.009 ms) : 1961, 2058
. : milestone, 2009,
|
jandro996
approved these changes
Mar 28, 2025
smola
approved these changes
Apr 3, 2025
bc2bae0 to
5ec4ad6
Compare
5ec4ad6 to
4af7297
Compare
Contributor
|
This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it. |
Contributor
|
This pull request has been closed because it has not had activity over the past quarter. Feel free to reopen the PR if you are still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Sends separated telemetry payloads for V1/V2 custom events.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]