Skip to content

Commit

Permalink
[ci skip] elaborate on PHP 8.4 todo
Browse files Browse the repository at this point in the history
  • Loading branch information
morrisonlevi authored and realFlowControl committed Dec 22, 2023
1 parent 54ab679 commit 1b6cbc3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion profiling/src/php_ffi.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ static void ddog_php_prof_install_opcode_handlers(uint32_t php_version_id) {
zend_set_user_opcode_handler(ZEND_BIND_STATIC, dispatch_handler);
}
#if PHP_VERSION_ID >= 80400
#error Check if ZEND_BIND_STATIC needs an opcode handler still.
#error Check if ZEND_BIND_STATIC needs an opcode handler still. Possibly update things like CFG_NEED_OPCODE_HANDLERS as well.
#endif
}
#endif
Expand Down

0 comments on commit 1b6cbc3

Please sign in to comment.