Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lot of entries are missing in the .gitattributes files #2181

Closed
VincentLanglet opened this issue Jul 29, 2023 · 1 comment · Fixed by #2401
Closed

Lot of entries are missing in the .gitattributes files #2181

VincentLanglet opened this issue Jul 29, 2023 · 1 comment · Fixed by #2401

Comments

@VincentLanglet
Copy link

Hi @bwoebi, @morrisonlevi, @PROFeNoM, @labbati

The following file avoid to download non-necessary files/folder when installing the library with composer
https://github.com/DataDog/dd-trace-php/blob/master/.gitattributes

Currently, I get
image

I assume a lot of them could be added to the gitattributes file too:

  • .github/.gitlab folders and github-action-helpers
  • docs folder
  • example folder
  • all .* files
  • all .md files
  • docker-composer.yml, phpstan.neon, Makefile, etc
  • certainly some folder which I don't know what they are useful for (I currently only use the src one)

Would it be possible to add more entries to the gitattributes file ?
I'm ok doing the PR if needed, but I don't know which folder/files can be also added (other than the one I listed)

@pierotibou
Copy link
Collaborator

Hello, thanks for reporting this.
The issue auto closed when I merged #2401 as I've taken a first stab at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants