Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce noise in composer package download #2401

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

pierotibou
Copy link
Collaborator

Description

Update .gitattributes file to reduce the number of files and folder that are packaged when using composer.

Fixes #2181

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl
Copy link
Member

AFAIK this only affects composer, so we might also export-ignore the profiler directory and maybe even the ext directory? WDYT?

@PROFeNoM
Copy link
Contributor

PROFeNoM commented Dec 1, 2023

maybe even the ext directory?

Are we sure we're not removing stuff that might be used by someone (e.g., the stub files)

@pierotibou
Copy link
Collaborator Author

pierotibou commented Dec 1, 2023

WDYT?

Thanks @realFlowControl. I'm not entirely sure that's why I asked for 👀 . If we have any doubt I'd rather stay on the conservative side of things.

@pierotibou pierotibou changed the title Reduce noise in compoeser package download Reduce noise in composer package download Dec 1, 2023
@bwoebi
Copy link
Collaborator

bwoebi commented Jan 3, 2024

More precisely export-ignore affects what's downloaded when downloading the repository as a .tar.gz file directly from github via the built-in functionality.

And then affects composer indirectly through that. But given that it's broader than just composer, essentials to building the extensions should still stay.

@pierotibou pierotibou marked this pull request as ready for review January 3, 2024 11:58
@pierotibou pierotibou requested a review from a team as a code owner January 3, 2024 11:58
@bwoebi
Copy link
Collaborator

bwoebi commented Jan 3, 2024

I would also add tests there.

@pierotibou
Copy link
Collaborator Author

pierotibou commented Jan 3, 2024

I would also add tests there.

@bwoebi, indeed they are already in the original file

@bwoebi
Copy link
Collaborator

bwoebi commented Jan 3, 2024

Oh, it's not a new file, just added to it. Sorry :-)

@pierotibou pierotibou force-pushed the pierre/update-gitattr branch from a9eda66 to 83f0326 Compare January 3, 2024 12:20
@pierotibou pierotibou merged commit e997b97 into master Jan 3, 2024
521 of 522 checks passed
@pierotibou pierotibou deleted the pierre/update-gitattr branch January 3, 2024 15:43
@github-actions github-actions bot added this to the 0.97.0 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lot of entries are missing in the .gitattributes files
4 participants