Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http.route to CodeIgniter #2379

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Add http.route to CodeIgniter #2379

merged 5 commits into from
Dec 6, 2023

Conversation

pablomartinezbernardo
Copy link
Contributor

@pablomartinezbernardo pablomartinezbernardo commented Nov 21, 2023 •
edited by PROFeNoM
Loading

Description

Add http.route tag to CodeIgniter spans

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@pablomartinezbernardo pablomartinezbernardo marked this pull request as ready for review November 23, 2023 11:52
@pablomartinezbernardo pablomartinezbernardo requested a review from a team as a code owner November 23, 2023 11:52
PROFeNoM
PROFeNoM approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, considering the uri key is, as you mentioned, not stored nor returned 👍

@PROFeNoM PROFeNoM added this to the 0.95.0 milestone Nov 27, 2023
@PROFeNoM PROFeNoM merged commit d06b3fa into master Dec 6, 2023
2 checks passed
@PROFeNoM PROFeNoM deleted the codeigniter-http-route branch December 6, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PROFeNoM PROFeNoM PROFeNoM approved these changes

Assignees
No one assigned
Labels
cat:integration tracing
Projects
None yet
Milestone
0.95.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pablomartinezbernardo @PROFeNoM