[WIP - Experimental] feat: Add Span End Callback #2407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PROFeNoM
commented
Dec 8, 2023
Comment on lines
+29
to
+35
| private static function getRootSpan(SpanData $span): RootSpanData | ||
| { | ||
| while (!($span instanceof RootSpanData) && $span->parent) { | ||
| $span = $span->parent; | ||
| } | ||
| return $span; | ||
| } |
There was a problem hiding this comment.
Note to self: May be wrong when considering intertwined start_trace_span & OTel starts w/ setParent(false)
PROFeNoM
force-pushed
the
alex/experiments/otel-end-callback
branch
from
4d19b4f to
78fe75b
Compare
BenchmarksBenchmark execution time: 2024-01-10 15:04:34 Comparing candidate commit 78fe75b in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 37 metrics, 52 unstable metrics. scenario:PHPRedisBench/benchRedisBaseline
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Experimental
Leverage span end callback to end the OTel Span (if any) when a span is closed using the DD Api. This affects both OTel-created & remapped OTel spans. The goal is to fix edge cases + properly handle trace ids (See Tests Cases).
Sample Edge Case:
At present, there are issues with the third and fifth steps where the trace states are not being updated correctly in accordance with the OTel-API. Once these changes are made, the trace states can be dynamically retrieved and distributed context changes will accurately be reflected in the OTel API.
TODO:
Reviewer checklist