Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recommended json file #2425

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix recommended json file #2425

merged 1 commit into from
Dec 15, 2023

Conversation

estringana
Copy link
Contributor

@estringana estringana commented Dec 14, 2023 •
edited
Loading

Description

Move back to having the recommended.json file on the repo

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana marked this pull request as ready for review December 15, 2023 09:14
@estringana estringana requested review from a team as code owners December 15, 2023 09:14
realFlowControl
realFlowControl approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop Whoop 🎉

@estringana estringana force-pushed the estringana/fix-recommended-json branch from 808c903 to 45b807d Compare December 15, 2023 09:17
@estringana estringana force-pushed the estringana/fix-recommended-json branch from 45b807d to 9acfe05 Compare December 15, 2023 10:14
@estringana estringana merged commit a8e7c52 into master Dec 15, 2023
3 checks passed
@estringana estringana deleted the estringana/fix-recommended-json branch December 15, 2023 14:32
PROFeNoM pushed a commit that referenced this pull request Dec 15, 2023
@estringana @PROFeNoM
Fix recommended json file (#2425)
3ebfb26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realFlowControl realFlowControl realFlowControl approved these changes

@cataphract cataphract cataphract approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estringana @cataphract @realFlowControl