Move the dummy function of call_attribute_constructor onto the VM stack #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
added
the
c-extension
morrisonlevi
reviewed
Jan 2, 2024
bwoebi
force-pushed
the
bob/trampoline_zend_call_known_function
branch
from
338f674 to
6fc83d6
Compare
There was a problem hiding this comment.
I've gone through the assembly, and I'm pretty sure I understand it, and it "seems" correct.
I'm pretty nervous, though. There are a lot of assumptions here that seem like they could get violated depending on how their PHP was compiled.
Are the affected operating systems still not patching this? Which operating systems are affected? Maybe we should be pushing them to upgrade or pull in patches?
Consider this a soft-approval. If anyone like Pierre wants to take this approach, and they understand the risks here, then feel free, I won't block. I just question if there's an alternative.
bwoebi
force-pushed
the
bob/trampoline_zend_call_known_function
branch
from
6fc83d6 to
0c4943a
Compare
Signed-off-by: Bob Weinand <[email protected]>
bwoebi
force-pushed
the
bob/trampoline_zend_call_known_function
branch
from
0c4943a to
001ca15
Compare
r1viollet
reviewed
Jan 17, 2024
Signed-off-by: Bob Weinand <[email protected]>
PROFeNoM
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes possible crashes on old versions by ensuring that attribute constructor dummy functions are always on the VM stack.
(essentially works around https://bugs.php.net/bug.php?id=81430, which happens to crash more often for users now, given that Symfony started using PHP attributes.)
Reviewer checklist