-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiling) PHP ZTS support for CPU- and walltime profiling #2470
Conversation
0404dda
to
3cf6f6a
Compare
87b13fb
to
4b3d700
Compare
cb0b81d
to
e6b800d
Compare
e6b800d
to
0e8571c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2470 +/- ##
============================================
+ Coverage 76.53% 78.61% +2.07%
+ Complexity 267 216 -51
============================================
Files 136 105 -31
Lines 17526 12936 -4590
Branches 1020 0 -1020
============================================
- Hits 13413 10169 -3244
+ Misses 3580 2767 -813
+ Partials 533 0 -533
Flags with carried forward coverage won't be shown. Click here to find out more. see 59 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
846f15f
to
55e275d
Compare
3184c0b
to
078468e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to manually check:
- Does
datadog-setup.php
need any changes? Based on how it detects support, it should Just Work but we may need to change comments or output or something. - Have you checked Apache in the worker modes that support threading? I'd also double-check
apachectl graceful
.
Aside from these manual testing concerns, it looks fine to me.
Description
This PR will:
PROF-8921
#2070
Reviewer checklist