Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fibers on PHP 8.1.2 #2473

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix fibers on PHP 8.1.2 #2473

merged 1 commit into from
Jan 16, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Jan 15, 2024 •
edited
Loading

Description

Missing indirection. Sadly PHP < 8.1.3, hence no tests.

Fixes #2471.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@bwoebi
Fix fibers on PHP 8.1.2
cc0141a 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi requested a review from a team as a code owner January 15, 2024 18:07
@bwoebi bwoebi mentioned this pull request Jan 15, 2024
Closed
@bwoebi bwoebi merged commit 756e25a into master Jan 16, 2024
572 of 577 checks passed
@bwoebi bwoebi deleted the bob/fix-fiber-8.1.2 branch January 16, 2024 10:43
@github-actions github-actions bot added this to the 0.97.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PROFeNoM PROFeNoM PROFeNoM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.97.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Segmentation fault when using fibers in php 8.1
2 participants
@bwoebi @PROFeNoM