No longer compile the mockgen as part of the rust build #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/separate-mockgen-compile
branch
2 times, most recently
from
8180bef to
f121e27
Compare
PROFeNoM
approved these changes
Feb 13, 2024
Instead we run a separate rust executable to produce it, and it will be included as a normal .c file in the ddtrace C build This will allow us to compile the sidecar once for all versions as well as have the debug symbols for the sidecar just once Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Export full debug symbols of sidecar (for a 50% artifact siye overhead, instead of 500%) Signed-off-by: Bob Weinand <[email protected]>
bwoebi
force-pushed
the
bob/separate-mockgen-compile
branch
from
f775f4c to
6061c32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead we run a separate rust executable to produce it, and it will be included as a normal .c file in the ddtrace C build
This will allow us to compile the sidecar once for all versions in CI.
Also remove stripping debug symbols in favor of compressing them. This has "only" 50% binary size overhead, which is acceptable, I think.
Reviewer checklist