Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(profiling): fix accidentally skipped tests #2517

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Feb 15, 2024

Description

Two tests have been skipped due to an "Experimental" check for features that are not experimental anymore.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl marked this pull request as ready for review February 15, 2024 07:37
@realFlowControl realFlowControl requested a review from a team as a code owner February 15, 2024 07:37
@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Feb 15, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 15, 2024

Benchmarks

Benchmark execution time: 2024-02-15 07:44:13

Comparing candidate commit 3b2152a in PR branch florian/fix-skipped-tests with baseline commit d8a8624 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 3 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Merging #2517 (3b2152a) into master (d8a8624) will increase coverage by 2.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2517      +/-   ##
============================================
+ Coverage     76.61%   78.65%   +2.04%     
  Complexity      267      267              
============================================
  Files           136      110      -26     
  Lines         17537    13376    -4161     
  Branches       1020        0    -1020     
============================================
- Hits          13436    10521    -2915     
+ Misses         3568     2855     -713     
+ Partials        533        0     -533     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.60% <ø> (ø)
tracer-integrations 79.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a8624...3b2152a. Read the comment docs.

Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@morrisonlevi morrisonlevi changed the title ci(profiling) fix skipped tests test(profiling): fix accidentally skipped tests Feb 15, 2024
@morrisonlevi morrisonlevi merged commit 39eb121 into master Feb 15, 2024
557 of 562 checks passed
@morrisonlevi morrisonlevi deleted the florian/fix-skipped-tests branch February 15, 2024 16:41
@github-actions github-actions bot added this to the 0.98.0 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants