Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakiness: Always Delete and Create the socket #2518

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Feb 16, 2024

Description

Succeded five times in a row, so I think that should be better with this change :)
image

image

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Feb 16, 2024
@PROFeNoM PROFeNoM force-pushed the alex/flaky/socket_agent branch from e5451f7 to b58d3fd Compare February 16, 2024 12:52
@pr-commenter
Copy link

pr-commenter bot commented Feb 16, 2024

Benchmarks

Benchmark execution time: 2024-02-16 14:37:53

Comparing candidate commit b58d3fd in PR branch alex/flaky/socket_agent with baseline commit 346de4d in branch master.

Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥
Check Gitlab CI job log to find if any benchmark has crashed.

Scenarios present only in baseline:

  • BM_TeaSapiSpinup
  • BM_TeaSapiSpindown

Found 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 50 unstable metrics.

@PROFeNoM PROFeNoM marked this pull request as ready for review February 19, 2024 08:03
@PROFeNoM PROFeNoM requested a review from a team as a code owner February 19, 2024 08:03
@PROFeNoM PROFeNoM merged commit 75f088e into master Feb 19, 2024
527 of 530 checks passed
@PROFeNoM PROFeNoM deleted the alex/flaky/socket_agent branch February 19, 2024 08:03
@github-actions github-actions bot added this to the 0.98.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants