Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate numbers and bools in tags and metrics for sampling rules #2521

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Evaluate numbers and bools in tags and metrics for sampling rules #2521

merged 1 commit into from
Feb 19, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Feb 19, 2024

Description

Also making glob patterns case insensitive.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@bwoebi bwoebi requested a review from a team as a code owner February 19, 2024 12:24
PROFeNoM
PROFeNoM approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, the test was indeed broken 🙃

@bwoebi bwoebi merged commit 3179be0 into master Feb 19, 2024
590 of 594 checks passed
@bwoebi bwoebi deleted the bob/metrics-number-bool-sampling branch February 19, 2024 13:27
@github-actions github-actions bot added this to the 0.98.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PROFeNoM PROFeNoM PROFeNoM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.98.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bwoebi @PROFeNoM