-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FrankenPHP to the list of recognised/supported SAPIs #2523
Conversation
BenchmarksBenchmark execution time: 2024-03-01 10:55:50 Comparing candidate commit ac127a6 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 181 metrics, 0 unstable metrics. scenario:TraceSerializationBench/benchSerializeTrace
|
e7aa320
to
4207bfb
Compare
6f70cc9
to
022f639
Compare
If we're going to support frankenphp in the profiler, the tracer probably should too. I think it's not too different from other sapis, so probably the tracer should just support it out of the box once added to components/sapi/sapi.c and dd_is_compatible_sapi in ddtrace.c. |
2c50c50
to
0841bd4
Compare
Signed-off-by: Bob Weinand <[email protected]>
9bfadaa
to
60b8ded
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2523 +/- ##
============================================
+ Coverage 76.55% 78.74% +2.18%
Complexity 267 267
============================================
Files 138 112 -26
Lines 17457 13486 -3971
Branches 976 0 -976
============================================
- Hits 13364 10619 -2745
+ Misses 3573 2867 -706
+ Partials 520 0 -520
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Levi Morrison <[email protected]>
Description
PROF-9184 / #2070
This PR aimes to add support for FrankenPHP SAPI, now that ZTS support exists. In detail this means:
frankenphp_handle_request()
(worker mode) to the idle times in timeline (analogue torshutdown
->rinit
in PHP-FPM)Note: Screenshot is from the FrankenPHP Symfony Demo application in the reliability environment using worker mode
Reviewer checklist