-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DD_API_SECURITY_ENABLED flag #2532
Conversation
4a7d2d3
to
1e69c13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample rate should not be removed, the new variable should be present in addition to the sample rate.
Done |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2532 +/- ##
============================================
- Coverage 78.75% 76.56% -2.19%
Complexity 267 267
============================================
Files 112 138 +26
Lines 13482 17454 +3972
Branches 0 976 +976
============================================
+ Hits 10618 13364 +2746
- Misses 2864 3570 +706
- Partials 0 520 +520
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Reviewer checklist