fix(benchmarks): Ensure OPCache is used in cgi-fcgi web servers #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-02-26 12:39:46 Comparing candidate commit 386c9c8 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 181 metrics, 0 unstable metrics. scenario:TraceSerializationBench/benchSerializeTrace
|
bwoebi
reviewed
Feb 26, 2024
Co-authored-by: Bob Weinand <[email protected]>
bwoebi
approved these changes
Feb 26, 2024
bwoebi
pushed a commit
that referenced
this pull request
Mar 20, 2024
* fix(benchmarks): Ensure OPCache is used in cgi-fcgi web servers * Use zend_extension=opcache.so instead * Check if Zend OpCache is loaded Co-authored-by: Bob Weinand <[email protected]> * Remove unused env var --------- Co-authored-by: Bob Weinand <[email protected]> (cherry picked from commit 380774d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I somehow messed up something while rebasing/force-pushing in #2531... This PR adds the "and ensure opcache is used" part.
Reviewer checklist