Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use faster bincode for ipc #2544

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Use faster bincode for ipc #2544

merged 1 commit into from
Mar 4, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Feb 28, 2024

Description

Should bring a considerable speedup by not using json, which is comparatively slower.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@bwoebi bwoebi force-pushed the bob/ipc-bincode branch 2 times, most recently from 708207e to 353aedb Compare February 28, 2024 18:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Merging #2544 (353aedb) into master (552b0ef) will increase coverage by 2.18%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2544      +/-   ##
============================================
+ Coverage     76.55%   78.73%   +2.18%     
  Complexity      267      267              
============================================
  Files           138      112      -26     
  Lines         17457    13485    -3972     
  Branches        976        0     -976     
============================================
- Hits          13364    10618    -2746     
+ Misses         3573     2867     -706     
+ Partials        520        0     -520     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.69% <ø> (ø)
tracer-integrations 79.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552b0ef...353aedb. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2024

Benchmarks

Benchmark execution time: 2024-03-04 10:26:47

Comparing candidate commit 4486d06 in PR branch bob/ipc-bincode with baseline commit 552b0ef in branch master.

Found 9 performance improvements and 6 performance regressions! Performance is the same for 163 metrics, 4 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟩 execution_time [-171.160µs; -143.640µs] or [-4.214%; -3.536%]

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-176.700µs; -145.100µs] or [-4.328%; -3.554%]

scenario:ContextPropagationBench/benchInject64Bit

  • 🟩 execution_time [-403.048ns; -172.952ns] or [-5.585%; -2.396%]

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟩 execution_time [-522.268µs; -367.712µs] or [-18.640%; -13.124%]

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

  • 🟩 execution_time [-566.094µs; -391.426µs] or [-19.335%; -13.369%]

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟥 execution_time [+1.565ms; +1.629ms] or [+102.922%; +107.123%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟥 execution_time [+1.558ms; +1.626ms] or [+94.745%; +98.893%]

scenario:LaravelBench/benchLaravelBaseline

  • 🟩 execution_time [-483.231µs; -300.689µs] or [-16.486%; -10.259%]

scenario:LaravelBench/benchLaravelBaseline-opcache

  • 🟩 execution_time [-412.302µs; -251.798µs] or [-13.594%; -8.302%]

scenario:LaravelBench/benchLaravelOverhead

  • 🟥 execution_time [+1.682ms; +1.791ms] or [+110.661%; +117.796%]

scenario:LaravelBench/benchLaravelOverhead-opcache

  • 🟥 execution_time [+1.720ms; +1.797ms] or [+104.399%; +109.082%]

scenario:SymfonyBench/benchSymfonyBaseline

  • 🟩 execution_time [-656.328µs; -565.852µs] or [-6.187%; -5.334%]

scenario:SymfonyBench/benchSymfonyBaseline-opcache

  • 🟩 execution_time [-588.931µs; -500.389µs] or [-5.515%; -4.686%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟥 execution_time [+9.866ms; +9.916ms] or [+650.648%; +653.915%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟥 execution_time [+9.865ms; +9.980ms] or [+594.255%; +601.210%]

@bwoebi bwoebi marked this pull request as ready for review March 1, 2024 11:27
@bwoebi bwoebi requested review from a team as code owners March 1, 2024 11:27
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi force-pushed the bob/ipc-bincode branch from a8d40e8 to 4486d06 Compare March 4, 2024 09:25
Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the macrobenchmarks, there doesn't seem to be any macro impact on real-world web apps.

@bwoebi bwoebi merged commit 0a86e15 into master Mar 4, 2024
542 of 544 checks passed
@bwoebi bwoebi deleted the bob/ipc-bincode branch March 4, 2024 12:10
@github-actions github-actions bot added this to the 0.99.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants