-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use faster bincode for ipc #2544
Conversation
708207e
to
353aedb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2544 +/- ##
============================================
+ Coverage 76.55% 78.73% +2.18%
Complexity 267 267
============================================
Files 138 112 -26
Lines 17457 13485 -3972
Branches 976 0 -976
============================================
- Hits 13364 10618 -2746
+ Misses 3573 2867 -706
+ Partials 520 0 -520
Flags with carried forward coverage won't be shown. Click here to find out more. see 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
353aedb
to
a8d40e8
Compare
BenchmarksBenchmark execution time: 2024-03-04 10:26:47 Comparing candidate commit 4486d06 in PR branch Found 9 performance improvements and 6 performance regressions! Performance is the same for 163 metrics, 4 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
scenario:ContextPropagationBench/benchInject64Bit
scenario:EmptyFileBench/benchEmptyFileBaseline
scenario:EmptyFileBench/benchEmptyFileBaseline-opcache
scenario:EmptyFileBench/benchEmptyFileOverhead
scenario:EmptyFileBench/benchEmptyFileOverhead-opcache
scenario:LaravelBench/benchLaravelBaseline
scenario:LaravelBench/benchLaravelBaseline-opcache
scenario:LaravelBench/benchLaravelOverhead
scenario:LaravelBench/benchLaravelOverhead-opcache
scenario:SymfonyBench/benchSymfonyBaseline
scenario:SymfonyBench/benchSymfonyBaseline-opcache
scenario:SymfonyBench/benchSymfonyOverhead
scenario:SymfonyBench/benchSymfonyOverhead-opcache
|
Signed-off-by: Bob Weinand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the macrobenchmarks, there doesn't seem to be any macro impact on real-world web apps.
Description
Should bring a considerable speedup by not using json, which is comparatively slower.
Reviewer checklist