Fix possible crash in dd_patched_zend_call_known_function

[bwoebi]

Description

Fixes #2547.

Null-checks can be sometimes important.

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[codecov-commenter]

Codecov Report

Merging #2548 (74a41f0) into master (552b0ef) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2548      +/-   ##
============================================
- Coverage     76.55%   76.54%   -0.01%     
  Complexity      267      267              
============================================
  Files           138      138              
  Lines         17457    17458       +1     
  Branches        976      976              
============================================
  Hits          13364    13364              
- Misses         3573     3574       +1     
  Partials        520      520              

Flag	Coverage Δ
appsec-extension	69.13% <ø> (ø)
tracer-extension	78.68% <0.00%> (-0.01%)	⬇️
tracer-integrations	79.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
ext/ddtrace.c	73.01% <0.00%> (ø)
zend_abstract_interface/hook/hook.c	55.00% <0.00%> (-0.08%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552b0ef...74a41f0. Read the comment docs.

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-03-02 00:07:00

Comparing candidate commit 5d9dea7 in PR branch bob/fix-execute-data with baseline commit 552b0ef in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 181 metrics, 0 unstable metrics.

scenario:TraceSerializationBench/benchSerializeTrace

• 🟥 execution_time [+4.513µs; +7.187µs] or [+2.436%; +3.878%]

[PROFeNoM]

Is this easily reproducible/Can we easily do a regression for this crash?

[bwoebi]

Yes, it's easily reproducible. But it's a 8.1.2 specific change...

[morrisonlevi]

Null pointers, man 🤦🏻‍♂️

[rokclimb15]

@bwoebi I wonder if this addresses #1734

[bwoebi]

@rokclimb15 Yes, that issue should actually be fixed :-)

And note that 0.98.1 has been released now with this fix too.