Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect agent info and apply the env for remote config #2930

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Nov 6, 2024

It basically sets the datadog.env INI at runtime (at a couple important locations - at start and once when actually sampling).

This ensures agent sampling is correct, and RC targets the right env.

@bwoebi bwoebi requested review from a team as code owners November 6, 2024 15:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.16%. Comparing base (e2b0a15) to head (074196b).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2930      +/-   ##
============================================
- Coverage     73.62%   72.16%   -1.46%     
  Complexity     2529     2529              
============================================
  Files           109      136      +27     
  Lines         10410    14452    +4042     
  Branches          0      991     +991     
============================================
+ Hits           7664    10429    +2765     
- Misses         2746     3477     +731     
- Partials          0      546     +546     
Flag Coverage Δ
appsec-extension 68.40% <ø> (?)
tracer-php 73.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b0a15...074196b. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-14 22:42:41

Comparing candidate commit 074196b in PR branch agent-info with baseline commit e2b0a15 in branch master.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟩 execution_time [-225.145µs; -115.355µs] or [-6.827%; -3.498%]

scenario:SamplingRuleMatchingBench/benchGlobMatching2

  • 🟥 execution_time [+57.696ns; +148.904ns] or [+2.602%; +6.716%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi merged commit b9cdb0a into master Nov 15, 2024
14 of 17 checks passed
@bwoebi bwoebi deleted the agent-info branch November 15, 2024 16:31
@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing area:asm labels Nov 15, 2024
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:asm profiling Relates to the Continuous Profiler tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants