-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect agent info and apply the env for remote config #2930
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2930 +/- ##
============================================
- Coverage 73.62% 72.16% -1.46%
Complexity 2529 2529
============================================
Files 109 136 +27
Lines 10410 14452 +4042
Branches 0 991 +991
============================================
+ Hits 7664 10429 +2765
- Misses 2746 3477 +731
- Partials 0 546 +546
Flags with carried forward coverage won't be shown. Click here to find out more. see 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Bob Weinand <[email protected]>
Benchmarks [ tracer ]Benchmark execution time: 2024-11-14 22:42:41 Comparing candidate commit 074196b in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics. scenario:EmptyFileBench/benchEmptyFileOverhead
scenario:SamplingRuleMatchingBench/benchGlobMatching2
scenario:TraceFlushBench/benchFlushTrace
|
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
It basically sets the datadog.env INI at runtime (at a couple important locations - at start and once when actually sampling).
This ensures agent sampling is correct, and RC targets the right env.