Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully disable the sidecar on lambda by setting all related configs to false #2948

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Nov 13, 2024

It doesn't work properly there, so just disable it until we fix it.

This effectively disabled appsec remote config too, but it's what we got, and lambda is currently rather best-effort support.

… false

It doesn't work properly there, so just disable it until we fix it.

Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi requested review from a team as code owners November 13, 2024 15:28
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.15%. Comparing base (e2b0a15) to head (a8c8ea5).

Files with missing lines Patch % Lines
appsec/src/extension/configuration.c 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2948      +/-   ##
============================================
- Coverage     73.62%   72.15%   -1.47%     
  Complexity     2529     2529              
============================================
  Files           109      136      +27     
  Lines         10410    14454    +4044     
  Branches          0      992     +992     
============================================
+ Hits           7664    10429    +2765     
- Misses         2746     3478     +732     
- Partials          0      547     +547     
Flag Coverage Δ
appsec-extension 68.37% <0.00%> (?)
tracer-php 73.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/src/extension/configuration.c 61.38% <0.00%> (ø)

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b0a15...a8c8ea5. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-13 15:47:55

Comparing candidate commit a8c8ea5 in PR branch bob/fully-disable-sidecar-lambda with baseline commit e2b0a15 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:TraceFlushBench/benchFlushTrace

  • 🟥 execution_time [+1000.000ns; +1000.000ns] or [+100.000%; +100.000%]

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks [ appsec ]

Benchmark execution time: 2024-11-13 15:57:10

Comparing candidate commit a8c8ea5 in PR branch bob/fully-disable-sidecar-lambda with baseline commit e2b0a15 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@bwoebi bwoebi merged commit ea58159 into master Nov 15, 2024
720 of 745 checks passed
@bwoebi bwoebi deleted the bob/fully-disable-sidecar-lambda branch November 15, 2024 16:22
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants