Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loader] Assign an appropriate tag to each type of error #2985

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Dec 5, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc requested a review from a team as a code owner December 5, 2024 10:52
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.72%. Comparing base (34baa56) to head (1858e85).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (34baa56) and HEAD (1858e85). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (34baa56) HEAD (1858e85)
tracer-php 11 10
appsec-extension 1 0
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2985       +/-   ##
=============================================
- Coverage     73.12%   51.72%   -21.40%     
  Complexity     2741     2741               
=============================================
  Files           137      110       -27     
  Lines         14907    10863     -4044     
  Branches        992        0      -992     
=============================================
- Hits          10900     5619     -5281     
- Misses         3462     5244     +1782     
+ Partials        545        0      -545     
Flag Coverage Δ
appsec-extension ?
tracer-php 51.72% <ø> (-23.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 48 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34baa56...1858e85. Read the comment docs.

Copy link
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart from one nitpick.

loader/dd_library_loader.c Show resolved Hide resolved
loader/dd_library_loader.c Show resolved Hide resolved
Co-authored-by: Florian Engelhardt <[email protected]>
@iamluc iamluc merged commit b928df9 into master Dec 10, 2024
667 of 693 checks passed
@iamluc iamluc deleted the luc/loader-improve-telemetry branch December 10, 2024 10:02
@github-actions github-actions bot added this to the 1.6.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants