Skip to content

ci(profiling) add ZTS ASAN runs to CI #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/prof_asan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ jobs:
strategy:
matrix:
php-version: [8.3, 8.4]
phpts: [nts, zts]
container:
image: datadog/dd-trace-ci:php-${{matrix.php-version}}_bookworm-5
# https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions#user
Expand All @@ -30,12 +31,12 @@ jobs:
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
key: ${{ runner.os }}-cargo-asan-${{ hashFiles('**/Cargo.lock') }}
key: ${{ runner.os }}-cargo-asan-${{ hashFiles('**/Cargo.lock') }}-${{ matrix.phpts }}

- name: Build and install profiler
run: |
set -eux
switch-php nts-asan
switch-php ${{ matrix.phpts }}-asan
rm $(php-config --ini-dir)/sqlsrv.ini #sqlsrv leaks memory and triggers asan
cd profiling
export CARGO_TARGET_DIR=/tmp/build-cargo
Expand All @@ -57,12 +58,12 @@ jobs:
~/.cargo/registry/cache/
~/.cargo/git/db/
/tmp/build-cargo/
key: ${{ runner.os }}-cargo-asan-${{ hashFiles('**/Cargo.lock') }}
key: ${{ runner.os }}-cargo-asan-${{ hashFiles('**/Cargo.lock') }}-${{ matrix.phpts }}

- name: Run phpt tests
run: |
set -eux
switch-php nts-asan
switch-php ${{ matrix.phpts }}-asan
cd profiling/tests
cp -v $(php-config --prefix)/lib/php/build/run-tests.php .
export DD_PROFILING_OUTPUT_PPROF=/tmp/pprof
Expand Down
Loading