fix(profiling) invalid unicode handling in timeline #2988
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2988 +/- ##
=========================================
Coverage 72.90% 72.90%
Complexity 2741 2741
=========================================
Files 137 137
Lines 14978 14978
Branches 1016 1016
=========================================
Hits 10920 10920
Misses 3506 3506
Partials 552 552
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Benchmarks [ profiler ]Benchmark execution time: 2024-12-11 09:09:44 Comparing candidate commit d8dea67 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 6 unstable metrics. |
realFlowControl
force-pushed
the
florian/fix-unicode
branch
from
7c7d896 to
d988b36
Compare
| /// Converts the `const char *` into a `zai_str`. A None as well as empty | ||
| /// strings will be converted into a string view to a static empty string | ||
| /// (single byte of null, len of 0). | ||
| pub fn zai_str_from_cstr(cstr: *const c_char) -> zai_str<'static>; |
There was a problem hiding this comment.
The <'static> lifetime might be a lie 😞
realFlowControl
force-pushed
the
florian/fix-unicode
branch
from
d988b36 to
fdc11a7
Compare
realFlowControl
force-pushed
the
florian/fix-unicode
branch
from
fdc11a7 to
d8dea67
Compare
Benchmarks [ tracer ]Benchmark execution time: 2024-12-11 09:28:54 Comparing candidate commit d8dea67 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics. scenario:TraceFlushBench/benchFlushTrace
scenario:TraceSerializationBench/benchSerializeTrace
|
|
Superseded by #2990 |
Description
Fixes handling of invalid unicode for errors in timeline
Reviewer checklist