Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] Workaround for boost download issues #3018

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

Anilm3
Copy link
Contributor

@Anilm3 Anilm3 commented Jan 6, 2025

Description

For some unclear reason, hunter fails to download boost using the predefined URLs pointing to jfrog artifactory. There doesn't seem to be a mechanism to override the default URL used to download a package, consequently the change involves replacing the predefined URLs with a working one directly modifying the relevant cmake file before it's used by hunter.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@Anilm3 Anilm3 marked this pull request as ready for review January 6, 2025 17:21
@Anilm3 Anilm3 requested a review from a team as a code owner January 6, 2025 17:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.68%. Comparing base (205c6d8) to head (6ae5397).

❗ There is a different number of reports uploaded between BASE (205c6d8) and HEAD (6ae5397). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (205c6d8) HEAD (6ae5397)
tracer-php 11 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3018       +/-   ##
=============================================
- Coverage     74.80%   40.68%   -34.12%     
+ Complexity     2781     2776        -5     
=============================================
  Files           112      139       +27     
  Lines         11017    15161     +4144     
  Branches          0     1022     +1022     
=============================================
- Hits           8241     6169     -2072     
- Misses         2776     8440     +5664     
- Partials          0      552      +552     
Flag Coverage Δ
appsec-extension 67.99% <ø> (?)
tracer-php 30.40% <ø> (-44.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 96 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205c6d8...6ae5397. Read the comment docs.

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite the hack, but if it works, it works :-D

@Anilm3 Anilm3 merged commit d25f2cc into master Jan 6, 2025
689 of 725 checks passed
@Anilm3 Anilm3 deleted the anilm3/boost-hunter-hack branch January 6, 2025 18:36
@github-actions github-actions bot added this to the 1.6.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants