chore: update latest versions #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3065 +/- ##
============================================
+ Coverage 72.97% 74.76% +1.79%
Complexity 2790 2790
============================================
Files 139 112 -27
Lines 15273 11039 -4234
Branches 1043 0 -1043
============================================
- Hits 11145 8253 -2892
+ Misses 3577 2786 -791
+ Partials 551 0 -551
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PROFeNoM
requested changes
Feb 3, 2025
PROFeNoM
reviewed
Feb 3, 2025
| @@ -166,7 +166,7 @@ public function testPredisClusterConnect() | |||
| $connectionString = "tcp://{$this->host}"; | |||
|
|
|||
| $traces = $this->isolateTracer(function () use ($connectionString) { | |||
| $client = new \Predis\Client([$connectionString, $connectionString, $connectionString]); | |||
| $client = new \Predis\Client([$connectionString, $connectionString, $connectionString], ['cluster' => 'redis']); | |||
There was a problem hiding this comment.
For legacy:
There was 1 error:
1) DDTrace\Tests\Integrations\Predis\Latest\PredisTest::testPredisClusterConnect
InvalidArgumentException: Array of connection parameters requires `cluster`, `replication` or `aggregate` client option
/home/circleci/datadog/tests/Integrations/Predis/Latest/vendor/predis/predis/src/Client.php:141
/home/circleci/datadog/tests/Integrations/Predis/Latest/vendor/predis/predis/src/Client.php:74
/home/circleci/datadog/tests/Integrations/Predis/Latest/PredisTest.php:169
/home/circleci/datadog/tests/Common/TracerTestTrait.php:65
/home/circleci/datadog/tests/Integrations/Predis/Latest/PredisTest.php:171
2 tasks
PROFeNoM
approved these changes
Feb 4, 2025
bwoebi
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the latest pinned versions of the test dependencies.