Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file based configuration (library-config) #3068

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Feb 4, 2025

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.99%. Comparing base (f157156) to head (bc0d8ce).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3068      +/-   ##
============================================
- Coverage     74.76%   72.99%   -1.78%     
  Complexity     2790     2790              
============================================
  Files           112      139      +27     
  Lines         11039    15273    +4234     
  Branches          0     1043    +1043     
============================================
+ Hits           8253    11148    +2895     
- Misses         2786     3574     +788     
- Partials          0      551     +551     
Flag Coverage Δ
appsec-extension 68.37% <ø> (?)
tracer-php 74.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f157156...bc0d8ce. Read the comment docs.

@iamluc iamluc force-pushed the luc/library-config branch from ea8a355 to bc0d8ce Compare February 5, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants