Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fork handling of sidecar #3077

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix fork handling of sidecar #3077

wants to merge 7 commits into from

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Feb 7, 2025

Also reduces flakiness of some tests a bit.
This also resolves broken pcntl tests on 8.3 and 8.4.

Signed-off-by: Bob Weinand <[email protected]>
And add a few more log lines
Also fix some ordering assumptions around unrwap().

Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi requested review from a team as code owners February 7, 2025 15:36
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.07%. Comparing base (c11372f) to head (ce361a9).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3077      +/-   ##
============================================
+ Coverage     72.97%   73.07%   +0.09%     
  Complexity     2790     2790              
============================================
  Files           139      139              
  Lines         15273    15273              
  Branches       1043     1043              
============================================
+ Hits          11145    11160      +15     
+ Misses         3577     3562      -15     
  Partials        551      551              
Flag Coverage Δ
appsec-extension 68.37% <ø> (ø)
tracer-php 74.87% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11372f...ce361a9. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-02-07 16:07:29

Comparing candidate commit ce361a9 in PR branch bob/flaky with baseline commit c11372f in branch master.

Found 34 performance improvements and 0 performance regressions! Performance is the same for 144 metrics, 0 unstable metrics.

scenario:ContextPropagationBench/benchInject64Bit

  • 🟩 execution_time [-6.276µs; -6.016µs] or [-79.488%; -76.186%]

scenario:ContextPropagationBench/benchInject64Bit-opcache

  • 🟩 execution_time [-6.268µs; -6.068µs] or [-79.258%; -76.736%]

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟩 execution_time [-742.895µs; -511.025µs] or [-20.199%; -13.894%]

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

  • 🟩 execution_time [-762.166µs; -508.614µs] or [-20.211%; -13.487%]

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟩 execution_time [-810.000µs; -623.540µs] or [-19.734%; -15.191%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟩 execution_time [-627.017µs; -441.943µs] or [-15.028%; -10.592%]

scenario:LaravelBench/benchLaravelBaseline

  • 🟩 execution_time [-575.414µs; -379.286µs] or [-5.187%; -3.419%]

scenario:LaravelBench/benchLaravelBaseline-opcache

  • 🟩 execution_time [-672.225µs; -447.355µs] or [-5.972%; -3.974%]

scenario:LaravelBench/benchLaravelOverhead

  • 🟩 execution_time [-1.873ms; -1.583ms] or [-14.054%; -11.879%]

scenario:LaravelBench/benchLaravelOverhead-opcache

  • 🟩 execution_time [-1.908ms; -1.515ms] or [-14.193%; -11.269%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟩 execution_time [-49.246µs; -31.570µs] or [-4.285%; -2.747%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟩 execution_time [-58.548µs; -38.059µs] or [-5.054%; -3.285%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟩 execution_time [-55.896µs; -42.700µs] or [-4.749%; -3.628%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟩 execution_time [-83.724µs; -68.472µs] or [-5.124%; -4.191%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

  • 🟩 execution_time [-74.502µs; -53.502µs] or [-4.501%; -3.232%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟩 execution_time [-6.294µs; -6.128µs] or [-86.735%; -84.451%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1-opcache

  • 🟩 execution_time [-6.212µs; -6.002µs] or [-85.272%; -82.388%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟩 execution_time [-6.279µs; -6.041µs] or [-86.908%; -83.608%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2-opcache

  • 🟩 execution_time [-6.242µs; -5.990µs] or [-84.681%; -81.256%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟩 execution_time [-6.267µs; -6.074µs] or [-86.705%; -84.029%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

  • 🟩 execution_time [-6.127µs; -5.963µs] or [-84.692%; -82.420%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟩 execution_time [-6.244µs; -6.058µs] or [-86.654%; -84.079%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

  • 🟩 execution_time [-6.169µs; -5.955µs] or [-85.167%; -82.207%]

scenario:SpanBench/benchDatadogAPI

  • 🟩 execution_time [-19.668µs; -15.241µs] or [-13.188%; -10.219%]

scenario:SpanBench/benchDatadogAPI-opcache

  • 🟩 execution_time [-17.514µs; -16.662µs] or [-11.750%; -11.178%]

scenario:SpanBench/benchOpenTelemetryInteroperability

  • 🟩 execution_time [-92.573µs; -86.985µs] or [-26.124%; -24.547%]

scenario:SpanBench/benchOpenTelemetryInteroperability-opcache

  • 🟩 execution_time [-91.932µs; -85.718µs] or [-27.266%; -25.423%]

scenario:SymfonyBench/benchSymfonyBaseline

  • 🟩 execution_time [-558.964µs; -469.176µs] or [-8.005%; -6.719%]

scenario:SymfonyBench/benchSymfonyBaseline-opcache

  • 🟩 execution_time [-597.910µs; -455.290µs] or [-8.401%; -6.397%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟩 execution_time [-1.169ms; -1.081ms] or [-14.063%; -13.002%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟩 execution_time [-1.139ms; -1.031ms] or [-13.577%; -12.298%]

scenario:WordPressBench/benchWordPressBaseline-opcache

  • 🟩 execution_time [-741.067µs; -531.453µs] or [-3.162%; -2.268%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟩 execution_time [-6.680ms; -6.453ms] or [-19.680%; -19.011%]

scenario:WordPressBench/benchWordPressOverhead-opcache

  • 🟩 execution_time [-6.599ms; -6.401ms] or [-19.401%; -18.818%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants