fix(prof): use cached heap in alloc_prof_orig_* functions
#3547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A crash report ...
... indicated that
_zend_mm_allocwas being called with an invalid heap pointer. This invalid pointer originated from the call tozend::zend_mm_get_heap()withinalloc_prof_orig_allocwhich is weird and can only mean that "something" changed the current heap viazend_mm_set_heap()after we installed our hooks inRINITto something invalid, but I could not find any other extension that are known for these kind of things in the crash report.So: In the end it is the right thing to call the heap that we registered with.
Reviewer checklist