Repository navigation
ci: move PHP language test telemetry to 7.4 and 8.5 - #4309
morrisonlevi wants to merge 1 commit into
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: cf76264 | Docs | View more details | Give us feedback! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Generated CI configuration enables telemetry only for PHP 7.4 and 8.5, both using parallel runners, and applies a 40-minute timeout to every language-test job. No actionable defect was identified.
🤖 Bits Code Review · Commit 7de1932
Benchmarks [ tracer ]Benchmark execution time: 2026-10-13 16:47:59 Comparing candidate commit 7de1932 in PR branch Found 4 performance improvements and 1 performance regressions! Performance is the same for 189 metrics, 0 unstable metrics.
|
941c1f2 to
cf76264
Compare
Description
The PHP 7.0 and 7.1 language tests are the only ones with telemetry enabled for cost reasons. However these are also the slowest and regularly time out. PHP 7.1 for instance fails roughly 1/3 of the time and half of those are clearly marked timeouts.
So the hope is to move 7.0/7.1 into the same runtime range as 7.2/7.3 and then slow down 8.4 and 8.5 to pay the telemetry perf tax, since they average 6-7 minutes. We also set
DD_SERVICEandDD_VERSIONnow.If these jobs start timing out, that's strong evidence that telemetry is at fault. PHP 7.4 and 8.5 language tests have not had any timeouts in the past week.
Preliminary runtimes for 7.4/8.5 is that they roughly double. Locally, I can't reproduce it. It may be that writing logs is slower in CI for some reason, and they have significantly higher log volumes with telemetry enabled. This should be investigated but it's not directly blocking this PR (we had this same problem on PHP 7.0/7.1, I'm just shifting it to 7.4/8.5).
Reviewer checklist