-
Notifications
You must be signed in to change notification settings - Fork 439
chore: introduce APM_TRACING RC product #11980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 50.35s Total duration (35m 10.03s time saved) |
6367ef6
to
13eabbc
Compare
BenchmarksBenchmark execution time: 2025-04-02 12:15:44 Comparing candidate commit 76de753 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 496 metrics, 2 unstable metrics. scenario:iast_aspects-ospathbasename_aspect
scenario:iast_aspects-ospathdirname_aspect
|
13eabbc
to
7c4ca59
Compare
7c4ca59
to
a793862
Compare
Datadog ReportBranch report: ✅ 0 Failed, 43 Passed, 290 Skipped, 53.52s Total duration (5m 2.68s time saved) |
1247ac2
to
2ccaaef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also record the right capabilities once they set.
5eb55df
to
e55bebb
Compare
3d93ec6
to
d15eb79
Compare
We introduce the APM_TRACING remote configuration product that allows dispatching remote configuration to the library for remote enablement/ configuration of library components and features.
d15eb79
to
35eeb9a
Compare
5fabcb6
to
ac960ab
Compare
466e7a0
to
2eee4f4
Compare
2eee4f4
to
89b3d7e
Compare
The new plugin interface increases start up time by over 10%. Can we try to optimize this? This seems like a blocker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment about the overhead of this new API
2030f87
to
67b394c
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 244 ± 8 ms. The average import time from base is: 247 ± 8 ms. The import time difference between this PR and base is: -3.2 ± 0.3 ms. Import time breakdownThe following import paths have grown:
|
9774d1f
to
da8200b
Compare
da8200b
to
252be2c
Compare
We introduce the APM_TRACING remote configuration product that allows dispatching remote configuration to the library for remote enablement/ configuration of library components and features. ## Checklist - [ ] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
We refactor the APM_TRACING remote configuration product that allows dispatching remote configuration to the library for remote enablement/configuration of library components and features. Firstly, we make this an actual product, in the sense of the product protocol. We then extend the latter to modularise capabilities and remote APM configuration handling.
Checklist
Reviewer Checklist