feat: add valkey instrumentation support #12060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 28.46s Total duration (25m 10.97s time saved) |
emmettbutler
approved these changes
Jan 23, 2025
2 tasks
ZStriker19
commented
Jan 23, 2025
ZStriker19
commented
Jan 23, 2025
mabdinur
approved these changes
Jan 23, 2025
tabgok
approved these changes
Jan 24, 2025
|
Waiting on a pr for the valkey image to be approved so we can use it in testing. Should be approved shortly and then we can merge this. |
ZStriker19
force-pushed
the
main-AhmadMasry
branch
from
4c53ed0 to
8bbb8da
Compare
ZStriker19
force-pushed
the
main-AhmadMasry
branch
2 times, most recently
from
36c3e7c to
6921d3e
Compare
ZStriker19
commented
Feb 5, 2025
ZStriker19
force-pushed
the
main-AhmadMasry
branch
2 times, most recently
from
5612005 to
1455afd
Compare
Add support for Valkey instrumentation Add valkeycluster service Add release notes Reformat snapshots Apply suggested changes remove ddtrace/contrib/valkey update suitespec to reflect movement of files fixes for moving internal Update releasenotes/notes/add-valkey-support-6cc9f41351dc0cd9.yaml Update docs/integrations.rst fix builddocs with init file use mirror image for testing add valkeycluster to services see if more open pattern fixes switch from entrypoint to command for valkey cluster cont add environment ip value to container use rediscluster container for db fix import remove configure with writer Update tests/contrib/valkey/test_valkey.py Update tests/contrib/valkey/test_valkey.py
ZStriker19
force-pushed
the
main-AhmadMasry
branch
from
1455afd to
345d5d2
Compare
ZStriker19
added a commit
that referenced
this pull request
Feb 6, 2025
**This PR is the work of [AhmadMasry](https://github.com/AhmadMasry)** Moving from #12003 since we have issues running certain tests on forked repos. The Valkey instrumentation is based on the current implementation of the Redis instrumentation, but keeping into consideration that the two projects may deviate and lose compatibility, the Valkey instrumentation is created as a separated module. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: AhmadMasry <[email protected]> Co-authored-by: Ahmad Al-Masry <[email protected]> Co-authored-by: Munir Abdinur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the work of AhmadMasry
Moving from #12003 since we have issues running certain tests on forked repos.
The Valkey instrumentation is based on the current implementation of the Redis instrumentation, but keeping into consideration that the two projects may deviate and lose compatibility, the Valkey instrumentation is created as a separated module.
Checklist
Reviewer Checklist