feat(profiling): builds libdatadog for windows#12073
Merged
taegyunkim merged 58 commits intomainfrom Apr 1, 2025
Merged
Conversation
Contributor
|
|
BenchmarksBenchmark execution time: 2025-04-01 14:54:15 Comparing candidate commit 194ea56 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics. |
719f379 to
7804dab
Compare
Datadog ReportBranch report: ✅ 0 Failed, 475 Passed, 839 Skipped, 10m 2.3s Total duration (18m 59.71s time saved) |
…code_provenance.cpp
sanchda
approved these changes
Mar 25, 2025
erikayasuda
approved these changes
Apr 1, 2025
Collaborator
erikayasuda
left a comment
There was a problem hiding this comment.
Just reviewed the smoke test file to unblock the merge. LGTM 👍
chojomok
pushed a commit
that referenced
this pull request
Apr 7, 2025
A necessary step to deprecate/remove python exporter.
Tested manually on windows using the following code, both from compiling
from sources and using built-wheel from this branch
```Python
import os
import time
from threading import Lock
from threading import Thread
def throw_exception():
val = os.urandom(1)[0]
# Throws an exception if a d20 rolls 1
if val < 4:
raise Exception("Oof owie ouch my bones")
elif val < 8:
return 1 / 0
def factorize_number(number):
factors = []
for i in range(1, number + 1):
if number % i == 0:
factors.append(i)
return factors
def thread_task(lock, number):
for _ in range(1, 50):
# throw_exception()
with lock:
factors = factorize_number(number)
print(factors)
if __name__ == "__main__":
shared_lock = Lock()
numbers = [100001, 499999, 999983]
while True:
T = [Thread(target=thread_task, args=(shared_lock, n)) for n in numbers]
[t.start() for t in T]
[t.join() for t in T]
```
<img width="1201" alt="Screenshot 2025-03-31 at 3 53 12 PM"
src="https://github.com/user-attachments/assets/461c278f-d18a-41c2-a459-9d636accb0ff"
/>
<img width="1332" alt="Screenshot 2025-03-31 at 3 53 23 PM"
src="https://github.com/user-attachments/assets/07e18297-7456-464d-9893-457198a25831"
/>
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
2 tasks
taegyunkim
added a commit
that referenced
this pull request
Jul 25, 2025
It has come to my attention that supporting windows takes quite an effort - #12073: Started on Jan 31, but finally merged on April 1. To iterate on this PR, I had to spin up a windows vm, and iterate there. Still, it was not as smooth as my devex on linux workspace or on corp laptop. - #13984: This PR changes the way dd-trace-py depends on libdatadog, and even without windows support for profiling it's already more than 50 commits and taking 2 engineers' time. And this PR is not the first attempt, previous attempts are #13978, #13603. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A necessary step to deprecate/remove python exporter.
Tested manually on windows using the following code, both from compiling from sources and using built-wheel from this branch
Checklist
Reviewer Checklist