Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: optimize suitspec for integrations #12173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 30, 2025

Currently we run all contrib tests when ddtrace/contrib/internal/* is modified.
For example updating ddtrace/contrib/internal/aiohttp/patch.py will run tests for postgres, flask, django, .....

This fix will optimize ci runs for integration level changes and free up gitlab runners 🤞

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested review from a team as code owners January 30, 2025 16:48
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/suitespec.yml                                             @DataDog/apm-core-python @DataDog/apm-idm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: munir/update-suitspec-contrib
Commit report: bd06e78
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 33.12s Total duration (35m 40.91s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025

Benchmarks

Benchmark execution time: 2025-02-07 23:07:13

Comparing candidate commit 22aca69 in PR branch munir/update-suitspec-contrib with baseline commit 122caa6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 386 metrics, 2 unstable metrics.

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 30, 2025
@erikayasuda erikayasuda requested review from a team as code owners February 6, 2025 19:00
@mabdinur mabdinur force-pushed the munir/update-suitspec-contrib branch from bd06e78 to 52cdad3 Compare February 7, 2025 22:25
@mabdinur mabdinur enabled auto-merge (squash) February 7, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants