chore(asm): don't load appsec modules (iast) if disabled #12184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x-staging #12184 +/- ##
==============================================
Coverage ? 12.74%
==============================================
Files ? 1606
Lines ? 135677
Branches ? 0
==============================================
Hits ? 17298
Misses ? 118379
Partials ? 0 ☔ View full report in Codecov by Sentry. |
christophe-papazian
added
changelog/no-changelog
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 41.04s Total duration (35m 44.47s time saved) |
…endencies_if_serverless
…endencies_if_serverless
BenchmarksBenchmark execution time: 2025-02-03 14:47:27 Comparing candidate commit 484dae9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
christophe-papazian
force-pushed
the
christophe-papazian/remove_appsec_dependencies_if_serverless
branch
from
a2fc25e to
9271c33
Compare
…azian/remove_appsec_dependencies_if_serverless
…endencies_if_serverless
christophe-papazian
changed the title
gnufede
approved these changes
Feb 3, 2025
avara1986
approved these changes
Feb 3, 2025
gnufede
reviewed
Feb 3, 2025
gnufede
approved these changes
Feb 3, 2025
…rless' of github.com:DataDog/dd-trace-py into christophe-papazian/remove_appsec_dependencies_if_serverless
…endencies_if_serverless
emmettbutler
approved these changes
Feb 3, 2025
…endencies_if_serverless
wantsui
approved these changes
Feb 3, 2025
juliewang8
approved these changes
Feb 3, 2025
christophe-papazian
deleted the
christophe-papazian/remove_appsec_dependencies_if_serverless
branch
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.20 2.20
# Navigate to the new working tree
cd .worktrees/backport-2.20
# Create a new branch
git switch --create backport-12184-to-2.20
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ea2a9a505f8f46fccb704c30580780783f26d8e6
# Push it to GitHub
git push --set-upstream origin backport-12184-to-2.20
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.20Then, create a pull request where the |
gnufede
pushed a commit
that referenced
this pull request
Feb 12, 2025
The goal is to make sure no appsec module is loaded if appsec is disabled. This PR is the first one of 2, handling IAST. It removes all non guarded IAST import from outside appsec. - ensure we don't load any iast module if iast is disabled - replace `_is_iast_enabled()` by a field `_iast_enabled` in the asm config APPSEC-56626 - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit ea2a9a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to make sure no appsec module is loaded if appsec is disabled.
This PR is the first one of 2, handling IAST.
It removes all non guarded IAST import from outside appsec.
_is_iast_enabled()by a field_iast_enabledin the asm configAPPSEC-56626
Checklist
strategy
guidelines
applicable)
Reviewer Checklist
API
changes
implications of this PR as reported in the benchmarks PR comment
release branch maintenance
policy