Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(langchain): remove vcr requests in favor of custom mocks #12207

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sabrenner
Copy link
Contributor

@sabrenner sabrenner commented Feb 3, 2025

wip: testing against CI with changes to reduce flaky tests

MLOB-1924

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@sabrenner sabrenner added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

CODEOWNERS have been resolved as:

tests/contrib/langchain/cassettes/cohere_completion_sync_0_2.yaml       @DataDog/ml-observability
tests/contrib/langchain/cassettes/cohere_completion_sync_latest.yaml    @DataDog/ml-observability
tests/snapshots/tests.contrib.langchain.test_langchain.test_cohere_llm_sync_0_2.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_chain_batch_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_sync_call_langchain_openai_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_vision_generate_0_2.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_vision_generate_latest.json  @DataDog/apm-python
riotfile.py                                                             @DataDog/apm-python
tests/contrib/langchain/cassettes/openai_chat_completion_async_generate.yaml  @DataDog/ml-observability
tests/contrib/langchain/conftest.py                                     @DataDog/ml-observability
tests/contrib/langchain/test_langchain.py                               @DataDog/ml-observability
tests/snapshots/tests.contrib.langchain.test_langchain.test_ai21_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_cohere_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_chain_batch.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_chain_complicated.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_chain_simple.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_chain_simple_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_with_tools_openai.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_async_generate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_sync_call_langchain_openai.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_sync_generate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_vision_generate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_sync_multiple_prompts.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_pinecone_vectorstore_similarity_search.json  @DataDog/apm-python
.riot/requirements/12135c7.txt                                          @DataDog/apm-python
.riot/requirements/1282607.txt                                          @DataDog/apm-python
.riot/requirements/13d45e0.txt                                          @DataDog/apm-python
.riot/requirements/14825e2.txt                                          @DataDog/apm-python
.riot/requirements/159ccae.txt                                          @DataDog/apm-python
.riot/requirements/173c2c6.txt                                          @DataDog/apm-python
.riot/requirements/1e5948b.txt                                          @DataDog/apm-python
.riot/requirements/6c3ea5e.txt                                          @DataDog/apm-python
.riot/requirements/6f5fdb6.txt                                          @DataDog/apm-python
.riot/requirements/a69ef68.txt                                          @DataDog/apm-python
.riot/requirements/eddebbc.txt                                          @DataDog/apm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 3, 2025

Datadog Report

Branch report: sabrenner/langchain-use-custom-mocks
Commit report: 3b1ca0e
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 13.08s Total duration (26m 4.23s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2025

Benchmarks

Benchmark execution time: 2025-02-11 21:01:20

Comparing candidate commit 3b1ca0e in PR branch sabrenner/langchain-use-custom-mocks with baseline commit 848c921 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@Kyle-Verhoog Kyle-Verhoog force-pushed the sabrenner/langchain-use-custom-mocks branch from e672b42 to d1c502c Compare February 4, 2025 23:06
@erikayasuda erikayasuda changed the base branch from 3.x-staging to main February 6, 2025 19:10
@Kyle-Verhoog Kyle-Verhoog force-pushed the sabrenner/langchain-use-custom-mocks branch from 948a7bf to 198d559 Compare February 11, 2025 19:40
@Kyle-Verhoog Kyle-Verhoog force-pushed the sabrenner/langchain-use-custom-mocks branch from 198d559 to 3b1ca0e Compare February 11, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants