-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(langchain): remove openai cost span metric #12233
Conversation
|
releasenotes/notes/deprecate-langchain-openai-cost-042f3a04cda9d23b.yaml
Outdated
Show resolved
Hide resolved
6c21109
to
00649e5
Compare
releasenotes/notes/deprecate-langchain-openai-cost-042f3a04cda9d23b.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some comments about the release note
1573404
to
a645ba2
Compare
36d4369
to
e8f7430
Compare
e8f7430
to
517d8c9
Compare
BenchmarksBenchmark execution time: 2025-02-05 23:00:57 Comparing candidate commit ec1bd48 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
This PR removes the `langchain.tokens.total_cost` span metric which estimates the total cost of the llm interaction (and also by extension the wrapped chain span). This was an overly complex implementation that relied on a third party (langchain-community + tiktoken) library which is more-or-less deprecated when we can simply point users to enable LLM Observability to do the cost estimation for OpenAI spans anyway. Note that this shouldn't break anything other than the span metric tag itself, integration metrics are already disabled with 3.0. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
MLOB-2207
This PR removes the
langchain.tokens.total_cost
span metric which estimates the total cost of the llm interaction (and also by extension the wrapped chain span). This was an overly complex implementation that relied on a third party (langchain-community + tiktoken) library which is more-or-less deprecated when we can simply point users to enable LLM Observability to do the cost estimation for OpenAI spans anyway.Note that this shouldn't break anything other than the span metric tag itself, integration metrics are already disabled with 3.0.
Checklist
Reviewer Checklist