Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(langchain): remove openai cost span metric #12233

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Feb 5, 2025

MLOB-2207

This PR removes the langchain.tokens.total_cost span metric which estimates the total cost of the llm interaction (and also by extension the wrapped chain span). This was an overly complex implementation that relied on a third party (langchain-community + tiktoken) library which is more-or-less deprecated when we can simply point users to enable LLM Observability to do the cost estimation for OpenAI spans anyway.

Note that this shouldn't break anything other than the span metric tag itself, integration metrics are already disabled with 3.0.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@Yun-Kim Yun-Kim requested review from a team as code owners February 5, 2025 20:29
@Yun-Kim Yun-Kim requested review from juanjux and duncanista February 5, 2025 20:29
Copy link
Contributor

github-actions bot commented Feb 5, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/deprecate-langchain-openai-cost-042f3a04cda9d23b.yaml  @DataDog/apm-python
ddtrace/contrib/internal/langchain/constants.py                         @DataDog/ml-observability
ddtrace/contrib/internal/langchain/patch.py                             @DataDog/ml-observability
tests/contrib/langchain/test_langchain.py                               @DataDog/ml-observability
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_chain_batch.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_chain_complicated.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_chain_nested.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_chain_simple.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_chain_simple_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_lcel_with_tools_openai.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_async_generate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_sync_call_langchain_openai.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_sync_generate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_chat_model_vision_generate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_async.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_sync.json  @DataDog/apm-python
tests/snapshots/tests.contrib.langchain.test_langchain.test_openai_llm_sync_multiple_prompts.json  @DataDog/apm-python

@Yun-Kim Yun-Kim force-pushed the yunkim/fix-langchain-deprecated-cost branch from 6c21109 to 00649e5 Compare February 5, 2025 20:43
Copy link
Contributor

@lievan lievan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some comments about the release note

@Yun-Kim Yun-Kim changed the title deprecation(langchain): fix deprecated token callback, deprecate openai cost metric chore(langchain): fix deprecated token callback, deprecate openai cost metric Feb 5, 2025
@Yun-Kim Yun-Kim force-pushed the yunkim/fix-langchain-deprecated-cost branch from 1573404 to a645ba2 Compare February 5, 2025 21:23
@Yun-Kim Yun-Kim force-pushed the yunkim/fix-langchain-deprecated-cost branch from 36d4369 to e8f7430 Compare February 5, 2025 21:30
@Yun-Kim Yun-Kim changed the title chore(langchain): fix deprecated token callback, deprecate openai cost metric chore(langchain): remove openai cost span metric Feb 5, 2025
@Yun-Kim Yun-Kim force-pushed the yunkim/fix-langchain-deprecated-cost branch from e8f7430 to 517d8c9 Compare February 5, 2025 21:34
@Yun-Kim Yun-Kim enabled auto-merge (squash) February 5, 2025 21:49
@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2025

Benchmarks

Benchmark execution time: 2025-02-05 23:00:57

Comparing candidate commit ec1bd48 in PR branch yunkim/fix-langchain-deprecated-cost with baseline commit 25e7e2e in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@erikayasuda erikayasuda disabled auto-merge February 6, 2025 02:20
@erikayasuda erikayasuda merged commit 9ba79f4 into 3.x-staging Feb 6, 2025
270 checks passed
@erikayasuda erikayasuda deleted the yunkim/fix-langchain-deprecated-cost branch February 6, 2025 02:20
ZStriker19 pushed a commit that referenced this pull request Feb 6, 2025
This PR removes the `langchain.tokens.total_cost` span metric which
estimates the total cost of the llm interaction (and also by extension
the wrapped chain span). This was an overly complex implementation that
relied on a third party (langchain-community + tiktoken) library which
is more-or-less deprecated when we can simply point users to enable LLM
Observability to do the cost estimation for OpenAI spans anyway.

Note that this shouldn't break anything other than the span metric tag
itself, integration metrics are already disabled with 3.0.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants