Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tracer): avoids shutting down the global tracer in the main process #12235

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Feb 5, 2025

When the tracer is shutdown span aggregators are removed. If this is done outside of a subprocess it will impact the state of the tracer in future test runs. This PR ensures the tracer shutdown tests are only run in a subprocess.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested a review from erikayasuda February 5, 2025 22:04
Copy link
Contributor

github-actions bot commented Feb 5, 2025

CODEOWNERS have been resolved as:

tests/tracer/test_propagation.py                                        @DataDog/apm-sdk-api-python
tests/tracer/test_tracer.py                                             @DataDog/apm-sdk-api-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: munir/debug-broken-tracer-test
Commit report: 4cd934e
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 39.65s Total duration (25m 11.27s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2025

Benchmarks

Benchmark execution time: 2025-02-06 21:31:38

Comparing candidate commit c5f0eba in PR branch munir/debug-broken-tracer-test with baseline commit 1247ac2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur force-pushed the munir/debug-broken-tracer-test branch from 4cd934e to a993302 Compare February 5, 2025 23:12
@mabdinur mabdinur changed the title munir: try your best ci(tracer): do not shutdown the global tracer Feb 5, 2025
tests/tracer/test_tracer.py Outdated Show resolved Hide resolved
@mabdinur mabdinur changed the title ci(tracer): do not shutdown the global tracer ci(tracer): avoids shutdown the global tracer in tests Feb 6, 2025
@mabdinur mabdinur force-pushed the munir/debug-broken-tracer-test branch from 9bf884f to c62f3b0 Compare February 6, 2025 14:31
@mabdinur mabdinur force-pushed the munir/debug-broken-tracer-test branch from c62f3b0 to 8a1ec47 Compare February 6, 2025 14:59
@mabdinur mabdinur marked this pull request as ready for review February 6, 2025 14:59
@mabdinur mabdinur requested a review from a team as a code owner February 6, 2025 14:59
@mabdinur mabdinur changed the title ci(tracer): avoids shutdown the global tracer in tests ci(tracer): avoids shutting down the global tracer in the main process Feb 6, 2025
@erikayasuda erikayasuda changed the base branch from 3.x-staging to main February 6, 2025 19:09
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 6, 2025
@mabdinur mabdinur enabled auto-merge (squash) February 6, 2025 20:36
@erikayasuda erikayasuda requested review from a team as code owners February 6, 2025 20:43
@mabdinur mabdinur force-pushed the munir/debug-broken-tracer-test branch from 8a1ec47 to c5f0eba Compare February 6, 2025 20:51
@mabdinur mabdinur merged commit 4b74d31 into main Feb 7, 2025
268 checks passed
@mabdinur mabdinur deleted the munir/debug-broken-tracer-test branch February 7, 2025 11:54
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
#12235)

When the tracer is shutdown span aggregators are removed. If this is
done outside of a subprocess it will impact the state of the tracer in
future test runs. This PR ensures the tracer shutdown tests are only run
in a subprocess.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 4b74d31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 3.0 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants