-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(tracer): avoids shutting down the global tracer in the main process #12235
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 39.65s Total duration (25m 11.27s time saved) |
BenchmarksBenchmark execution time: 2025-02-06 21:31:38 Comparing candidate commit c5f0eba in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
4cd934e
to
a993302
Compare
9bf884f
to
c62f3b0
Compare
c62f3b0
to
8a1ec47
Compare
8a1ec47
to
c5f0eba
Compare
#12235) When the tracer is shutdown span aggregators are removed. If this is done outside of a subprocess it will impact the state of the tracer in future test runs. This PR ensures the tracer shutdown tests are only run in a subprocess. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 4b74d31)
When the tracer is shutdown span aggregators are removed. If this is done outside of a subprocess it will impact the state of the tracer in future test runs. This PR ensures the tracer shutdown tests are only run in a subprocess.
Checklist
Reviewer Checklist