Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update main with 3.x-staging #12237

Closed
wants to merge 1 commit into from
Closed

chore: update main with 3.x-staging #12237

wants to merge 1 commit into from

Conversation

erikayasuda
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda @Yun-Kim
@ncybul @nsrip-dd @wconti27 @christophe-papazian @mabdinur @randomanderson @brettlangdon
chore: update 3.x-staging with main (#12244)
1247ac2 
This is to ensure no commits on `main` get erased when we force-push
`3.x-staging` into `main`. This is to cover the one commit that slipped:
#12036

After this is merged, `3.x-staging` should be ready to be merged into
`main` safely for dd-trace-py to upgrade to 3.x

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Yun Kim <[email protected]>
Co-authored-by: Nicole Cybul <[email protected]>
Co-authored-by: Nick Ripley <[email protected]>
Co-authored-by: William Conti <[email protected]>
Co-authored-by: Christophe Papazian <[email protected]>
Co-authored-by: Munir Abdinur <[email protected]>
Co-authored-by: Laplie Anderson <[email protected]>
Co-authored-by: Brett Langdon <[email protected]>
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: 3.x-staging
Commit report: 1247ac2
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 24.65s Total duration (25m 23.2s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025

Benchmarks

Benchmark execution time: 2025-02-06 18:51:39

Comparing candidate commit 1247ac2 in PR branch 3.x-staging with baseline commit b83292b in branch main.

Found 6 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

scenario:ratelimiter-defaults

  • 🟩 execution_time [-2.044µs; -2.014µs] or [-46.494%; -45.804%]

scenario:ratelimiter-high_rate_limit

  • 🟩 execution_time [-2.228µs; -2.192µs] or [-48.103%; -47.339%]

scenario:ratelimiter-long_window

  • 🟩 execution_time [-2.084µs; -2.048µs] or [-47.017%; -46.215%]

scenario:ratelimiter-low_rate_limit

  • 🟩 execution_time [-1.905µs; -1.873µs] or [-44.686%; -43.935%]

scenario:ratelimiter-no_rate_limit

  • 🟩 execution_time [-1.926µs; -1.907µs] or [-70.154%; -69.493%]

scenario:ratelimiter-short_window

  • 🟩 execution_time [-1.903µs; -1.872µs] or [-43.268%; -42.561%]

@erikayasuda erikayasuda closed this Feb 6, 2025
@erikayasuda erikayasuda deleted the 3.x-staging branch February 6, 2025 19:13
@erikayasuda erikayasuda restored the 3.x-staging branch February 6, 2025 19:25
@erikayasuda erikayasuda deleted the 3.x-staging branch February 6, 2025 20:41
@cbeauchesne cbeauchesne restored the 3.x-staging branch February 7, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erikayasuda