Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(langchain): mark flaky test [backport 2.20] #12259

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 7, 2025

Backport 898e38c from #12190 to 2.20.

Marking a flaky test for main. This test will be removed entirely in deprecation once the 3.x-staging branch is merged.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Marking a flaky test for `main`. This test will be removed entirely in
deprecation once the `3.x-staging` branch is merged.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 898e38c)
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 7, 2025
@github-actions github-actions bot requested a review from a team as a code owner February 7, 2025 15:53
@brettlangdon brettlangdon reopened this Feb 7, 2025
Copy link
Contributor Author

github-actions bot commented Feb 7, 2025

CODEOWNERS have been resolved as:

tests/contrib/langchain/test_langchain.py                               @DataDog/ml-observability

@brettlangdon brettlangdon enabled auto-merge (squash) February 7, 2025 16:01
@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2025

Benchmarks

Benchmark execution time: 2025-02-07 16:37:30

Comparing candidate commit 59c6326 in PR branch backport-12190-to-2.20 with baseline commit ad8057c in branch 2.20.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 208 metrics, 2 unstable metrics.

@brettlangdon brettlangdon disabled auto-merge February 7, 2025 17:36
@brettlangdon brettlangdon merged commit a251d35 into 2.20 Feb 7, 2025
226 of 228 checks passed
@brettlangdon brettlangdon deleted the backport-12190-to-2.20 branch February 7, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants