fix(internal): move logging rate limiter to log filter [backport 2.x]

[brettlangdon]

Backport 122caa6 from #12243 to 2.x.

PGB-61

Fixes #4856

Improve and fix internal ddtrace.internal.logger.get_logger implementation.

Today we enforce that all internal ddtrace loggers use a customer class implementation of logging.Logger to ensure we can apply custom logic like forwarding internal error logs to telemetry and rate limiting the volume of ddtrace logs allowed.

However, the current implementation requires knowledge and use of internal logging.getLogger details, and it tries to replicate some of the behavior. This has caused us to miss a key lock around a shared resource that was expected.

This change in implementation moves to apply our logic via a log filter instead of a customer logger class.

A filter approach will provide the same logic with a much more simple approach which will be easier to reason and maintain which will avoid the bug/race condition found.

The downside to this approach is that loggers can have multiple filters, and the first filter to determine that a log record should not be logged will prevent the other filters from running. This means if a user applies a log filter to one of our ddtrace.* loggers, then we may miss collecting and forwarding the internal errors to telemetry. Otherwise, if a user filter prevents a log from being logged, then it won't apply towards our rate limit (which is acceptable/correct).

Checklist

• PR author has checked that all the criteria below are met
• The PR description includes an overview of the change
• The PR description articulates the motivation for the change
• The change includes tests OR the PR description describes a testing strategy
• The PR description notes risks associated with the change, if any
• Newly-added code is easy to change
• The change follows the library release note guidelines
• The change includes or references documentation updates if necessary
• Backport labels are set (if applicable)

Reviewer Checklist

• Reviewer has checked that all the criteria below are met
• Title is accurate
• All changes are related to the pull request's stated goal
• Avoids breaking API changes
• Testing strategy adequately addresses listed risks
• Newly-added code is easy to change
• Release note makes sense to a user of the library
• If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
• Backport labels are set in a manner that is consistent with the release branch maintenance policy

[github-actions]

CODEOWNERS have been resolved as:

releasenotes/notes/fix-internal-logging-init-6058c02b527cdf77.yaml      @DataDog/apm-python
ddtrace/internal/logger.py                                              @DataDog/apm-core-python
tests/tracer/test_logger.py                                             @DataDog/apm-sdk-api-python

[datadog-dd-trace-py-rkomorn]

Datadog Report

Branch report: backport-12243-to-2.x
Commit report: b663b05
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 34.24s Total duration (32m 44.83s time saved)

[pr-commenter]

Benchmarks

Benchmark execution time: 2025-02-10 14:05:39

Comparing candidate commit b663b05 in PR branch backport-12243-to-2.x with baseline commit 898e38c in branch 2.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.