Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracer): ensure ot-baggage headers are propagated in wsgi apps #12308

Merged
merged 7 commits into from
Feb 12, 2025

Conversation

rachelyangdog
Copy link
Contributor

@rachelyangdog rachelyangdog commented Feb 12, 2025

Opentracer baggage to handle wsgi headers. Resolves github issue #9908.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@rachelyangdog rachelyangdog requested a review from a team as a code owner February 12, 2025 18:35
Copy link
Contributor

github-actions bot commented Feb 12, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/opentracer-baggage-prefix-fix-909cd6f665eb2c84.yaml  @DataDog/apm-python
ddtrace/propagation/http.py                                             @DataDog/apm-sdk-api-python
tests/tracer/test_propagation.py                                        @DataDog/apm-sdk-api-python

@rachelyangdog rachelyangdog added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Feb 12, 2025
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 12, 2025

Datadog Report

Branch report: rachel.yang/opentracer-baggage-bug
Commit report: 6a7988e
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1109 Skipped, 3m 44.46s Total duration (25m 29.86s time saved)

Copy link
Contributor

@mabdinur mabdinur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a release note, aside from that this looks good to me!

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025

Benchmarks

Benchmark execution time: 2025-02-12 21:48:22

Comparing candidate commit 6a7988e in PR branch rachel.yang/opentracer-baggage-bug with baseline commit 0fcafa2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@rachelyangdog rachelyangdog requested a review from a team as a code owner February 12, 2025 19:59
@mabdinur mabdinur changed the title fix(tracer): opentracer baggage wsgi header prefix fix(tracer): ensure ot-baggage headers are propagated in wsgi apps Feb 12, 2025
@rachelyangdog rachelyangdog enabled auto-merge (squash) February 12, 2025 21:12
@rachelyangdog rachelyangdog merged commit 4f22203 into main Feb 12, 2025
618 checks passed
@rachelyangdog rachelyangdog deleted the rachel.yang/opentracer-baggage-bug branch February 12, 2025 21:50
github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
…12308)

Opentracer baggage to handle wsgi headers. Resolves github issue #9908.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Munir Abdinur <[email protected]>
(cherry picked from commit 4f22203)
github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
…12308)

Opentracer baggage to handle wsgi headers. Resolves github issue #9908.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Munir Abdinur <[email protected]>
(cherry picked from commit 4f22203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants